Title: fix(workflow): stop the coloured knob leaving a barb at each shoulder tip by waleedlatif1 · Pull Request #6632 · simstudioai/sim · GitHub
Open Graph Title: fix(workflow): stop the coloured knob leaving a barb at each shoulder tip by waleedlatif1 · Pull Request #6632 · simstudioai/sim
X Title: fix(workflow): stop the coloured knob leaving a barb at each shoulder tip by waleedlatif1 · Pull Request #6632 · simstudioai/sim
Description: Summary The connection knob is a recolour of one stretch of the card outline, so its path has to be the outline's own path. It wasn't: the span was cut at the point the bulge falls under the visibility threshold — not one of the points the silhouette sampled — so the knob sat on a grid of its own, and a span clamped its end control points to the bare perimeter tangent while the silhouette derives every control point from the samples either side of it. The knob was left flat where the silhouette had already begun its descent, and the uncovered sliver of dark stroke read as a small spur poking off the shoulder. Clearest on the Error output's outer shoulder, against the card's bottom-right corner. Measure the span against the interval the silhouette resamples the bulge over instead of in whole pixels, and sample a step wide on each side before trimming back so every emitted segment has the neighbours the silhouette had. Painted footprint is unchanged — the knob starts and ends within 0.2px of where it did. Type of Change Bug fix Testing Dumped the real painted path from a mounted WorkflowBlockBorder and rendered it at 175x, before and after — the spur is gone from both shoulders and the shape is otherwise identical. Two tests pin the invariant that every coloured knob's bezier commands appear verbatim in the silhouette. Both fail on the unfixed code. The second covers merged resample intervals and an odd tab length, where measuring the span in whole pixels would still have landed half a step off. Known limit, unchanged by this PR: a knob is painted from its own bulge alone while the silhouette takes the max over all of them, so two bulges tall enough to overlap genuinely part company. No port layout the editor builds puts them that close. Not yet checked on a running canvas — only in the extracted path render. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The connection knob is a recolour of one stretch of the card outline, so its path has to be the outline's own path. It wasn't: the span was cut at the point the bulge falls under t...
X Description: Summary The connection knob is a recolour of one stretch of the card outline, so its path has to be the outline's own path. It wasn't: the span was cut at the point the bulge falls...
Opengraph URL: https://github.com/simstudioai/sim/pull/6632
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b7fd2a43-a835-cbc2-2d52-eff453fbfb6b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A90C:34FC0A:A9D68D:E8014A:6AFB50E2 |
| html-safe-nonce | 82584273b662c3e1c777559952270a9140d5068fcbc851915d1c603ee313d8ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTBDOjM0RkMwQTpBOUQ2OEQ6RTgwMTRBOjZBRkI1MEUyIiwidmlzaXRvcl9pZCI6Ijc2NjM4MTI2MzgyOTkzNDUxMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b95e6de59e33e52cffd6d3f31652f0bff7acd417d38b899689fd0f8f21fb7632 |
| hovercard-subject-tag | pull_request:4264916864 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6632/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The connection knob is a recolour of one stretch of the card outline, so its path has to be the outline's own path. It wasn't: the span was cut at the point the bulge falls under t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width