René's URL Explorer Experiment


Title: fix(copilot): keep a file-preview failure from stripping a tool call's arguments by waleedlatif1 · Pull Request #6621 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): keep a file-preview failure from stripping a tool call's arguments by waleedlatif1 · Pull Request #6621 · simstudioai/sim

X Title: fix(copilot): keep a file-preview failure from stripping a tool call's arguments by waleedlatif1 · Pull Request #6621 · simstudioai/sim

Description: Summary The workspace file preview adapter runs while the workspace_file tool-call frame is still on the wire, before per-call dispatch builds a call-scoped context — so the execution context it receives is turn-scoped and carries no toolCallId. The file delegation requires one, so resolving a path-shaped preview target threw on every call. The SSE handler swallows a handler throw and moves to the next event, which abandoned the rest of that event. The tool-call frame therefore never registered its arguments, and the call was later dispatched from the checkpoint with an empty payload — failing schema validation with every required property missing. The model got back an opaque error and retried the same call over and over, so the requested file edit never happened. Fix: bind the frame's own tool call id before entering the file use cases; resolve the preview target best effort (matching how the preview base load already degrades); and stop a preview failure from dropping a tool-call frame in the stream loop. The stream fixtures put a synthetic toolCallId on a turn-scoped context, a shape the chat lifecycle never produces — that is why the tests stayed green. Removed, so they now exercise the real shape. Known-remaining, deliberately out of scope: prePersistClientExecutableToolCall sits in the same window before the frame registers its arguments and is likewise unguarded. It must not get the same swallow — it is where a gated call is stamped awaiting_approval, so swallowing there would let a gated tool through ungated. The structural answer is to register frame state before the presentation and persistence stages, which reorders emissions the client depends on. Type of Change Bug fix Testing bun run type-check and bunx vitest run lib/copilot/request/go/ in apps/sim (27 passing). Reverting only the two source files turns 4 of them red, including the exact error string seen in production. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The workspace file preview adapter runs while the workspace_file tool-call frame is still on the wire, before per-call dispatch builds a call-scoped context — so the execution context it r...

X Description: Summary The workspace file preview adapter runs while the workspace_file tool-call frame is still on the wire, before per-call dispatch builds a call-scoped context — so the execution context it r...

Opengraph URL: https://github.com/simstudioai/sim/pull/6621

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa4a5602-cf30-d139-74af-67bea7a08089
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1AA:1D4A3:DD9D49:12F2325:6AFB5B57
html-safe-nonceac683a73a49066b33d2b4cb29a77d9cf4329e618a4f37c36542e56050516ef70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUFBOjFENEEzOkREOUQ0OToxMkYyMzI1OjZBRkI1QjU3IiwidmlzaXRvcl9pZCI6IjQzMjI2Mzk4NjIyNzcyOTkwMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac32fb113acffb7ab744c2a353e2c2dfa97aeed402db0b7139e2740bbc281d42b7
hovercard-subject-tagpull_request:4262301500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6621/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The workspace file preview adapter runs while the workspace_file tool-call frame is still on the wire, before per-call dispatch builds a call-scoped context — so the execution context it r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6621/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6621%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6621%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6621/files
Reloadhttps://github.com/simstudioai/sim/pull/6621/files
Reloadhttps://github.com/simstudioai/sim/pull/6621/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/copilot-workspace-file-tool-argshttps://github.com/simstudioai/sim/tree/fix/copilot-workspace-file-tool-args
Conversation 3 https://github.com/simstudioai/sim/pull/6621
Commits 1 https://github.com/simstudioai/sim/pull/6621/commits
Checks 30 https://github.com/simstudioai/sim/pull/6621/checks
Files changed https://github.com/simstudioai/sim/pull/6621/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6621/files
fix(copilot): keep a file-preview failure from stripping a tool call's arguments https://github.com/simstudioai/sim/pull/6621/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6621/files
b7a3e4d fix(copilot): keep a file-preview failure from stripping a tool call'… waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6621/commits/b7a3e4dd4d0900025394fc417f19b61bca186ad7
Clear filters https://github.com/simstudioai/sim/pull/6621/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6621/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6621/files
file-preview-adapter.test.ts https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
file-preview-adapter.ts https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
stream.test.ts https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
stream.ts https://github.com/simstudioai/sim/pull/6621/files#diff-13aedd18e898363f0a016bac0bbe474e8e9bc6bc5526f939a6728034fc997694
apps/sim/lib/copilot/request/go/file-preview-adapter.test.tshttps://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
View file https://github.com/simstudioai/sim/blob/b7a3e4dd4d0900025394fc417f19b61bca186ad7/apps/sim/lib/copilot/request/go/file-preview-adapter.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6621/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
https://github.com/simstudioai/sim/pull/6621/files#diff-2acca0eff9606361f70603bbd34fd985f439949def1ac233f4323ce63c559110
apps/sim/lib/copilot/request/go/file-preview-adapter.tshttps://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
View file https://github.com/simstudioai/sim/blob/b7a3e4dd4d0900025394fc417f19b61bca186ad7/apps/sim/lib/copilot/request/go/file-preview-adapter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6621/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
https://github.com/simstudioai/sim/pull/6621/files#diff-8f1e3d765fa694dc2a0c644a43c6460448e70a2b73ddf04b18e63b57af4c36af
apps/sim/lib/copilot/request/go/stream.test.tshttps://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
View file https://github.com/simstudioai/sim/blob/b7a3e4dd4d0900025394fc417f19b61bca186ad7/apps/sim/lib/copilot/request/go/stream.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6621/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
https://github.com/simstudioai/sim/pull/6621/files#diff-4c78bf8bbf75d2f2bbc6a0960e2dd7ceff3b99aff445fb2020470de319825242
apps/sim/lib/copilot/request/go/stream.tshttps://github.com/simstudioai/sim/pull/6621/files#diff-13aedd18e898363f0a016bac0bbe474e8e9bc6bc5526f939a6728034fc997694
View file https://github.com/simstudioai/sim/blob/b7a3e4dd4d0900025394fc417f19b61bca186ad7/apps/sim/lib/copilot/request/go/stream.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6621/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6621/files#diff-13aedd18e898363f0a016bac0bbe474e8e9bc6bc5526f939a6728034fc997694
https://github.com/simstudioai/sim/pull/6621/files#diff-13aedd18e898363f0a016bac0bbe474e8e9bc6bc5526f939a6728034fc997694
Please reload this pagehttps://github.com/simstudioai/sim/pull/6621/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.