René's URL Explorer Experiment


Title: fix(executor): carry child provenance across the workflow agent tool result by waleedlatif1 · Pull Request #6619 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): carry child provenance across the workflow agent tool result by waleedlatif1 · Pull Request #6619 · simstudioai/sim

X Title: fix(executor): carry child provenance across the workflow agent tool result by waleedlatif1 · Pull Request #6619 · simstudioai/sim

Description: Summary A workflow invoked as an agent tool now resolves {{VAR}} to the real decrypted value in the child run (#6611). The tool result handed back to the model vendor is projected through a registry that had dropped those entries, so the plaintext crosses to the vendor verbatim. This is on staging only — the release it belongs to has not been promoted — but it is a promotion blocker for staging → main. What reaches the vendor today on staging. For an agent whose tool is a workflow, the tool message serialized into the next model request contains the child's decrypted environment-variable values — in output.result, and also inside output.childTraceSpans, which carries every child block's inputs and outputs. Reproduced with the real registry, the real EnvResolver, and the real model projection: a live sk-live-… style token appears in both. Mechanism. Model-facing projection (projectToolResultForCopilot) forks with registry.forkForPropagatedEntries(), which keeps only entries a result explicitly carried. EnvResolver (executor/variables/resolvers/env.ts) records the resolution without propagated, unlike the other boundaries that hand a value onward (tools/index.ts, providers/runtime-context.ts). The child shares the caller's registry object, so blockLogs, trace spans and error diagnostics still redact correctly — they read the unforked registry. Only the model fork loses the entries. The blast radius is larger than the child's final output: mapChildOutputToParent puts the full childTraceSpans into the returned object, and postProcessToolOutput strips only __-prefixed keys. Why main does not have this. There, workflow_executor was an HTTP tool: the execute route emitted __resolvedSecretTraceProvenance, the tool imported it as propagated: true, and transformResponse curated the body so childTraceSpans never crossed. The in-process branch returns before any of that runs. The fix runWorkflowTool exports committed provenance for the value it is about to return and imports it back with { trusted: true }, which marks those entries propagated. This is the crossing the custom-block branch already performs in workflow-handler.ts; the non-custom branch skipped it only because the two registries are the same object — exactly the assumption the model fork breaks. Output-projection only. The returned result is byte-identical and the child executes exactly as before; only registry metadata changes. Applied on both the success and the failure return, so a child error message that embeds a resolved secret is covered too. Redacted values render as {{NAME}} — the same literal the model saw before the regression. Fails closed: an unusable envelope marks the registry incomplete, which reduces (never widens) what the model receives. Why not the alternative (marking EnvResolver's records propagated): propagated means "this result carries this secret across a boundary", not "a block consumed this secret". EnvResolver runs at input resolution for the executing block, in every workflow run, into the run-scoped registry — flipping it there would restate an output-crossing fact at an input site and change what crosses at every unrelated boundary in the product, for a defect that exists at exactly one. Smaller diff, much wider reach, and it does not become more correct than the precedent it replaces. Fixing the boundary that is actually broken keeps the canvas workflow block and the custom-block path untouched. On childTraceSpans. Curation alone would not have fixed result, so it was never a substitute. I also did not drop it here: the canvas workflow_input block runs through the same runWorkflowTool, and block-executor lifts childTraceSpans off that output into the block log for trace nesting (span-factory reads it) before stripping it from block state. Dropping it in the runner would silently break child-run traces in the UI. Child block I/O reaching the vendor is still questionable on its own merits, but it needs a model-facing output projection hook, which does not exist today (tools have request.modelInput, no output equivalent) — worth a follow-up, and it is now redacted either way. Short-literal caveat, stated plainly. MIN_SUBSTITUTABLE_LITERAL_LENGTH = 8 governs detection as well as substitution, so an environment value of 7 characters or fewer is not covered by this fix — not in the model result, and not in logs or traces either. That floor is deliberate (it subsumed the per-value exception lists that fixed prior false-positive incidents) and this PR does not touch it. A test pins the behavior so it is documented rather than silent. Testing New tests in workflow-tool-runner.test.ts drive the real ResolvedSecretTraceRegistry, the real EnvResolver, and the real projectToolResultForCopilot. The two leak tests fail on plain staging (secret present in result and in childTraceSpans; secret present in the projected error) and pass with the fix. A third test asserts an unrelated configured secret stays inert, and a fourth pins the short-literal limitation. Green: full executor/ suite (1947), tools/index, resolved-secret registry / projection / refusal suites, providers/runtime-context. bun run type-check clean; biome clean. Type of Change Bug fix Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A workflow invoked as an agent tool now resolves {{VAR}} to the real decrypted value in the child run (#6611). The tool result handed back to the model vendor is projected through a registr...

X Description: Summary A workflow invoked as an agent tool now resolves {{VAR}} to the real decrypted value in the child run (#6611). The tool result handed back to the model vendor is projected through a registr...

Opengraph URL: https://github.com/simstudioai/sim/pull/6619

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a0c5de3-c6e8-d595-167c-e8d7cc651f73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8E4:3D6EF:24F438:33CAD0:6AFB5253
html-safe-nonce4e7bbdc33b7c27073fecba6243a4f9b6477b6f13e457d6405d8e775e6bcc6653
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEU0OjNENkVGOjI0RjQzODozM0NBRDA6NkFGQjUyNTMiLCJ2aXNpdG9yX2lkIjoiNDkwNzAwMjAxMDA4MDU5NjU2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56d23de020b35f0ba0d761f313c070cf4ed70d2ad1cc9161c1a2699b9a58b02b
hovercard-subject-tagpull_request:4260768038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6619/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A workflow invoked as an agent tool now resolves {{VAR}} to the real decrypted value in the child run (#6611). The tool result handed back to the model vendor is projected through a registr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6619/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6619%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6619%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6619/files
Reloadhttps://github.com/simstudioai/sim/pull/6619/files
Reloadhttps://github.com/simstudioai/sim/pull/6619/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workflow-tool-result-secret-provenancehttps://github.com/simstudioai/sim/tree/fix/workflow-tool-result-secret-provenance
Conversation 4 https://github.com/simstudioai/sim/pull/6619
Commits 1 https://github.com/simstudioai/sim/pull/6619/commits
Checks 30 https://github.com/simstudioai/sim/pull/6619/checks
Files changed https://github.com/simstudioai/sim/pull/6619/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6619/files
fix(executor): carry child provenance across the workflow agent tool result https://github.com/simstudioai/sim/pull/6619/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6619/files
b5a099c fix(executor): carry child provenance across the workflow agent tool … waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6619/commits/b5a099c59c3fab278b9dbfc52550edb74911ae8d
Clear filters https://github.com/simstudioai/sim/pull/6619/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6619/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6619/files
workflow-tool-runner.test.ts https://github.com/simstudioai/sim/pull/6619/files#diff-3fb03b6818608e62eca6cf2c5604cb665f55e26c38d64cfd5e6481d5f5f0a920
workflow-tool-runner.ts https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
apps/sim/executor/handlers/workflow/workflow-tool-runner.test.tshttps://github.com/simstudioai/sim/pull/6619/files#diff-3fb03b6818608e62eca6cf2c5604cb665f55e26c38d64cfd5e6481d5f5f0a920
View file https://github.com/simstudioai/sim/blob/b5a099c59c3fab278b9dbfc52550edb74911ae8d/apps/sim/executor/handlers/workflow/workflow-tool-runner.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6619/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6619/files#diff-3fb03b6818608e62eca6cf2c5604cb665f55e26c38d64cfd5e6481d5f5f0a920
https://github.com/simstudioai/sim/pull/6619/files#diff-3fb03b6818608e62eca6cf2c5604cb665f55e26c38d64cfd5e6481d5f5f0a920
https://github.com/simstudioai/sim/pull/6619/files#diff-3fb03b6818608e62eca6cf2c5604cb665f55e26c38d64cfd5e6481d5f5f0a920
apps/sim/executor/handlers/workflow/workflow-tool-runner.tshttps://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
View file https://github.com/simstudioai/sim/blob/b5a099c59c3fab278b9dbfc52550edb74911ae8d/apps/sim/executor/handlers/workflow/workflow-tool-runner.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6619/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
https://github.com/simstudioai/sim/pull/6619/files#diff-e6542e73bb496b9e1f881d492538e13844587410fa73e36dd0846ba64ae6b93f
Please reload this pagehttps://github.com/simstudioai/sim/pull/6619/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.