René's URL Explorer Experiment


Title: test(export): pin the table and tool-param loss the sanitized export accepts by waleedlatif1 · Pull Request #6613 · simstudioai/sim · GitHub

Open Graph Title: test(export): pin the table and tool-param loss the sanitized export accepts by waleedlatif1 · Pull Request #6613 · simstudioai/sim

X Title: test(export): pin the table and tool-param loss the sanitized export accepts by waleedlatif1 · Pull Request #6613 · simstudioai/sim

Description: Summary This PR intentionally changes no behavior. It pins an existing trade-off in place, documents it, and removes a footgun. No redaction logic is touched. #6591 turned on redactOpaqueCredentialInputs for the workflow export path. That closed a real leak: a bearer token pasted into an API block's Headers cell, and secrets in custom tool params, were reaching the v1/v2 export APIs and the in-app Export as JSON in plaintext. Its unpriced cost shipped with it. An export/import round trip now returns API blocks with empty Headers and Query Params, and drops {{ENV_VAR}} references inside table cells even though the same reference in a password field survives. Nothing in the test suite described either side of that trade, so it could be flipped in either direction without anyone noticing — and an earlier audit did recommend reverting the flag. adds round-trip fixtures (an api block with two table sub-blocks, an agent block with a custom tool) plus assertions pinning the current loss records the trade on redactOpaqueCredentialInputs — which surfaces it governs, what is lost, why withholding beat per-cell heuristics, and the shape a future relaxation must take deletes a duplicate sanitizeForExport in credential-extractor.ts corrects two route TSDocs that misdescribed what the code does, and moves the canonical sanitization doc onto the symbol those docs link to The tests guard in both directions Not just "redaction still works" — reverting the flag now fails loudly. Setting redactOpaqueCredentialInputs: false in json-sanitizer.ts produces exactly 4 failures: × redacts nested tool credentials from the public export payload × withholds table values, including whole {{ENV_VAR}} cells, on the way out × withholds every parameter of a tool with no authoritative codec metadata × re-imports the withheld sub-blocks as empty rather than dropping or corrupting them The first one is the point: it is executable proof that reverting the flag re-opens a secret leak. The other three pin the accepted cost, so anyone who decides the loss is unacceptable has to edit those expectations deliberately rather than delete the flag and ship. The deleted duplicate was a real footgun credential-extractor.ts exported its own sanitizeForExport that called sanitizeWorkflowForSharing with preserveEnvVars: true and not redactOpaqueCredentialInputs. It had zero production importers — every real caller uses the same-named but different function in @/lib/workflows/sanitization/json-sanitizer, which does pass the flag and returns a full envelope. Its only consumer was a test suite, which therefore described a configuration nothing runs. Two identically-named exports where one silently omits a redaction flag is exactly the shape of a future leak. The suite now passes the real option set explicitly, and import-export-roundtrip exercises the genuine sanitizeForExport, so the copy cannot drift unnoticed. Open question for the owner This PR does not resolve the underlying tension, because it is a product decision, not an engineering one: Is workflow export a faithful backup format, or a share-safe projection? Those two goals conflict here and the answer decides any future change. Today the export path tries to be both and lands as a share-safe projection that people reasonably expect to be a backup. If it is a backup, the fix is a per-sub-block opt-in that fails closed for tables added later — never a wider default. If it is a share-safe projection, the current loss is correct and the gap is discoverability: nothing in the product or the logs tells a user their tables came back empty; they find out by re-importing. Worth noting the first relaxation candidates are already visible in the new fixture — api.params (query params) and response-shaping header tables are not credential sinks. Recommended next action: discoverability, not relaxation Independent of how that question is answered, the concrete follow-up I'd recommend is telling the user what was withheld — surface a warning on export (and on import) that table sub-blocks and unauthoritative tool params came back empty and must be re-entered. That is the right next step because it is the only option with no security trade: it does not widen what is exported by a single byte, so it cannot re-open the leak #6591 closed, and it works whichever answer the product question gets. It converts a silent loss into an informed one. Today a user discovers the loss by re-importing a workflow and finding empty Headers — which is also why this reached a release unnoticed. Relaxing the redaction (a per-sub-block opt-in that fails closed) is the larger, riskier change and should wait on the product decision. Discoverability should not. Type of Change Chore / test + docs (no behavior change) Testing 35/35 passing across import-export-roundtrip, credential-extractor, and export-workflow. Bidirectional guard verified by flipping the flag and confirming 4 failures, then restoring. bun run type-check clean, biome clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary This PR intentionally changes no behavior. It pins an existing trade-off in place, documents it, and removes a footgun. No redaction logic is touched. #6591 turned on redactOpaqueCredential...

X Description: Summary This PR intentionally changes no behavior. It pins an existing trade-off in place, documents it, and removes a footgun. No redaction logic is touched. #6591 turned on redactOpaqueCredential...

Opengraph URL: https://github.com/simstudioai/sim/pull/6613

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ebee46f-2f1a-6995-df19-606325205f5c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC070:267719:B1748A:F3577C:6AFB525C
html-safe-nonce8fb9827aa556f840762c5f0091fc3d070442a36a81881845093546027b51361c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDcwOjI2NzcxOTpCMTc0OEE6RjM1NzdDOjZBRkI1MjVDIiwidmlzaXRvcl9pZCI6IjIzODU3NTkwNDIyODM0NTkxNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb27c858dae01eb8f8ffa91136e6e286a80972eb6519e6ca30c130cad24b0dd9a
hovercard-subject-tagpull_request:4260586254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6613/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary This PR intentionally changes no behavior. It pins an existing trade-off in place, documents it, and removes a footgun. No redaction logic is touched. #6591 turned on redactOpaqueCredential...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6613/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6613%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6613%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6613/files
Reloadhttps://github.com/simstudioai/sim/pull/6613/files
Reloadhttps://github.com/simstudioai/sim/pull/6613/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/b2-export-table-subblock-redactionhttps://github.com/simstudioai/sim/tree/fix/b2-export-table-subblock-redaction
Conversation 12 https://github.com/simstudioai/sim/pull/6613
Commits 2 https://github.com/simstudioai/sim/pull/6613/commits
Checks 30 https://github.com/simstudioai/sim/pull/6613/checks
Files changed https://github.com/simstudioai/sim/pull/6613/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6613/files
test(export): pin the table and tool-param loss the sanitized export accepts https://github.com/simstudioai/sim/pull/6613/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6613/files
cf84d38 test(export): pin the table and tool-param loss the sanitized export … waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6613/commits/cf84d38c621747d4675589b20295a4afe0907d36
b6a3b38 test(export): make the env-ref leak sweep load-bearing and drop test any waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6613/commits/b6a3b387768348a5e161d3fcab360cd01193a598
Clear filters https://github.com/simstudioai/sim/pull/6613/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6613/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6613/files
route.ts https://github.com/simstudioai/sim/pull/6613/files#diff-09f9d7673e722ba21db44dc7984798dfd956963846b08f802627cdca94ce010a
route.ts https://github.com/simstudioai/sim/pull/6613/files#diff-ef6d102ed6cac4bd921353d5c560fa3dc08d282c35065d69eed7be7575374ad7
credential-extractor.test.ts https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
credential-extractor.ts https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
export-workflow.ts https://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
import-export-roundtrip.test.ts https://github.com/simstudioai/sim/pull/6613/files#diff-d1e1d935e3afc109f626a04b84065103f5e30608080481da7fcdc6da186a7bee
apps/sim/app/api/v1/admin/folders/[id]/export/route.tshttps://github.com/simstudioai/sim/pull/6613/files#diff-09f9d7673e722ba21db44dc7984798dfd956963846b08f802627cdca94ce010a
View file https://github.com/simstudioai/sim/blob/b6a3b387768348a5e161d3fcab360cd01193a598/apps/sim/app/api/v1/admin/folders/%5Bid%5D/export/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6613/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6613/files#diff-09f9d7673e722ba21db44dc7984798dfd956963846b08f802627cdca94ce010a
apps/sim/app/api/v1/workflows/[id]/export/route.tshttps://github.com/simstudioai/sim/pull/6613/files#diff-ef6d102ed6cac4bd921353d5c560fa3dc08d282c35065d69eed7be7575374ad7
View file https://github.com/simstudioai/sim/blob/b6a3b387768348a5e161d3fcab360cd01193a598/apps/sim/app/api/v1/workflows/%5Bid%5D/export/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6613/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6613/files#diff-ef6d102ed6cac4bd921353d5c560fa3dc08d282c35065d69eed7be7575374ad7
https://github.com/simstudioai/sim/pull/6613/files#diff-ef6d102ed6cac4bd921353d5c560fa3dc08d282c35065d69eed7be7575374ad7
apps/sim/lib/workflows/credentials/credential-extractor.test.tshttps://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
View file https://github.com/simstudioai/sim/blob/b6a3b387768348a5e161d3fcab360cd01193a598/apps/sim/lib/workflows/credentials/credential-extractor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6613/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
https://github.com/simstudioai/sim/pull/6613/files#diff-b47ba6f8cdd1bf9bc64cdae6900d63610315a43e2935ad8398db40dbebe2054b
apps/sim/lib/workflows/credentials/credential-extractor.tshttps://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
View file https://github.com/simstudioai/sim/blob/b6a3b387768348a5e161d3fcab360cd01193a598/apps/sim/lib/workflows/credentials/credential-extractor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6613/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
https://github.com/simstudioai/sim/pull/6613/files#diff-ce8ad21d81263b3ee944d71166ca76ce34aa6222c69af9ace0c63f45c44b06c0
apps/sim/lib/workflows/operations/export-workflow.tshttps://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
View file https://github.com/simstudioai/sim/blob/b6a3b387768348a5e161d3fcab360cd01193a598/apps/sim/lib/workflows/operations/export-workflow.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6613/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
https://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
https://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
https://github.com/simstudioai/sim/pull/6613/files#diff-d593b7c042db5252c6b5b71c95281c46c87151775a4f9bab05d4df13b6cffbd0
Please reload this pagehttps://github.com/simstudioai/sim/pull/6613/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6613/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.