René's URL Explorer Experiment


Title: fix(uploads): make execution attachment completion replay-safe by waleedlatif1 · Pull Request #6601 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): make execution attachment completion replay-safe by waleedlatif1 · Pull Request #6601 · simstudioai/sim

X Title: fix(uploads): make execution attachment completion replay-safe by waleedlatif1 · Pull Request #6601 · simstudioai/sim

Description: Summary finalizeExecutionAttachment reported a completedFileId. That marker is what routes a replayed completion into loadCompletedUploadPurpose, which handled only workspace_file and threw a bare Error otherwise — unclassified, so the route rendered a generic 500. Its structurally identical twin finalizeMothershipAttachment correctly reports nothing. Both are metadata-backed and idempotent by storage key — exactly what the finalizeUploadPurpose TSDoc already states — so neither needs the marker. Dropped it from the execution finalizer so the twins agree. loadCompletedUploadPurpose is now an exhaustive switch, matching the sibling finalizeUploadPurpose switch, so adding a purpose is a compile error until its replay behavior is decided rather than a runtime 500. The residual arm throws a classified UploadSessionError('internal') instead of a bare Error. markUploadSessionCompleted no longer clears a marker it was not given. A finalizer that records one inside its own registration transaction (markUploadSessionFileRegistered does this for workspace_file) would otherwise have it overwritten with null — and both the abort guard and the expiry sweep key on it: cleanupExpiredUploadSessions only treats a finalizing session as disposable when completedFileId is null. No-op for every current path, since markUploadSessionCompleted moves the session to completed, which is neither abortable nor a cleanup candidate. Latent only. No shipped client replays a completion: the sole producer, uploadWorkflowAttachments, mints a fresh session per file and never retries; requestJson does not retry; a concurrent double-submit is already a clean 409 from claimSession. Nothing is mutated on the failing path. Not a parity regression — the whole upload-session plane is new on staging (uploadSession does not exist in main's schema). This is new code not meeting its own documented contract: the plane's README states that sessions in domain finalization are retained "for an idempotent completion retry". Type of Change Bug fix Testing bun run type-check clean. 2053 tests pass across app/api/files, lib/uploads, lib/knowledge, lib/table — the last three being the other completeUploadSession consumers. bun run lint and bun run check:api-validation pass. Tests pin the invariant rather than the symptom: a Record over the purpose union is a compile-time gate on which route each purpose replays through, and the cases assert that idempotent purposes report no marker and reject cleanly if they ever reach the loader. Verified they fail — restoring the marker turns the execution_attachment case red; dropping a purpose from the table fails the gate. Follow-ups (deliberately not in this PR) A DRY pass over the wider plane found real, pre-existing duplication that this change does not touch and should not be bundled with a latent-bug fix: service.ts: the lease-scoped WHERE predicate written 9×; the release-lease-on-failure catch 4× (two byte-identical); the terminal status-transition UPDATE 3×; deleteOwnedFinalObject is a strict prefix of discardIncompleteProviderState. provider.ts: the 3-way provider branch re-opened in 7 exported functions (21 copies of create

Config), with GCS as a silent fallthrough in 5 of them. application.ts: completeWorkspaceUploadSession writes the same reauthorize call 4× where its internal twin extracts one authorize closure. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary finalizeExecutionAttachment reported a completedFileId. That marker is what routes a replayed completion into loadCompletedUploadPurpose, which handled only workspace_file and threw a bare...

X Description: Summary finalizeExecutionAttachment reported a completedFileId. That marker is what routes a replayed completion into loadCompletedUploadPurpose, which handled only workspace_file and threw a bare...

Opengraph URL: https://github.com/simstudioai/sim/pull/6601

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cd4f0d4e-7439-064b-3958-665365b587d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA942:18E6DD:8A07EB:BE17B5:6AFB4976
html-safe-nonce48a0fc7a30e91a2f2fe857797ae61e4780ccf1eb3c627bb80bbf9540d911312c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTQyOjE4RTZERDo4QTA3RUI6QkUxN0I1OjZBRkI0OTc2IiwidmlzaXRvcl9pZCI6Ijc1MjUzNTQ0Mjg5NTg0NjAyNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb449890fd283c75827c846d1643609f97eb09299b350eaa8f9a022082bf0099e
hovercard-subject-tagpull_request:4259235912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6601/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary finalizeExecutionAttachment reported a completedFileId. That marker is what routes a replayed completion into loadCompletedUploadPurpose, which handled only workspace_file and threw a bare...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6601/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6601%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6601%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6601/files
Reloadhttps://github.com/simstudioai/sim/pull/6601/files
Reloadhttps://github.com/simstudioai/sim/pull/6601/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/upload-replay-contracthttps://github.com/simstudioai/sim/tree/fix/upload-replay-contract
Conversation 3 https://github.com/simstudioai/sim/pull/6601
Commits 1 https://github.com/simstudioai/sim/pull/6601/commits
Checks 30 https://github.com/simstudioai/sim/pull/6601/checks
Files changed https://github.com/simstudioai/sim/pull/6601/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6601/files
fix(uploads): make execution attachment completion replay-safe https://github.com/simstudioai/sim/pull/6601/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6601/files
cb57d0a fix(uploads): make execution attachment completion replay-safe waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6601/commits/cb57d0ab40649075ca1af7374fb6951f51f91ab3
Clear filters https://github.com/simstudioai/sim/pull/6601/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6601/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6601/files
finalizers.test.ts https://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
finalizers.ts https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
service.ts https://github.com/simstudioai/sim/pull/6601/files#diff-ed82a8eb24d09e7615785e2a03c26da0628cb0bf868f67fe248610c10f58cd22
apps/sim/app/api/files/uploads/finalizers.test.tshttps://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
View file https://github.com/simstudioai/sim/blob/cb57d0ab40649075ca1af7374fb6951f51f91ab3/apps/sim/app/api/files/uploads/finalizers.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6601/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
https://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
https://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
https://github.com/simstudioai/sim/pull/6601/files#diff-8d0aed213dcaf52aeafc46ed1ac026b1957309be38fbe3180489e4170db2b157
apps/sim/app/api/files/uploads/finalizers.tshttps://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
View file https://github.com/simstudioai/sim/blob/cb57d0ab40649075ca1af7374fb6951f51f91ab3/apps/sim/app/api/files/uploads/finalizers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6601/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
https://github.com/simstudioai/sim/pull/6601/files#diff-691cf61db300e4d65625f3e33041854adca7cc5cf5b08d84b5692c7a8ec1d3d5
apps/sim/lib/uploads/upload-session/service.tshttps://github.com/simstudioai/sim/pull/6601/files#diff-ed82a8eb24d09e7615785e2a03c26da0628cb0bf868f67fe248610c10f58cd22
View file https://github.com/simstudioai/sim/blob/cb57d0ab40649075ca1af7374fb6951f51f91ab3/apps/sim/lib/uploads/upload-session/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6601/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6601/files#diff-ed82a8eb24d09e7615785e2a03c26da0628cb0bf868f67fe248610c10f58cd22
https://github.com/simstudioai/sim/pull/6601/files#diff-ed82a8eb24d09e7615785e2a03c26da0628cb0bf868f67fe248610c10f58cd22
https://github.com/simstudioai/sim/pull/6601/files#diff-ed82a8eb24d09e7615785e2a03c26da0628cb0bf868f67fe248610c10f58cd22
Please reload this pagehttps://github.com/simstudioai/sim/pull/6601/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.