René's URL Explorer Experiment


Title: fix(mcp): audit the columns an MCP server update wrote, not the params it got by waleedlatif1 · Pull Request #6598 · simstudioai/sim · GitHub

Open Graph Title: fix(mcp): audit the columns an MCP server update wrote, not the params it got by waleedlatif1 · Pull Request #6598 · simstudioai/sim

X Title: fix(mcp): audit the columns an MCP server update wrote, not the params it got by waleedlatif1 · Pull Request #6598 · simstudioai/sim

Description: Summary Every PATCH /api/mcp/servers/[id] audit row listed oauthClientId, oauthClientIdProvided and oauthClientSecretProvided — including renames and URL edits that never touched credentials — and omitted the connectionStatus/lastConnected/lastError resets the write actually performed The route always sends oauthClientId: body.oauthClientId || null and *Provided: ... !== undefined, so null and false both survive the value !== undefined filter. All three appear on every PATCH regardless of what the client sends — no modal-side condition needed. The two *Provided flags aren't even columns; they're control params Regression from #5273 (263e3ca67e), which split performUpdateMcpServer into a writer that owns updateData and a thin audit wrapper with no access to it. main derived the list from Object.keys(updateData); the wrapper fell back to the params it could see Only the writer knows which columns a write touched, so updateMcpServer now returns updatedFields and both the internal wrapper and the v2 use case record it. Net −9 lines of derivation logic Audit fidelity only — .map(([key]) => key) records names, never values. No credential value was or is exposed Why this shape This is the pattern the repo already uses: workflow-mcp-lifecycle.ts:96,552,939 and credentials/orchestration/index.ts:159,339 both carry updatedFields?: string[] on the result and populate it from the writer's updateData. This makes server-lifecycle.ts the third instance rather than a new convention. The v2 twin shared the flaw in a different form (Object.keys(input) with no filter at all) and now reads the same result.updatedFields. Intentional change to audit output Rows now include connectionStatus/lastConnected/lastError on an auth or credential change, include authType when it is implicitly promoted to oauth, and stop including oauthClientIdProvided/oauthClientSecretProvided. I grepped for downstream consumers keyed on the old strings (EE audit-log UI, v1 export, dashboards) and found none. Type of Change Bug fix Testing Two new tests in server-lifecycle.test.ts: one asserting a rename records exactly ['name'], one asserting an auth-type flip records the reset columns Verified they can fail: against the old params-derived logic they go red with expected [ 'name', 'oauthClientId', …(2) ] to deeply equal [ 'name' ] and expected [ 'authType' ] to deeply equal ArrayContaining{…} 875 tests pass across lib/mcp, app/api/mcp, app/api/v2/mcp, lib/credentials check:openapi unchanged and check:api-validation:strict pass — confirms no updatedFields key leaks into a wire response (no caller spreads the result; the v2 projection re-wraps picked fields) Follow-ups (not in this PR) performCreateMcpServer's upsert branch rewrites an existing server (name, URL, headers, OAuth creds, auth-type flip, same connection reset) but gates its audit on if (!result.updated), so an upsert-rewrite emits no MCP_SERVER_UPDATED row at all. That's a behavior change, and it needs updateValues tightened from Record to Partial first to be column-safe Object.keys(updateData).filter(k => k !== 'updatedAt') now appears in 6 places across 4 files (5 predate this PR). Worth one shared helper so the exclusion set is a single edit, but that spans lib/credentials and a v1 admin route — its own PR Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every PATCH /api/mcp/servers/[id] audit row listed oauthClientId, oauthClientIdProvided and oauthClientSecretProvided — including renames and URL edits that never touched credentials — and...

X Description: Summary Every PATCH /api/mcp/servers/[id] audit row listed oauthClientId, oauthClientIdProvided and oauthClientSecretProvided — including renames and URL edits that never touched credentials — and...

Opengraph URL: https://github.com/simstudioai/sim/pull/6598

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee440447-667f-3475-d7de-601fa6d6c5ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC7C:600EE:19B76:25678:6AFB4335
html-safe-noncec24da0fcf0240ca113438d55f80080fa1913e80999a94b266ef96d64769b1e8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzdDOjYwMEVFOjE5Qjc2OjI1Njc4OjZBRkI0MzM1IiwidmlzaXRvcl9pZCI6IjMyMzE3NDE3Mzk4NzM4MTMzMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae7c2977958d7663b295f97e4f5b24d93b4404761b2541755afef212fa47d4c2
hovercard-subject-tagpull_request:4259164097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6598/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every PATCH /api/mcp/servers/[id] audit row listed oauthClientId, oauthClientIdProvided and oauthClientSecretProvided — including renames and URL edits that never touched credentials — and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6598/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6598%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6598%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6598/files
Reloadhttps://github.com/simstudioai/sim/pull/6598/files
Reloadhttps://github.com/simstudioai/sim/pull/6598/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mcp-audit-updated-fieldshttps://github.com/simstudioai/sim/tree/fix/mcp-audit-updated-fields
Conversation 3 https://github.com/simstudioai/sim/pull/6598
Commits 1 https://github.com/simstudioai/sim/pull/6598/commits
Checks 30 https://github.com/simstudioai/sim/pull/6598/checks
Files changed https://github.com/simstudioai/sim/pull/6598/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6598/files
fix(mcp): audit the columns an MCP server update wrote, not the params it got https://github.com/simstudioai/sim/pull/6598/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6598/files
3bf7a0d fix(mcp): audit the columns an MCP server update wrote, not the param… waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6598/commits/3bf7a0d7ee6bee6be864b8f6c9e75c900d9b9d0e
Clear filters https://github.com/simstudioai/sim/pull/6598/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6598/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6598/files
use-cases.ts https://github.com/simstudioai/sim/pull/6598/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
server-lifecycle.test.ts https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
server-lifecycle.ts https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
apps/sim/lib/mcp/application/use-cases.tshttps://github.com/simstudioai/sim/pull/6598/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
View file https://github.com/simstudioai/sim/blob/3bf7a0d7ee6bee6be864b8f6c9e75c900d9b9d0e/apps/sim/lib/mcp/application/use-cases.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6598/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6598/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
https://github.com/simstudioai/sim/pull/6598/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
apps/sim/lib/mcp/orchestration/server-lifecycle.test.tshttps://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
View file https://github.com/simstudioai/sim/blob/3bf7a0d7ee6bee6be864b8f6c9e75c900d9b9d0e/apps/sim/lib/mcp/orchestration/server-lifecycle.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6598/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
https://github.com/simstudioai/sim/pull/6598/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
apps/sim/lib/mcp/orchestration/server-lifecycle.tshttps://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
View file https://github.com/simstudioai/sim/blob/3bf7a0d7ee6bee6be864b8f6c9e75c900d9b9d0e/apps/sim/lib/mcp/orchestration/server-lifecycle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6598/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
https://github.com/simstudioai/sim/pull/6598/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
Please reload this pagehttps://github.com/simstudioai/sim/pull/6598/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.