René's URL Explorer Experiment


Title: fix(tools): bind schema-enrichment reads to executor delegations by waleedlatif1 · Pull Request #6593 · simstudioai/sim · GitHub

Open Graph Title: fix(tools): bind schema-enrichment reads to executor delegations by waleedlatif1 · Pull Request #6593 · simstudioai/sim

X Title: fix(tools): bind schema-enrichment reads to executor delegations by waleedlatif1 · Pull Request #6593 · simstudioai/sim

Description: Summary tools/params.ts still called the deprecated buildAuthHeaders() (no subject) to read a child workflow, so /api/workflows/[id] — now on internalWorkflowReadAuth — rejected the legacy type: 'internal' token with a 401. The Agent block's workflow_executor inputMapping was left as an untyped { type: 'object' }, so the model guessed the child's field names and lazyCleanupInputMapping silently dropped the wrong keys. tools/schema-enrichers.ts had the same break against /api/knowledge/[id]/tag-definitions. Worse blast radius: when an enricher returns null the parameter is dropped from the schema entirely, so knowledge_search / create_document / upsert_document lost tag filtering altogether. Both now use buildExecutorDelegationHeaders, bound to the acting execution subject. Extracted the executionId binding rule into executor/utils/delegation.ts — it was hand-rolled in three places. A child workflow binds on its own id, so forwarding the parent's executionId would assert a run that doesn't cover it. Regression from #5273, which migrated the routes and the sibling call sites but missed these two. git diff origin/main -- apps/sim/tools/params.ts was empty. Audited every remaining buildAuthHeaders caller — the rest target routes still on legacy auth, so no other mismatch remains. Type of Change Bug fix Testing New tests assert the delegation binding and the resulting properties/required schema. Verified they fail against the pre-fix code (2 failures in params.test.ts, 3 in schema-enrichers.test.ts) — the existing inputMapping always included test sat on this path but asserted only type === 'object', which holds in the broken state, so it could not fail. bunx vitest run tools/ providers/ executor/ — 5,981 passing. Repo-wide lint:check and type-check (23/23 each), plus check:api-validation, monorepo-boundary and realtime-prune gates. Not exercised against a live workspace: this path only runs server-side during a real agent run with a child workflow. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary tools/params.ts still called the deprecated buildAuthHeaders() (no subject) to read a child workflow, so /api/workflows/[id] — now on internalWorkflowReadAuth — rejected the legacy type: &...

X Description: Summary tools/params.ts still called the deprecated buildAuthHeaders() (no subject) to read a child workflow, so /api/workflows/[id] — now on internalWorkflowReadAuth — rejected the legacy type: &...

Opengraph URL: https://github.com/simstudioai/sim/pull/6593

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4fdda4c7-47b4-f659-040d-5021521cc192
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3A8:3EFFC5:5B10E3:81AA30:6AFB42F6
html-safe-nonce23a5ff09b4d151954c8cd8412c6c5f8c3fdb353e6e92b1445759ad6af05acc4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0E4OjNFRkZDNTo1QjEwRTM6ODFBQTMwOjZBRkI0MkY2IiwidmlzaXRvcl9pZCI6IjU1MTk1NjI3NzQyNTU3MTUwNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac54858c625e75f23124dbfd302ce50d6297a8b8e943dd91122a0cd3eee10d2135
hovercard-subject-tagpull_request:4259086368
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6593/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary tools/params.ts still called the deprecated buildAuthHeaders() (no subject) to read a child workflow, so /api/workflows/[id] — now on internalWorkflowReadAuth — rejected the legacy type: &...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6593/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6593%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6593%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6593/files
Reloadhttps://github.com/simstudioai/sim/pull/6593/files
Reloadhttps://github.com/simstudioai/sim/pull/6593/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
investigate/delegation-headershttps://github.com/simstudioai/sim/tree/investigate/delegation-headers
Conversation 7 https://github.com/simstudioai/sim/pull/6593
Commits 2 https://github.com/simstudioai/sim/pull/6593/commits
Checks 30 https://github.com/simstudioai/sim/pull/6593/checks
Files changed https://github.com/simstudioai/sim/pull/6593/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6593/files
fix(tools): bind schema-enrichment reads to executor delegations https://github.com/simstudioai/sim/pull/6593/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6593/files
4ebefe9 fix(tools): bind schema-enrichment reads to executor delegations waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6593/commits/4ebefe99d4dd3fac7b453f9e3b402d20b1226eab
a939738 improvement(tools): surface tag-definition read failures at error level waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6593/commits/a939738cae5323fab00c49a7de1bbd2405000243
Clear filters https://github.com/simstudioai/sim/pull/6593/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6593/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6593/files
delegation.test.ts https://github.com/simstudioai/sim/pull/6593/files#diff-5020f65f9b03c5d9c0e8fd3e84155f17bed3f81aa1144bab80602c73b44b7b29
delegation.ts https://github.com/simstudioai/sim/pull/6593/files#diff-14d5591c967325443c85673c0c3a0dcb320ab6ddc49075f8bade628285b4c428
utils.ts https://github.com/simstudioai/sim/pull/6593/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
params.test.ts https://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
params.ts https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
schema-enrichers.test.ts https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
schema-enrichers.ts https://github.com/simstudioai/sim/pull/6593/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
apps/sim/executor/utils/delegation.test.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-5020f65f9b03c5d9c0e8fd3e84155f17bed3f81aa1144bab80602c73b44b7b29
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/executor/utils/delegation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
apps/sim/executor/utils/delegation.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-14d5591c967325443c85673c0c3a0dcb320ab6ddc49075f8bade628285b4c428
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/executor/utils/delegation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
apps/sim/providers/utils.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/providers/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6593/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
https://github.com/simstudioai/sim/pull/6593/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
apps/sim/tools/params.test.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/tools/params.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
https://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
https://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
https://github.com/simstudioai/sim/pull/6593/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
apps/sim/tools/params.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/tools/params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6593/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
apps/sim/tools/schema-enrichers.test.tshttps://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
View file https://github.com/simstudioai/sim/blob/a939738cae5323fab00c49a7de1bbd2405000243/apps/sim/tools/schema-enrichers.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6593/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6593/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
Please reload this pagehttps://github.com/simstudioai/sim/pull/6593/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6593/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.