Title: fix(forks): detect secrets referenced from advanced-mode fields by icecrasher321 · Pull Request #6566 · simstudioai/sim · GitHub
Open Graph Title: fix(forks): detect secrets referenced from advanced-mode fields by icecrasher321 · Pull Request #6566 · simstudioai/sim
X Title: fix(forks): detect secrets referenced from advanced-mode fields by icecrasher321 · Pull Request #6566 · simstudioai/sim
Description: Summary {{ENV}} detection in the fork reference scan shared one gate with resource-id detection, so a secret referenced from an ACTIVE advanced (manual) canonical member — e.g. a {{SLACK_CHANNEL}} typed into Slack's advanced "Channel ID" — was never recorded as a reference. Three consequences, all silent: No row in the Secrets section of the fork edit-mapping modal, so the key could not be mapped across workspaces at all. promote-plan builds unmappedRequired from the same scan, so the required-env sync gate never fired for it. A push to a target missing that secret therefore succeeded, writing a {{KEY}} that resolves to nothing at runtime. The identical reference in a basic-mode field would have hard-blocked the same push. Detection now gates on EXECUTION rather than ownership. A dormant member and a condition-hidden field still go undetected — they never run, so they must not become sync blockers — but an active manual member is exactly the value that does run, and its key is a live secret reference like any other. Resource-id detection keeps the verbatimManual policy unchanged, so a hand-typed credential/KB id stays a user-owned escape hatch. This also reconciles the two halves of the pass: remapEnvInValue already rewrote a manual member's ref unconditionally while detection suppressed it. Pins the fix with cases for explicit canonicalModes and the value heuristic, rewrite/detect agreement on a mapped key, both still-undetected paths, and the resource-id escape hatch surviving alongside env detection. Type of Change Bug fix Testing Tested manually Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary {{ENV}} detection in the fork reference scan shared one gate with resource-id detection, so a secret referenced from an ACTIVE advanced (manual) canonical member — e.g. a {{SLACK_CHANNEL}} ...
X Description: Summary {{ENV}} detection in the fork reference scan shared one gate with resource-id detection, so a secret referenced from an ACTIVE advanced (manual) canonical member — e.g. a {{SLACK_CHANNEL}} ...
Opengraph URL: https://github.com/simstudioai/sim/pull/6566
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fbaed127-8bde-0f28-b186-3310ab0f1cc1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D96:1ACA1F:7348C8:A40D7D:6AFB497D |
| html-safe-nonce | 789ac9c6a731ce13076514c8154d9144a6bfdfde8abfeefec632439f97293100 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDk2OjFBQ0ExRjo3MzQ4Qzg6QTQwRDdEOjZBRkI0OTdEIiwidmlzaXRvcl9pZCI6IjM4MDAxNTI2NDExMzI3NzU4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 94247c534777d718306c712a0f7b8e3ace73b0bf3cd135055acbd8b6be7057c7 |
| hovercard-subject-tag | pull_request:4257630410 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6566/files |
| twitter:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| og:image:alt | Summary {{ENV}} detection in the fork reference scan shared one gate with resource-id detection, so a secret referenced from an ACTIVE advanced (manual) canonical member — e.g. a {{SLACK_CHANNEL}} ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width