René's URL Explorer Experiment


Title: fix(uploads): restore archive extraction folder parity by waleedlatif1 · Pull Request #6565 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): restore archive extraction folder parity by waleedlatif1 · Pull Request #6565 · simstudioai/sim

X Title: fix(uploads): restore archive extraction folder parity by waleedlatif1 · Pull Request #6565 · simstudioai/sim

Description: Stacked on #6560 (improvement/v2-route-standardization). Review only this PR's own commits; merge after its parent. Archive extraction regressed against main in three compounding ways. Every archive containing a subdirectory failed, and 100% of Copilot archive extractions failed, because materialize-file.ts always passes rootFolderSegments and its catch only matches ArchiveError. The three defects Non-canonical folder path. archive.ts built folderSegments.join('/') — no leading slash, no per-segment encoding — and handed it to an operation that routes to parseFolderPath, which throws FolderPathError on any path not starting with /. It also fails the encodeFolderPathSegment round-trip, so a folder name containing a space threw even after prefixing /. exactName: true rolled back whole extractions. A single colliding leaf name threw FileConflictError, and the catch deleted every already-extracted file. main auto-suffixed via allocateUniqueWorkspaceFileName and succeeded. Independently reachable today for a flat archive via POST /api/tools/file/manage. Wrong folder primitive. createWorkspaceFileFolderAtPath creates exactly one leaf, rejects an existing path, and requires the parent to exist. The extractor never created intermediates, so the first nested entry asked for a folder whose parent did not exist. Fix Adds ensureWorkspaceFileFolderPathOperation on the same semantic operation (fileOperations.createFolder, identical minimumRole: 'write' / workspaceApiKey: 'allow' policy), restoring main's reuse-on-conflict, create-intermediates semantics without bypassing the application-operation boundary. exactName returns to false. Deliberately not a one-line / prefix: with only that fix applied, 4 tests still fail (Parent folder not found, A folder named "bundle" already exists), proving defect 3 is independent. Tests archive.test.ts previously mocked the folder operation and asserted the broken shape — which is why this shipped. The mock now enforces the real rules via the production requireNonRootFolderPath/buildFolderPath. Reverting the fix turns 6 tests red; each defect was also isolated separately. Known gap (deliberate) The new operation has no projectAudit/afterSuccess notify, matching main (which called ensureWorkspaceFileFolderPath directly). An archive of only empty directories therefore creates folders with no audit row or UI refresh. Flagged for a follow-up decision rather than changed here. type-check · biome · 937 tests (lib/uploads, lib/workspace-files, copilot handlers) · check:api-validation — all pass.

Open Graph Description: Stacked on #6560 (improvement/v2-route-standardization). Review only this PR's own commits; merge after its parent. Archive extraction regressed against main in three compounding ways. Every ar...

X Description: Stacked on #6560 (improvement/v2-route-standardization). Review only this PR's own commits; merge after its parent. Archive extraction regressed against main in three compounding ways. Ever...

Opengraph URL: https://github.com/simstudioai/sim/pull/6565

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19f5a76b-bb4e-1369-0d8c-6dbb17ed0566
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8246:2E7BAB:7D8EC8:AD3819:6AFB47AC
html-safe-noncee184131c0dab522cc160e96d35d53c85ce8e975afc34e599002100024dd52f04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjQ2OjJFN0JBQjo3RDhFQzg6QUQzODE5OjZBRkI0N0FDIiwidmlzaXRvcl9pZCI6Ijc3ODI0Nzc3MzU2Njk3NDU1ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac208c421c54e2dde2fd6bb868d71e3306a3cf1c9b6c12a0a23f991358381c08f9
hovercard-subject-tagpull_request:4257627974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6565/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altStacked on #6560 (improvement/v2-route-standardization). Review only this PR's own commits; merge after its parent. Archive extraction regressed against main in three compounding ways. Every ar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6565/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6565%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6565%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6565/files
Reloadhttps://github.com/simstudioai/sim/pull/6565/files
Reloadhttps://github.com/simstudioai/sim/pull/6565/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
improvement/v2-route-standardizationhttps://github.com/simstudioai/sim/tree/improvement/v2-route-standardization
fix/archive-extraction-folder-pathhttps://github.com/simstudioai/sim/tree/fix/archive-extraction-folder-path
Conversation 9 https://github.com/simstudioai/sim/pull/6565
Commits 3 https://github.com/simstudioai/sim/pull/6565/commits
Checks 5 https://github.com/simstudioai/sim/pull/6565/checks
Files changed https://github.com/simstudioai/sim/pull/6565/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6565/files
fix(uploads): restore archive extraction folder parity https://github.com/simstudioai/sim/pull/6565/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6565/files
94fa43b fix(uploads): restore archive extraction folder parity waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6565/commits/94fa43b3a7e329674b389b57875a85fc597f47e8
0077285 chore(files): tidy archive extraction cleanup waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6565/commits/0077285e18282ba091eabe7723a5a3a277ec4433
427b260 fix(uploads): roll back folders archive extraction created waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6565/commits/427b26063a4b5230d2adb0d996e6241554d9b68b
Clear filters https://github.com/simstudioai/sim/pull/6565/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6565/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6565/files
vfs-mutate.test.ts https://github.com/simstudioai/sim/pull/6565/files#diff-bb881bf02cfb2e87bc6b41813475d98e6f42a018124510f0ef1acc887e9b152b
resource-writer.test.ts https://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
archive.test.ts https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
archive.ts https://github.com/simstudioai/sim/pull/6565/files#diff-d778a8957ed2ba84f2626a60b2702dfc06f7901156f44a3d6b46f128f3c88bd5
workspace-file-folder-manager.ts https://github.com/simstudioai/sim/pull/6565/files#diff-7ab6712e7e7b3b214000c022f68393bf7da60abb4ec2a557d5fa912f10c245cc
workspace-file-folders.ts https://github.com/simstudioai/sim/pull/6565/files#diff-94f722d12677d09f7a29274dae68cf644c6bb1a53e59f4f0f02e625c62865945
write-workspace-file-by-path.ts https://github.com/simstudioai/sim/pull/6565/files#diff-eac74cec226c312ccef8e749c1a11c02893d3a78d6d346e84cdc785426630fb9
apps/sim/lib/copilot/tools/handlers/vfs-mutate.test.tshttps://github.com/simstudioai/sim/pull/6565/files#diff-bb881bf02cfb2e87bc6b41813475d98e6f42a018124510f0ef1acc887e9b152b
View file https://github.com/simstudioai/sim/blob/427b26063a4b5230d2adb0d996e6241554d9b68b/apps/sim/lib/copilot/tools/handlers/vfs-mutate.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6565/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6565/files#diff-bb881bf02cfb2e87bc6b41813475d98e6f42a018124510f0ef1acc887e9b152b
https://github.com/simstudioai/sim/pull/6565/files#diff-bb881bf02cfb2e87bc6b41813475d98e6f42a018124510f0ef1acc887e9b152b
apps/sim/lib/copilot/vfs/resource-writer.test.tshttps://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
View file https://github.com/simstudioai/sim/blob/427b26063a4b5230d2adb0d996e6241554d9b68b/apps/sim/lib/copilot/vfs/resource-writer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6565/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
https://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
https://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
https://github.com/simstudioai/sim/pull/6565/files#diff-345bc0d02204a0c219ea689e7c0df38d9baac33563037472dac0e36dbe2d8f32
apps/sim/lib/uploads/archive.test.tshttps://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
View file https://github.com/simstudioai/sim/blob/427b26063a4b5230d2adb0d996e6241554d9b68b/apps/sim/lib/uploads/archive.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6565/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
https://github.com/simstudioai/sim/pull/6565/files#diff-0b64b14ad44f5688f400b8425bac8f59eafbeb416d71f8cf74d3bc11b1da1e5d
Please reload this pagehttps://github.com/simstudioai/sim/pull/6565/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6565/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.