René's URL Explorer Experiment


Title: improvement(provenance): make the incompleteness reason set closed and complete by icecrasher321 · Pull Request #6559 · simstudioai/sim · GitHub

Open Graph Title: improvement(provenance): make the incompleteness reason set closed and complete by icecrasher321 · Pull Request #6559 · simstudioai/sim

X Title: improvement(provenance): make the incompleteness reason set closed and complete by icecrasher321 · Pull Request #6559 · simstudioai/sim

Description: Summary Remove workspace-scope-missing — it has no producer. The !context.workspaceId guard that emitted it disappeared when the copilot table tool's importRowsForModel was rewritten, and every operation now returns early on a missing workspace before provenance import is reachable. Its warn-classification test case constructed the reason itself, so it was asserting on something nothing emits. Give ResolvedSecretTraceProvenanceAccumulator the required reason the registry already has. Its three guards latched anonymously, which matters more here than on the registry: the wire format carries only complete, so the consumer can only ever say source-provenance-incomplete and the guard is unrecoverable. Names the three — file-source-unidentified, workspace-file-provenance-unknown, mcp-tool-execution-timeout. A latch from record() stays silent, since it reflects a bundle whose own registry already reported and subflow aggregation runs it per iteration. Fold the error/warn/by-design split into one reportIncompleteness. It was copied across both registry latches and would have been copied a third time for the accumulator; a copy that can be updated alone lets the same reason be a fault in one place and routine in another. Give the async workflow tool path its own import origin (copilotToolClient.workflowExecution) instead of latching with none, matching the sibling sealed-context path. Close UnrecordedDurableProvenanceCause, which was a free-form string carrying a TSDoc claim that it was always a static literal. Also fixes a latent miss from #6513: the sweep passed a reason to the accumulator's zero-arg markIncomplete, but nothing caught it — test files are excluded from tsc, and the extra argument was ignored at runtime. That call is now real. unspecified stays, with corrected docs. It has no production callsite by design, but tests use it as an honest "latched, no guard to name" lever; making them borrow a real reason would read as a claim about which guard tripped. Type of Change Improvement (cleanup, no behavior change) Testing Verified every reason in the union now has at least one producer. bun run type-check clean, bun run lint clean, bun run check:audits — all 24 audits pass (including check:api-validation:strict). 3,140 tests green across the registry, durable-provenance, knowledge, providers, copilot-tools, logs, MCP, and file-manage suites. Two new tests pin the accumulator's naming and its silence on a recorded latch. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Remove workspace-scope-missing — it has no producer. The !context.workspaceId guard that emitted it disappeared when the copilot table tool's importRowsForModel was rewritten, and ever...

X Description: Summary Remove workspace-scope-missing — it has no producer. The !context.workspaceId guard that emitted it disappeared when the copilot table tool's importRowsForModel was rewritten, and ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6559

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e609699c-bd69-8531-f724-831b8d60a703
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC6A:2D6147:64F9D5:902256:6AFB45EE
html-safe-noncea607fb5c1ada377e8c358a053bdae0d83a2520feeebd6c81105b57e9f5ebe227
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzZBOjJENjE0Nzo2NEY5RDU6OTAyMjU2OjZBRkI0NUVFIiwidmlzaXRvcl9pZCI6Ijc1MjI1NzgwNDYxMzQyMDc5ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac224c7d2c7aa6513ac2fb2747aac82d19171ff99fb690d3405e158b7ba668980b
hovercard-subject-tagpull_request:4256759823
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6559/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Remove workspace-scope-missing — it has no producer. The !context.workspaceId guard that emitted it disappeared when the copilot table tool's importRowsForModel was rewritten, and ever...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6559/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6559%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6559%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6559/files
Reloadhttps://github.com/simstudioai/sim/pull/6559/files
Reloadhttps://github.com/simstudioai/sim/pull/6559/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
provenance-reason-taxonomyhttps://github.com/simstudioai/sim/tree/provenance-reason-taxonomy
Conversation 3 https://github.com/simstudioai/sim/pull/6559
Commits 1 https://github.com/simstudioai/sim/pull/6559/commits
Checks 30 https://github.com/simstudioai/sim/pull/6559/checks
Files changed https://github.com/simstudioai/sim/pull/6559/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6559/files
improvement(provenance): make the incompleteness reason set closed and complete https://github.com/simstudioai/sim/pull/6559/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6559/files
ef686fa improvement(provenance): make the incompleteness reason set closed an… Aug 11, 2026 https://github.com/simstudioai/sim/pull/6559/commits/ef686fac48dde0b57f7401f9707f539c455fb96a
Clear filters https://github.com/simstudioai/sim/pull/6559/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6559/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6559/files
route.ts https://github.com/simstudioai/sim/pull/6559/files#diff-22fc33985565086f7740511d7efcc737f09ffc77af677b11b338bc59b1010a39
route.ts https://github.com/simstudioai/sim/pull/6559/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
resolved-secret-trace-registry.test.ts https://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
resolved-secret-trace-registry.ts https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
client.ts https://github.com/simstudioai/sim/pull/6559/files#diff-a38fa8f174ad309f5e11c0475f57c049257e611602f5b21dc352ffe56aa73666
durable-secret-provenance-enforcement.ts https://github.com/simstudioai/sim/pull/6559/files#diff-a9cbbb33d846c424c713d03a975eff6b131648cc60052d78fcc3b2b16e8d0000
apps/sim/app/api/mcp/tools/execute/route.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-22fc33985565086f7740511d7efcc737f09ffc77af677b11b338bc59b1010a39
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/app/api/mcp/tools/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-22fc33985565086f7740511d7efcc737f09ffc77af677b11b338bc59b1010a39
https://github.com/simstudioai/sim/pull/6559/files#diff-22fc33985565086f7740511d7efcc737f09ffc77af677b11b338bc59b1010a39
apps/sim/app/api/tools/file/manage/route.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/app/api/tools/file/manage/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
https://github.com/simstudioai/sim/pull/6559/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
apps/sim/executor/utils/resolved-secret-trace-registry.test.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/executor/utils/resolved-secret-trace-registry.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6559/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
apps/sim/executor/utils/resolved-secret-trace-registry.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/executor/utils/resolved-secret-trace-registry.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/6559/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
apps/sim/lib/copilot/request/tools/client.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-a38fa8f174ad309f5e11c0475f57c049257e611602f5b21dc352ffe56aa73666
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/lib/copilot/request/tools/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-a38fa8f174ad309f5e11c0475f57c049257e611602f5b21dc352ffe56aa73666
https://github.com/simstudioai/sim/pull/6559/files#diff-a38fa8f174ad309f5e11c0475f57c049257e611602f5b21dc352ffe56aa73666
https://github.com/simstudioai/sim/pull/6559/files#diff-a38fa8f174ad309f5e11c0475f57c049257e611602f5b21dc352ffe56aa73666
apps/sim/lib/execution/durable-secret-provenance-enforcement.tshttps://github.com/simstudioai/sim/pull/6559/files#diff-a9cbbb33d846c424c713d03a975eff6b131648cc60052d78fcc3b2b16e8d0000
View file https://github.com/simstudioai/sim/blob/ef686fac48dde0b57f7401f9707f539c455fb96a/apps/sim/lib/execution/durable-secret-provenance-enforcement.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6559/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6559/files#diff-a9cbbb33d846c424c713d03a975eff6b131648cc60052d78fcc3b2b16e8d0000
https://github.com/simstudioai/sim/pull/6559/files#diff-a9cbbb33d846c424c713d03a975eff6b131648cc60052d78fcc3b2b16e8d0000
Please reload this pagehttps://github.com/simstudioai/sim/pull/6559/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.