Title: improvement(audits): skip the sql-date-binding parse for files without drizzle-orm by waleedlatif1 · Pull Request #6554 · simstudioai/sim · GitHub
Open Graph Title: improvement(audits): skip the sql-date-binding parse for files without drizzle-orm by waleedlatif1 · Pull Request #6554 · simstudioai/sim
X Title: improvement(audits): skip the sql-date-binding parse for files without drizzle-orm by waleedlatif1 · Pull Request #6554 · simstudioai/sim
Description: Summary check:sql-date-binding Babel-parsed all 13,941 source files under apps, packages, and scripts. A violation can only come from an sql tag resolved through a drizzle-orm import, and both the static (collectSqlBindings) and dynamic (isDrizzleImportCall) resolvers match the specifier as a string literal — so a file that never names the module cannot bind the tag and cannot violate. Only ~590 of those files name it. Skip the parse for the other 92% of bytes. Audit goes ~4.5s → ~0.8s (5.7x), dropping out of the four slowest audits. check:audits goes 6.0s → 5.3s wall, 38.0s → 32.9s serial. Output is unchanged. Type of Change Improvement (performance) Testing Tested manually: Clean tree before/after both report ✓ 13941 files bind every sql-template Date through a column encoder, warm timings 4.38s/4.63s → 0.82s/0.76s. Planted a real violation (sql\... ${aDate}`in a file importingsqlfromdrizzle-orm`) and confirmed it is still reported with exit 1. bun run check:audits and bunx biome check pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary check:sql-date-binding Babel-parsed all 13,941 source files under apps, packages, and scripts. A violation can only come from an sql tag resolved through a drizzle-orm import, and both the...
X Description: Summary check:sql-date-binding Babel-parsed all 13,941 source files under apps, packages, and scripts. A violation can only come from an sql tag resolved through a drizzle-orm import, and both the...
Opengraph URL: https://github.com/simstudioai/sim/pull/6554
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:22f61990-d9c1-153f-d2a1-95517c30d4af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA5A:600EE:B76F:10AA8:6AFB42F1 |
| html-safe-nonce | 026ba8e8622456922e815f55876032de7e40be65545dbc774ce6c34d6aab7519 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTVBOjYwMEVFOkI3NkY6MTBBQTg6NkFGQjQyRjEiLCJ2aXNpdG9yX2lkIjoiOTEwODc3ODM3MjcwNzMzNjk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f01ec3af9722d9bf23328d77cd5c31a4ae2e36be8163e7b69af17620adfd9dcc |
| hovercard-subject-tag | pull_request:4256157791 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6554/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary check:sql-date-binding Babel-parsed all 13,941 source files under apps, packages, and scripts. A violation can only come from an sql tag resolved through a drizzle-orm import, and both the... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width