René's URL Explorer Experiment


Title: fix(media): bound the copilot ffmpeg tool's inputs, runtime, and output paths by waleedlatif1 · Pull Request #6544 · simstudioai/sim · GitHub

Open Graph Title: fix(media): bound the copilot ffmpeg tool's inputs, runtime, and output paths by waleedlatif1 · Pull Request #6544 · simstudioai/sim

X Title: fix(media): bound the copilot ffmpeg tool's inputs, runtime, and output paths by waleedlatif1 · Pull Request #6544 · simstudioai/sim

Description: Summary Bound the copilot ffmpeg tool, which runs FFmpeg in-process on the app server. Caps inputs at 10 per operation, rejected before any file is downloaded Give each operation one wall-clock budget (5 min) shared across every process it spawns, and SIGKILL on expiry — concat runs an encode per clip, so a per-command timeout would still multiply out Wire the tool's cancellation signal through to that kill, so a stopped turn stops the transcode instead of leaving it running Validate scale_pad dimensions (16–4096) before they reach the filter graph, and clamp the dimensions concat derives from the first clip's container metadata Restrict convert/extract_audio output formats to an explicit allowlist. The format previously reached a temp-file name unsanitized, so it could resolve outside the working directory Resolve every temp path through a helper that verifies containment, making that invariant structural rather than dependent on sanitizing each filename source Spawn ffprobe directly instead of via fluent-ffmpeg, which exposes no handle on the child and so could not be killed at all Type of Change Bug fix Testing Unit tests for every bound (input cap, format allowlist, scale bounds, trim ordering, abort). Hermetic — verified passing with no ffmpeg on PATH, as in CI Verified out-of-band against real ffmpeg that probe metadata, convert, scale_pad, budget expiry, and external abort all behave correctly, since the change touches every execution path Confirmed each new guard fails its test when reverted bun run type-check, bun run lint, and bun run check:api-validation all pass; 328 copilot server-tool tests pass Notes lib/audio/extractor.ts has the same unbounded-runtime shape and is reachable from the STT route. Left out of scope, worth a follow-up The generated tool schema still advertises these params as unbounded; the limits originate in the sibling copilot repo's catalog, so surfacing them there would stop the model retrying rejected calls There is no rate limit or concurrency cap on copilot tool calls, so per-call bounds do not bound call volume Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Bound the copilot ffmpeg tool, which runs FFmpeg in-process on the app server. Caps inputs at 10 per operation, rejected before any file is downloaded Give each operation one wall-clock bu...

X Description: Summary Bound the copilot ffmpeg tool, which runs FFmpeg in-process on the app server. Caps inputs at 10 per operation, rejected before any file is downloaded Give each operation one wall-clock bu...

Opengraph URL: https://github.com/simstudioai/sim/pull/6544

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c3ffa6e-a0cb-e82a-52bf-892b1355cb9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBE8:1BC3DC:802A50:B54E74:6AFB4D9C
html-safe-nonce57f397d31ff41a7850adbc5cbb313b9bd553928e84a87961972f4e0a279c0dc3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkU4OjFCQzNEQzo4MDJBNTA6QjU0RTc0OjZBRkI0RDlDIiwidmlzaXRvcl9pZCI6Ijc1MjIzODgyMDg1Nzk3MjY3NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac618466a43e83d4b05fc003ddc84c5e135e6e0827df46296ebee4899ecf695d47
hovercard-subject-tagpull_request:4255542806
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6544/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Bound the copilot ffmpeg tool, which runs FFmpeg in-process on the app server. Caps inputs at 10 per operation, rejected before any file is downloaded Give each operation one wall-clock bu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6544/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6544%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6544%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6544/files
Reloadhttps://github.com/simstudioai/sim/pull/6544/files
Reloadhttps://github.com/simstudioai/sim/pull/6544/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
security/ffmpeg-media-tool-limitshttps://github.com/simstudioai/sim/tree/security/ffmpeg-media-tool-limits
Conversation 22 https://github.com/simstudioai/sim/pull/6544
Commits 8 https://github.com/simstudioai/sim/pull/6544/commits
Checks 29 https://github.com/simstudioai/sim/pull/6544/checks
Files changed https://github.com/simstudioai/sim/pull/6544/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6544/files
fix(media): bound the copilot ffmpeg tool's inputs, runtime, and output paths https://github.com/simstudioai/sim/pull/6544/files#top
Show all changes 8 commits https://github.com/simstudioai/sim/pull/6544/files
4dc5a67 fix(media): bound the copilot ffmpeg tool's inputs, runtime, and outp… waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/4dc5a67353705948f08a9f485949f1410faef50c
260abe8 fix(media): address ffmpeg hardening review findings waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/260abe8d4039093c536e143ef45d3818323cc7de
9791fd8 refactor(media): reuse shared execution limits and give each rule one… waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/9791fd8668f76b0ba612961a90be8462efac3253
acc3c6d chore(media): drop comments that restate the code they annotate waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/acc3c6dd8c5cc2a8ae6546321c9931eed538c3f0
79d78e5 fix(media): let a host with only ffprobe still probe waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/79d78e540d7f910e5f23e884896950a353a9aaec
4560e5a fix(media): drop weba from the output allowlist waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/4560e5a99f685a2fd1fcea779140d630f127bee3
6c7a25e fix(media): look ffprobe up on PATH before ffmpeg's sibling waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/6c7a25e87ba97f30b84d8f2ae31130c4d543916c
dc6cc8b fix(media): floor the probe timeout and label audio-only webm correctly waleedlatif1 Aug 11, 2026 https://github.com/simstudioai/sim/pull/6544/commits/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95
Clear filters https://github.com/simstudioai/sim/pull/6544/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6544/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6544/files
base-tool.ts https://github.com/simstudioai/sim/pull/6544/files#diff-6ac7ea62cd786bc35d2ea91ed8cc6b55d078e2cd11ec6b6f1171c158be71b02c
ffmpeg.test.ts https://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
ffmpeg.ts https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
ffmpeg-probe-precedence.test.ts https://github.com/simstudioai/sim/pull/6544/files#diff-0d809565b068495771965c583869820234c5583bfe32853a8d85a2f16c372be7
ffmpeg-probe-resolution.test.ts https://github.com/simstudioai/sim/pull/6544/files#diff-a71c7c49e8c835c2c15ad9997a3ee5b75bf121ce101dca1265fa8b1ba798e597
ffmpeg.test.ts https://github.com/simstudioai/sim/pull/6544/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
ffmpeg.ts https://github.com/simstudioai/sim/pull/6544/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
apps/sim/lib/copilot/tools/server/base-tool.tshttps://github.com/simstudioai/sim/pull/6544/files#diff-6ac7ea62cd786bc35d2ea91ed8cc6b55d078e2cd11ec6b6f1171c158be71b02c
View file https://github.com/simstudioai/sim/blob/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95/apps/sim/lib/copilot/tools/server/base-tool.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6544/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6544/files#diff-6ac7ea62cd786bc35d2ea91ed8cc6b55d078e2cd11ec6b6f1171c158be71b02c
https://github.com/simstudioai/sim/pull/6544/files#diff-6ac7ea62cd786bc35d2ea91ed8cc6b55d078e2cd11ec6b6f1171c158be71b02c
https://github.com/simstudioai/sim/pull/6544/files#diff-6ac7ea62cd786bc35d2ea91ed8cc6b55d078e2cd11ec6b6f1171c158be71b02c
apps/sim/lib/copilot/tools/server/media/ffmpeg.test.tshttps://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
View file https://github.com/simstudioai/sim/blob/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95/apps/sim/lib/copilot/tools/server/media/ffmpeg.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6544/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
https://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
https://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
https://github.com/simstudioai/sim/pull/6544/files#diff-23c65b14e0c27a9e41070e0d872ac2edbf0dada17c31f57826f72002a45d5de0
apps/sim/lib/copilot/tools/server/media/ffmpeg.tshttps://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
View file https://github.com/simstudioai/sim/blob/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95/apps/sim/lib/copilot/tools/server/media/ffmpeg.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6544/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
https://github.com/simstudioai/sim/pull/6544/files#diff-8030aed9f9ee7d0778e55efbb00341798ef0d1d628947d81e23d2419093a40bd
apps/sim/lib/media/ffmpeg-probe-precedence.test.tshttps://github.com/simstudioai/sim/pull/6544/files#diff-0d809565b068495771965c583869820234c5583bfe32853a8d85a2f16c372be7
View file https://github.com/simstudioai/sim/blob/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95/apps/sim/lib/media/ffmpeg-probe-precedence.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6544/{{ revealButtonHref }}
apps/sim/lib/media/ffmpeg-probe-resolution.test.tshttps://github.com/simstudioai/sim/pull/6544/files#diff-a71c7c49e8c835c2c15ad9997a3ee5b75bf121ce101dca1265fa8b1ba798e597
View file https://github.com/simstudioai/sim/blob/dc6cc8bf6cd094d1f83eb67338b476bf9e54fb95/apps/sim/lib/media/ffmpeg-probe-resolution.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6544/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6544/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6544/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.