René's URL Explorer Experiment


Title: fix(deployments): stop superseded activations from dead-lettering by icecrasher321 · Pull Request #6522 · simstudioai/sim · GitHub

Open Graph Title: fix(deployments): stop superseded activations from dead-lettering by icecrasher321 · Pull Request #6522 · simstudioai/sim

X Title: fix(deployments): stop superseded activations from dead-lettering by icecrasher321 · Pull Request #6522 · simstudioai/sim

Description: What 29 workflow.deployment.prepare.v2 outbox events dead-lettered with Webhook registration operation is stale, spanning 2026-07-21 → 2026-08-09 across 13 workflows. Every one sat at attempts = max_attempts. That full retry budget is the tell: the failure is deterministic, which rules out the preparation path. An attempt superseded while preparing is marked superseded, so its next attempt short-circuits at the top of the handler and completes — it would die at attempts = 1, never 4. The branch a retry re-enters is the other one. isTerminalNonActiveOperation covers failed and superseded but not active, so an attempt that activated and was then superseded by the next deploy keeps its own active status, re-enters post-activation work on every retry, and re-fails the same generation fence until the event dies. The fence it fails is correct — it takes the same workflow row lock the generation bump takes, and compares generations exactly. Nothing about the detection is racy; only the reaction to it was wrong. Reaching it at all needs a handler timeout, which parks the row for the 10-minute reaper instead of the 2s/4s/8s backoff, opening a window wide enough for a redeploy to land. That is why the same workflow dominates both this class and the Outbox handler timed out after 90000ms class. Changes Gate the resume branch on still owning the current generation, matching the sibling cleanup that already does this, and complete the event as a no-op when it does not. The newer generation adopts the leftover work anyway — it collects every retired registration below its own fence, so nothing leaks. Reverse the post-activation order. The audit entry, analytics event, socket notification, and workspace event describe a cutover that is already durable, and each is separately checkpointed — but they ran behind retiring the previous generation's external subscriptions, one provider call per retired row and by far the most failure-prone step there. A single flaky provider silently cost the deploy its audit trail and left clients on the old version until something else refreshed them. Both call sites now share one helper so the order cannot drift apart again. Notes No new guards, try/catch, or fallbacks — the gate completes an existing terminal-state short-circuit that was missing a case, and the reorder moves existing work. Zero pre-existing tests changed; all test diffs are additive. The one deletion hoists a shared runInTx helper to module scope for a new describe block. Three new tests, each verified to fail against the unfixed source: superseded-resume no-op, still-current resume, and notify-before-cleanup ordering. Not covered: whatever makes that workflow's prepare step slow enough to hit 90s. This stops it manufacturing dead letters; it does not make it faster. 🤖 Generated with Claude Code

Open Graph Description: What 29 workflow.deployment.prepare.v2 outbox events dead-lettered with Webhook registration operation is stale, spanning 2026-07-21 → 2026-08-09 across 13 workflows. Every one sat at attempts = ma...

X Description: What 29 workflow.deployment.prepare.v2 outbox events dead-lettered with Webhook registration operation is stale, spanning 2026-07-21 → 2026-08-09 across 13 workflows. Every one sat at attempts = ma...

Opengraph URL: https://github.com/simstudioai/sim/pull/6522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dab51ff8-9bf7-bde5-c59d-8709647e0987
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9152:243FA5:9ED1CF:DA4C90:6AFB4DC9
html-safe-nonce57ab405a7bab6e6fca5216c46b635891b2d0710b3af122c826cb395b986a7ec1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTUyOjI0M0ZBNTo5RUQxQ0Y6REE0QzkwOjZBRkI0REM5IiwidmlzaXRvcl9pZCI6IjI4ODYxNzc2OTA2Njg5Nzc2MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdb6423d60b575ae8f5e4b109553d857b2fcba74b4c46bf1d4351dc81dc5fa380
hovercard-subject-tagpull_request:4249692573
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6522/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altWhat 29 workflow.deployment.prepare.v2 outbox events dead-lettered with Webhook registration operation is stale, spanning 2026-07-21 → 2026-08-09 across 13 workflows. Every one sat at attempts = ma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6522/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6522%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6522%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6522/files
Reloadhttps://github.com/simstudioai/sim/pull/6522/files
Reloadhttps://github.com/simstudioai/sim/pull/6522/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
staging-v33https://github.com/simstudioai/sim/tree/staging-v33
Conversation 20 https://github.com/simstudioai/sim/pull/6522
Commits 6 https://github.com/simstudioai/sim/pull/6522/commits
Checks 30 https://github.com/simstudioai/sim/pull/6522/checks
Files changed https://github.com/simstudioai/sim/pull/6522/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6522/files
fix(deployments): stop superseded activations from dead-lettering https://github.com/simstudioai/sim/pull/6522/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/6522/files
c6c5f56 fix(deployments): stop superseded activations from dead-lettering Aug 11, 2026 https://github.com/simstudioai/sim/pull/6522/commits/c6c5f563e4ba53092aa467d12cc8e33950b4b4a6
1e0b3a6 Merge remote-tracking branch 'origin/staging' into staging-v64 Aug 22, 2026 https://github.com/simstudioai/sim/pull/6522/commits/1e0b3a6bf9a5bc46a806cfea8d9c5b0e0b7a41ec
207a8b2 test(deployments): pin staging's active-resume tests to the current g… Aug 22, 2026 https://github.com/simstudioai/sim/pull/6522/commits/207a8b2092f58acedf3fcd82749eaf494af8a366
60866a8 fix(analytics): stop PostHog delivery from failing a deploy Aug 23, 2026 https://github.com/simstudioai/sim/pull/6522/commits/60866a850032ae96e16e718d6e6007dadc56a9df
3f13f9c Merge remote-tracking branch 'origin/staging' into staging-v64 Aug 23, 2026 https://github.com/simstudioai/sim/pull/6522/commits/3f13f9c5eb90ab6dffb7be2a3699f271c62f3fe5
def9273 fix(deployments): fence the cleanup, not the notifications Aug 23, 2026 https://github.com/simstudioai/sim/pull/6522/commits/def927385fabc56fb6825cef9d06565642aa0358
Clear filters https://github.com/simstudioai/sim/pull/6522/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6522/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6522/files
server.test.ts https://github.com/simstudioai/sim/pull/6522/files#diff-b47768015bd408f29f6df05e1721424622c64df64479779769a5f69d81aee8fc
server.ts https://github.com/simstudioai/sim/pull/6522/files#diff-cfa4da650faf3c66e056349f68b0932509f58e7ec054e970539a893adcf06530
registration-store.test.ts https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
deployment-lifecycle.ts https://github.com/simstudioai/sim/pull/6522/files#diff-8d0c640542bf3f6a2f5eb561fa015c209ddaf9c61aa564cea4c72fb7691f2a85
deployment-outbox.test.ts https://github.com/simstudioai/sim/pull/6522/files#diff-12eb6ae4ffd51f0f060ad9327b44c4f22d258c485a211fdf1b8b31bba354bf29
deployment-outbox.ts https://github.com/simstudioai/sim/pull/6522/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
apps/sim/lib/posthog/server.test.tshttps://github.com/simstudioai/sim/pull/6522/files#diff-b47768015bd408f29f6df05e1721424622c64df64479779769a5f69d81aee8fc
View file https://github.com/simstudioai/sim/blob/def927385fabc56fb6825cef9d06565642aa0358/apps/sim/lib/posthog/server.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6522/{{ revealButtonHref }}
apps/sim/lib/posthog/server.tshttps://github.com/simstudioai/sim/pull/6522/files#diff-cfa4da650faf3c66e056349f68b0932509f58e7ec054e970539a893adcf06530
View file https://github.com/simstudioai/sim/blob/def927385fabc56fb6825cef9d06565642aa0358/apps/sim/lib/posthog/server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6522/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6522/files#diff-cfa4da650faf3c66e056349f68b0932509f58e7ec054e970539a893adcf06530
apps/sim/lib/webhooks/registration-store.test.tshttps://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
View file https://github.com/simstudioai/sim/blob/def927385fabc56fb6825cef9d06565642aa0358/apps/sim/lib/webhooks/registration-store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6522/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
https://github.com/simstudioai/sim/pull/6522/files#diff-e0f4ccfd538d106122ac48919442435d06d603d78611360f62c205da6f7922d6
apps/sim/lib/workflows/deployment-lifecycle.tshttps://github.com/simstudioai/sim/pull/6522/files#diff-8d0c640542bf3f6a2f5eb561fa015c209ddaf9c61aa564cea4c72fb7691f2a85
View file https://github.com/simstudioai/sim/blob/def927385fabc56fb6825cef9d06565642aa0358/apps/sim/lib/workflows/deployment-lifecycle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6522/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6522/files#diff-8d0c640542bf3f6a2f5eb561fa015c209ddaf9c61aa564cea4c72fb7691f2a85
https://github.com/simstudioai/sim/pull/6522/files#diff-8d0c640542bf3f6a2f5eb561fa015c209ddaf9c61aa564cea4c72fb7691f2a85
Please reload this pagehttps://github.com/simstudioai/sim/pull/6522/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6522/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.