Title: docs(ci): correct the app-image runner sizing rationale with measured numbers by waleedlatif1 · Pull Request #6502 · simstudioai/sim · GitHub
Open Graph Title: docs(ci): correct the app-image runner sizing rationale with measured numbers by waleedlatif1 · Pull Request #6502 · simstudioai/sim
X Title: docs(ci): correct the app-image runner sizing rationale with measured numbers by waleedlatif1 · Pull Request #6502 · simstudioai/sim
Description: What The comment justifying the app image's 16 vCPU runner claimed both dominant steps scale with cores. Only one does. This corrects it with measured numbers. Comment-only. No behavior change — the non-comment diff is empty. The measurement Taken from two runs that restored the same sticky-disk parent snapshot (commit-01KZP43K3QNJ04JYYGQS7H1MMG), so the starting cache state was identical and runner size was the only variable: step 8 vCPU 16 vCPU [builder 5/6] next build 490.5s 143.9s 3.4x [deps 4/4] bun install + node-gyp 465.3s 547.2s no gain The deps layer is a bun install plus a node-gyp rebuild pinned to JOBS=4 (OOM guard, laverdet/isolated-vm#428), so cores cannot help it. Size this job on next build. Why the comment is worth fixing End-to-end duration says the opposite of the truth. The deps layer misses the Docker cache on nearly every run, and that ~500s swing swamps the 3.4x: 8 vCPU: 766s / 778s / 1020s / 1167s 16 vCPU: 965s That reads as "no win" and invites a revert that would throw away a real one. I nearly made exactly that mistake off these numbers, which is what prompted the comment fix. The cache miss itself is upstream of us: useblacksmith/setup-docker-builder derives its sticky-disk key from GITHUB_REPO_NAME alone, so all five image builds share one disk. Two consecutive successful app builds restored the same parent snapshot, meaning the first one's cache commit was discarded. Tracked separately; not addressed here. Test plan js-yaml parses ci.yml cleanly Non-comment diff is empty (git diff -U0 | grep -v '^[+-] *#' returns nothing)
Open Graph Description: What The comment justifying the app image's 16 vCPU runner claimed both dominant steps scale with cores. Only one does. This corrects it with measured numbers. Comment-only. No behavior change ...
X Description: What The comment justifying the app image's 16 vCPU runner claimed both dominant steps scale with cores. Only one does. This corrects it with measured numbers. Comment-only. No behavior cha...
Opengraph URL: https://github.com/simstudioai/sim/pull/6502
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:11e0188a-a4ce-6cda-a4b6-1d2057ef4f8f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9BA:23725B:9E5D01:DA2A60:6AFB4BEE |
| html-safe-nonce | 0f34afe650873b32a0183c6f4ff22e5460394ff1ddf539168d6e22e0513806c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUJBOjIzNzI1Qjo5RTVEMDE6REEyQTYwOjZBRkI0QkVFIiwidmlzaXRvcl9pZCI6IjMyOTgxNjYzNjQwNDM5NTUxODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3fdddf76fbb503b048b48010a17bc0c82908569e4bde19adf85c7d6f93f02c78 |
| hovercard-subject-tag | pull_request:4248196413 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6502/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | What The comment justifying the app image's 16 vCPU runner claimed both dominant steps scale with cores. Only one does. This corrects it with measured numbers. Comment-only. No behavior change ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width