Title: fix(files): stop validating .jsonl as single-document JSON by waleedlatif1 · Pull Request #6490 · simstudioai/sim · GitHub
Open Graph Title: fix(files): stop validating .jsonl as single-document JSON by waleedlatif1 · Pull Request #6490 · simstudioai/sim
X Title: fix(files): stop validating .jsonl as single-document JSON by waleedlatif1 · Pull Request #6490 · simstudioai/sim
Description: Summary .jsonl was mapped to Monaco's json language in the Files editor. JSON Lines holds one independent JSON value per line, so Monaco's single-document parser flags every line after the first as invalid — a wall of false errors on a well-formed file. Map .jsonl to plaintext instead. JSON validation can't be scoped to a single model (jsonDefaults is global), so opting JSONL out of the JSON language is the only per-file lever short of shipping a custom grammar. Trade-off: .jsonl loses syntax coloring but no longer reports false errors. A proper jsonl Monarch grammar would keep both; that's a larger change and not worth it at current usage. Behaviorally identical to deleting the key (no .jsonl MIME is in the MIME map, so the lookup already falls through to plaintext). Keeping the explicit entry plus the comment stops it from being "restored" to json later. Found while investigating an unrelated editor report — the root cause of that report is still unconfirmed, and this does not claim to address it. Type of Change Bug fix Testing Tested manually. MONACO_LANGUAGE_BY_EXTENSION and resolveMonacoLanguage are module-private with a single consumer, so the change only affects the language prop for .jsonl files — no persisted state, wire format, or contract is involved. plaintext is a Monaco built-in and already the fallback, so nothing new is registered. Typecheck and biome clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary .jsonl was mapped to Monaco's json language in the Files editor. JSON Lines holds one independent JSON value per line, so Monaco's single-document parser flags every line after the...
X Description: Summary .jsonl was mapped to Monaco's json language in the Files editor. JSON Lines holds one independent JSON value per line, so Monaco's single-document parser flags every line a...
Opengraph URL: https://github.com/simstudioai/sim/pull/6490
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:20789658-f503-4e3d-051c-dcfdcd570394 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD92:34DD79:EE773:152AE9:6AFB4C01 |
| html-safe-nonce | ec1d3d45929f8d54baed6c581a5618412daade81d794d235a5eac7da97ad598d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDkyOjM0REQ3OTpFRTc3MzoxNTJBRTk6NkFGQjRDMDEiLCJ2aXNpdG9yX2lkIjoiNjY1NjE0NDU3ODI5NjEwNTk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e9f9163214eac12d750381fc32df86b593913f1de690fed95fcc656c59bd584b |
| hovercard-subject-tag | pull_request:4246154287 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6490/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary .jsonl was mapped to Monaco's json language in the Files editor. JSON Lines holds one independent JSON value per line, so Monaco's single-document parser flags every line after the... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width