René's URL Explorer Experiment


Title: fix(invite): hold the loading state until the stored token resolves by waleedlatif1 · Pull Request #6488 · simstudioai/sim · GitHub

Open Graph Title: fix(invite): hold the loading state until the stored token resolves by waleedlatif1 · Pull Request #6488 · simstudioai/sim

X Title: fix(invite): hold the loading state until the stored token resolves by waleedlatif1 · Pull Request #6488 · simstudioai/sim

Description: Summary Closes two gaps left by #6486, both in apps/sim/app/invite/[id]/invite.tsx. Loading state didn't follow the query gate. #6486 gated the invitation query on isTokenResolved but left isLoading reading only invitationQuery.isPending. With enabled: false React Query still reports success when the key already holds data, so a cached null-token entry makes isPending false — the accept UI renders for one frame before the effect applies the stored token. Now !isTokenResolved || invitationQuery.isPending. Empty ?token= stopped falling back to storage. searchParams.get('token') returns '', which is not null, so token became '' where the pre-#6486 truthiness check (if (tokenFromQuery)) had read sessionStorage. Normalized with || null at the source, restoring the original behavior. Found by Cursor Bugbot on #6487 (the release PR), plus a re-check of my own change while verifying its claim. Type of Change Bug fix Testing bun run type-check, bun run lint:check (23/23), vitest run app/invite (6 tests) all pass. Behavior is unchanged on every reachable path except the two defects: Path Before After Cold load, no ?token= skeleton (isPending true, empty cache) skeleton (!isTokenResolved) — same ?token=xyz isTokenResolved true → isPending unchanged Signed out isLoading false unchanged Remount w/ cached null-token entry stale accept UI for one frame skeleton — fixed ?token= (empty) queried with '' falls back to storage — restored No permanent-skeleton risk: the effect always runs on mount and sessionStorage.getItem returns string | null, never undefined, so isTokenResolved always becomes true. Not browser-tested — the changed paths are a loading frame and an empty-param edge case. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Closes two gaps left by #6486, both in apps/sim/app/invite/[id]/invite.tsx. Loading state didn't follow the query gate. #6486 gated the invitation query on isTokenResolved but left isLo...

X Description: Summary Closes two gaps left by #6486, both in apps/sim/app/invite/[id]/invite.tsx. Loading state didn't follow the query gate. #6486 gated the invitation query on isTokenResolved but left ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6488

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bed88c76-0e89-a523-c5ce-bbaed2321713
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF48:14467D:35547C:4AF33B:6AFB56CF
html-safe-nonce2dca7c366a2ae2170ffbe17ea1f503dd5a230ca0025e536ec17240f2a15a1d92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjQ4OjE0NDY3RDozNTU0N0M6NEFGMzNCOjZBRkI1NkNGIiwidmlzaXRvcl9pZCI6IjUyMzQ1MjIxOTMwMDUzMzYyNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca7924faf620a06a3f051aaa9425ff9377156c5859635ad61e5be63411f5f8f55
hovercard-subject-tagpull_request:4242330626
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6488/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Closes two gaps left by #6486, both in apps/sim/app/invite/[id]/invite.tsx. Loading state didn't follow the query gate. #6486 gated the invitation query on isTokenResolved but left isLo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6488/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6488%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6488%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6488/files
Reloadhttps://github.com/simstudioai/sim/pull/6488/files
Reloadhttps://github.com/simstudioai/sim/pull/6488/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
invite-token-resolutionhttps://github.com/simstudioai/sim/tree/invite-token-resolution
Conversation 3 https://github.com/simstudioai/sim/pull/6488
Commits 1 https://github.com/simstudioai/sim/pull/6488/commits
Checks 30 https://github.com/simstudioai/sim/pull/6488/checks
Files changed https://github.com/simstudioai/sim/pull/6488/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6488/files
fix(invite): hold the loading state until the stored token resolves https://github.com/simstudioai/sim/pull/6488/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6488/files
8493aeb fix(invite): hold the loading state until the stored token resolves waleedlatif1 Aug 10, 2026 https://github.com/simstudioai/sim/pull/6488/commits/8493aeb7722fd11cd590794e33be8fb860eebd45
Clear filters https://github.com/simstudioai/sim/pull/6488/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6488/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6488/files
apps/sim/app/invite/[id]/invite.tsxhttps://github.com/simstudioai/sim/pull/6488/files#diff-a2c08b46c3d072cdfb8a9070aeccfb6e0dd696e3bc8181f139e7f70460a2181d
View file https://github.com/simstudioai/sim/blob/8493aeb7722fd11cd590794e33be8fb860eebd45/apps/sim/app/invite/%5Bid%5D/invite.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6488/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6488/files#diff-a2c08b46c3d072cdfb8a9070aeccfb6e0dd696e3bc8181f139e7f70460a2181d
https://github.com/simstudioai/sim/pull/6488/files#diff-a2c08b46c3d072cdfb8a9070aeccfb6e0dd696e3bc8181f139e7f70460a2181d
https://github.com/simstudioai/sim/pull/6488/files#diff-a2c08b46c3d072cdfb8a9070aeccfb6e0dd696e3bc8181f139e7f70460a2181d
Please reload this pagehttps://github.com/simstudioai/sim/pull/6488/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.