Title: fix(provenance): record why a resolved-secret registry became incomplete by waleedlatif1 · Pull Request #6478 · simstudioai/sim · GitHub
Open Graph Title: fix(provenance): record why a resolved-secret registry became incomplete by waleedlatif1 · Pull Request #6478 · simstudioai/sim
X Title: fix(provenance): record why a resolved-secret registry became incomplete by waleedlatif1 · Pull Request #6478 · simstudioai/sim
Description: Why ResolvedSecretTraceRegistry fails closed: when it can no longer vouch for what it projects, it marks itself incomplete. That state is one-way — isPermanentlyIncomplete() never resets — so a single trip fails every later model projection in the run, and the user gets one opaque sentence (... model input could not be safely projected) with no recourse. Many separate guards can set that state, and none of them recorded which one fired. resolved-secret-trace-registry.ts imported no logger at all, so after the fact there was no way to tell a genuine containment from a matcher that simply could not decide. What this changes No behaviour change. Each guard now names itself with a static reason literal: Reason Guard untrusted-provenance importProvenance rejects an untrusted/malformed bundle source-provenance-incomplete upstream bundle already incomplete entry-decrypt-failed was a bare catch {} that discarded the cause unverified-resolved-entry resolved value does not verify against the catalog projection-mismatch same raw value projected two different ways unresolved-placeholder projected marker with no matching entry provenance-capacity-exceeded entry-count or serialized-size cap hit restored-checkpoint-unavailable required restore checkpoint missing tool-call-scope-mismatch merged tool-call registry has a different scope constructed-incomplete registry built incomplete by construction inherited-incomplete-* (×2) a fork carrying a parent's existing incompleteness value-provenance-* (×3) per-value import guards Log level Three levels, defaulting to the safe one: error — reasons that mean something went wrong on a path that should have succeeded: projection-mismatch, entry-decrypt-failed, unverified-resolved-entry, unresolved-placeholder, provenance-capacity-exceeded, tool-call-scope-mismatch, untrusted-provenance, and the two value-provenance-* import guards. None is reachable on a healthy run. warn — the default for everything else: an upstream bundle that already declared itself incomplete, a fork inheriting a parent that reported moments earlier, and unspecified from the ~50 call sites outside this file that have not been audited yet. silent — constructed-incomplete. createIncompleteResolvedSecretTraceRegistry states outright that no trusted catalog was available; it carries nothing actionable. Defaulting to warn is deliberate. Incompleteness is the designed state wherever there is no catalog to vouch with, and those paths are hot — background/webhook-execution.ts:586 builds an incomplete registry on every webhook execution before replacing it with the real one. Logging that at error would have put a per-webhook error line on a completely healthy path. A reason added later without thought now stays quiet rather than paging someone. Error still matters for reach: getMinLogLevel() falls back to ERROR under NODE_ENV=production and under test, and helm/sim/templates/deployment-app.yaml sets no LOG_LEVEL at all, so on a default self-hosted chart only error survives. The reasons that indicate a real fault — including projection-mismatch — are the ones that get it. Decrypt failures are summarised once per import rather than once per entry: one rotated key fails every entry, and a bundle may carry up to MAX_PROVENANCE_ENTRIES of them. No secret material is logged Reasons are static literals, the logged inputPath is block/field names, and the remaining fields are cardinalities. The decrypt path records getErrorMessage(error) and whether the entry was named — never the value, the ciphertext, or the entry name. There is a test asserting the secret value and name are absent from the log record. The failure mode this was built to identify Driving the real classes reproduces the latch: const reg = await createResolvedSecretTraceRegistry({ /* SHORT_FLAG = 'true' */ }) reg.recordResolvedAtInputPath('SHORT_FLAG', 'true', ['flag']) reg.recordResolvedInputProjection(['flag'], 'true', '{{SHORT_FLAG}}') reg.recordResolvedAtInputPath('SHORT_FLAG', 'true', ['context']) reg.recordResolvedInputProjection(['context'], 'true', 'true') // literal, from third-party text reg.recordTransformedInputProjection( { flag: 'true', context: 'true' }, { flag: '{{SHORT_FLAG}}', context: '{{SHORT_FLAG}}' }, { targetPaths: [['flag'], ['context']] } ) // isPermanentlyIncomplete() === true A secret whose plaintext is very short (a flag, an emoji, a two-letter code) binds to an input path where those same characters occur only incidentally. The resolver records that path's projection as the literal; the handler's transform records it as a placeholder. Same raw value, different projected value, so recordState marks the path incomplete — and incompleteness is one-way, so the rest of the run's model projections fail. recordResolvedInputProjection is worth noting: it overwrites rawValue/projectedValue without the mismatch guard, so only the handler's later recordState can observe the disagreement. The behavioural fix is intentionally not in this PR. #6416 solved this class for the logging path with MIN_UNANCHORED_MATCH_LENGTH + word-boundary anchoring, and the same policy plausibly belongs where short values bind to input paths. But resolved-secret-matcher.ts documents its wider detection set as deliberate — "a narrow policy can never talk one of them out of failing closed" — so narrowing the wrong guard would convert a fail-closed into a silent leak. That change needs the author's intent and evidence of which guard actually fires, which is exactly what this PR produces. Type of Change Bug fix (diagnosability; no behaviour change) Testing Registry suite 66/66. Nine new tests cover the error level for genuine faults, the warn default for propagated/unaudited reasons, silence for the by-design construction, the named reason replacing unspecified, the split between a scope mismatch and an already-incomplete merged child, single-report attribution for an arriving-incomplete bundle, once-per-import decrypt summarisation, and the absence of secret material in the record. Each was verified to fail when its specific change is reverted. Wider run across executor, lib, background, app/api, providers, tools: 15,486 passing, 0 test failures. Typecheck and biome clean. (83 suites fail to collect in my worktree from a local tailwind v4/v3 resolution artifact — byte-identical list on a clean tree with this change stashed, so unrelated to this PR.) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Why ResolvedSecretTraceRegistry fails closed: when it can no longer vouch for what it projects, it marks itself incomplete. That state is one-way — isPermanentlyIncomplete() never resets — so a sin...
X Description: Why ResolvedSecretTraceRegistry fails closed: when it can no longer vouch for what it projects, it marks itself incomplete. That state is one-way — isPermanentlyIncomplete() never resets — so a sin...
Opengraph URL: https://github.com/simstudioai/sim/pull/6478
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5a1a8791-95d9-d14d-cb3f-d6484e78c009 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80FC:267719:9D96E2:D829ED:6AFB4DBA |
| html-safe-nonce | 251192b1170c3b9975bb04e1735a061a4269ed4f41923277d260fabde2e3a2a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEZDOjI2NzcxOTo5RDk2RTI6RDgyOUVEOjZBRkI0REJBIiwidmlzaXRvcl9pZCI6IjI0MTc3OTU3MjIwMDkxODQ1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e7773cc50203bf0bbb8c95fc9dbaa7db160db1c7b9d45c9ca917b16f35522d7d |
| hovercard-subject-tag | pull_request:4240709972 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6478/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Why ResolvedSecretTraceRegistry fails closed: when it can no longer vouch for what it projects, it marks itself incomplete. That state is one-way — isPermanentlyIncomplete() never resets — so a sin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width