René's URL Explorer Experiment


Title: fix(condition): stop shipping all block outputs in every evaluation by icecrasher321 · Pull Request #6468 · simstudioai/sim · GitHub

Open Graph Title: fix(condition): stop shipping all block outputs in every evaluation by icecrasher321 · Pull Request #6468 · simstudioai/sim

X Title: fix(condition): stop shipping all block outputs in every evaluation by icecrasher321 · Pull Request #6468 · simstudioai/sim

Description: Problem ConditionBlockHandler forwards collectBlockData's full blockData — every block output accumulated so far in the run — to function_execute on each condition evaluation. That payload is never read. The resolver already inlines every reference into the expression before the handler runs (resolver.ts resolveInputs → resolveTemplateWithoutConditionFormatting), so by the time the handler builds the request there is nothing left for the server-side resolveTagVariables pass to resolve. It only inflates the request body. Inside a wide subflow this is fatal: one flat blockStates map holds every branch's outputs, so branch N's gate carries branches 0…N. A 91-branch parallel pushed the body past the 10MB cap and failed with: Evaluation error in condition "If": Request body size limit exceeded (10MB). …even though the expression was just === true. Per-value large-value offload does not catch this — LARGE_VALUE_THRESHOLD_BYTES is 8MB for a single value, while this is an aggregate of many medium ones, so nothing ever trips the offload path. Fix Send blockData: {}, mirroring FunctionBlockHandler, which moved to exactly this in #4560 and left the condition handler on the old path. blockNameMapping and blockOutputSchemas are kept — they're bounded by workflow size, not run data. Why this is behavior-preserving blockData had exactly one server-side consumer: resolveTagVariables (app/api/function/execute/route.ts), which resolves leftover <...> tags. So this can only regress if a <...> tag survives the resolver into a condition's code. It can't: BlockResolver calls the same resolveBlockReference the route calls — both import from @/executor/utils/block-reference. The server pass was running identical logic over the same data, one step later. Name lookup — findBlockIdByName is nameToBlockId.get(normalizeName(name)) built from workflow.blocks; collectBlockData's blockNameMapping is built from the same array with the same normalizeName. Identical key set, so "executor can't find it" ⟹ "server can't find it." Output lookup — the executor's getBlockOutput is strictly richer (outer-branch index, parallelBlockMapping, cloned-subflow ids, suffix-walking in state.ts). collectBlockData only does a simple base-id alias. / / are handled by dedicated resolvers (SPECIAL_REFERENCE_PREFIXES) and were never in blockNameMapping anyway. Verified against the real resolver — every reference is inlined before the handler: === 'hello world' → 'hello world' === 'hello world' .length > 1 → ["a","b"].length > 1 === true → null === true ← block never executed > 3 → 5 > 3 The only case where a tag survives is an unknown block name, and feeding that case the exact blockData + blockNameMapping the old handler shipped returns undefined too — the old path couldn't rescue it either. Testing executor/ suite: 1843/1843 pass biome check: clean tsc --noEmit: no errors in changed code Added a regression test asserting collected block outputs are never forwarded (the mock returns a non-empty blockData; the assertion pins the forwarded value to {}) 🤖 Generated with Claude Code

Open Graph Description: Problem ConditionBlockHandler forwards collectBlockData's full blockData — every block output accumulated so far in the run — to function_execute on each condition evaluation. That payload is n...

X Description: Problem ConditionBlockHandler forwards collectBlockData&#39;s full blockData — every block output accumulated so far in the run — to function_execute on each condition evaluation. That payload ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6468

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ba5942f-20a0-f660-99ef-82b3cfd90509
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AE8:72699:FF248:167866:6AFB4BCE
html-safe-nonce6e71687b7d427b03cfa35eba873159049faff118f537e356e430c913200a1438
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUU4OjcyNjk5OkZGMjQ4OjE2Nzg2Njo2QUZCNEJDRSIsInZpc2l0b3JfaWQiOiIzOTg5NzMzODExODM4MjA4OTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ceae827b84ebdd3d9bcf3e19c1d21865eb35afd93ef33b05e9b9997f4292ef2
hovercard-subject-tagpull_request:4236762901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6468/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altProblem ConditionBlockHandler forwards collectBlockData's full blockData — every block output accumulated so far in the run — to function_execute on each condition evaluation. That payload is n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6468/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6468%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6468%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6468/files
Reloadhttps://github.com/simstudioai/sim/pull/6468/files
Reloadhttps://github.com/simstudioai/sim/pull/6468/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/condition-payload-sizehttps://github.com/simstudioai/sim/tree/fix/condition-payload-size
Conversation 3 https://github.com/simstudioai/sim/pull/6468
Commits 1 https://github.com/simstudioai/sim/pull/6468/commits
Checks 30 https://github.com/simstudioai/sim/pull/6468/checks
Files changed https://github.com/simstudioai/sim/pull/6468/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6468/files
fix(condition): stop shipping all block outputs in every evaluation https://github.com/simstudioai/sim/pull/6468/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6468/files
93fd34f fix(condition): stop shipping all block outputs in every evaluation Aug 9, 2026 https://github.com/simstudioai/sim/pull/6468/commits/93fd34fae437631385d9e08c35e03337e34f1bed
Clear filters https://github.com/simstudioai/sim/pull/6468/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6468/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6468/files
condition-handler.test.ts https://github.com/simstudioai/sim/pull/6468/files#diff-064a4bb886fba11b872087b9ced2f91da3c38abcf15f14af2c7d557c2b1db882
condition-handler.ts https://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
apps/sim/executor/handlers/condition/condition-handler.test.tshttps://github.com/simstudioai/sim/pull/6468/files#diff-064a4bb886fba11b872087b9ced2f91da3c38abcf15f14af2c7d557c2b1db882
View file https://github.com/simstudioai/sim/blob/93fd34fae437631385d9e08c35e03337e34f1bed/apps/sim/executor/handlers/condition/condition-handler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6468/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6468/files#diff-064a4bb886fba11b872087b9ced2f91da3c38abcf15f14af2c7d557c2b1db882
https://github.com/simstudioai/sim/pull/6468/files#diff-064a4bb886fba11b872087b9ced2f91da3c38abcf15f14af2c7d557c2b1db882
https://github.com/simstudioai/sim/pull/6468/files#diff-064a4bb886fba11b872087b9ced2f91da3c38abcf15f14af2c7d557c2b1db882
apps/sim/executor/handlers/condition/condition-handler.tshttps://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
View file https://github.com/simstudioai/sim/blob/93fd34fae437631385d9e08c35e03337e34f1bed/apps/sim/executor/handlers/condition/condition-handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6468/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
https://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
https://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
https://github.com/simstudioai/sim/pull/6468/files#diff-59b85c48f9cbcee6cddb93179ee9a261f9174a720f75ec87c584be23f1459ab5
Please reload this pagehttps://github.com/simstudioai/sim/pull/6468/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.