René's URL Explorer Experiment


Title: fix(knowledge): stop listing workspace knowledge bases on stale creator identity by waleedlatif1 · Pull Request #6454 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): stop listing workspace knowledge bases on stale creator identity by waleedlatif1 · Pull Request #6454 · simstudioai/sim

X Title: fix(knowledge): stop listing workspace knowledge bases on stale creator identity by waleedlatif1 · Pull Request #6454 · simstudioai/sim

Description: Summary GET /api/knowledge without a workspaceId ORed on knowledge_base.user_id with no permission check and no workspaceId IS NULL guard, so a user removed from a workspace kept seeing metadata (name, description, docCount, tokenCount, connectors) for every KB they created there — indefinitely, including KBs in archived workspaces under scope=all Scoped the creator fallback to legacy KBs with no workspaceId, matching what the workspace-filtered branch and resolveKnowledgeBaseAccess already enforce Collapsed the two near-identical or(...) shapes into one so both call paths share the same two authorization predicates Added mapWith to the shared drizzle sql test mock so this query is testable at all Type of Change Bug fix Testing bun run type-check, bun run lint, and 2054 tests across lib/knowledge, app/api/knowledge, app/api/v1, lib/copilot, lib/table pass. New tests assert the creator disjunct carries the workspaceId IS NULL guard on both branches — verified they go red against the pre-fix predicate. No client relies on the unfiltered branch: every in-app caller (useKnowledgeBasesList, /api/v1/knowledge, copilot VFS) passes a workspaceId. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary GET /api/knowledge without a workspaceId ORed on knowledge_base.user_id with no permission check and no workspaceId IS NULL guard, so a user removed from a workspace kept seeing metadata (...

X Description: Summary GET /api/knowledge without a workspaceId ORed on knowledge_base.user_id with no permission check and no workspaceId IS NULL guard, so a user removed from a workspace kept seeing metadata (...

Opengraph URL: https://github.com/simstudioai/sim/pull/6454

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:686a80d8-6a72-0e97-fcea-3c0b0ba09361
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3AC:243FA5:A503BC:E2C9F5:6AFB4F45
html-safe-nonce021871e3c2854e0ca35cb128e37d5aa018b3827070479875ce499683922aec3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0FDOjI0M0ZBNTpBNTAzQkM6RTJDOUY1OjZBRkI0RjQ1IiwidmlzaXRvcl9pZCI6Ijg2MjM1MDIzNTczNzMzNDE1MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac32848531d1d858c112dcc7a1f8ca24147ab30eb68a2826117feea81c35e17d44
hovercard-subject-tagpull_request:4236179077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6454/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary GET /api/knowledge without a workspaceId ORed on knowledge_base.user_id with no permission check and no workspaceId IS NULL guard, so a user removed from a workspace kept seeing metadata (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6454/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6454%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6454%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6454/files
Reloadhttps://github.com/simstudioai/sim/pull/6454/files
Reloadhttps://github.com/simstudioai/sim/pull/6454/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-kb-list-stale-creator-accesshttps://github.com/simstudioai/sim/tree/worktree-kb-list-stale-creator-access
Conversation 3 https://github.com/simstudioai/sim/pull/6454
Commits 1 https://github.com/simstudioai/sim/pull/6454/commits
Checks 30 https://github.com/simstudioai/sim/pull/6454/checks
Files changed https://github.com/simstudioai/sim/pull/6454/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6454/files
fix(knowledge): stop listing workspace knowledge bases on stale creator identity https://github.com/simstudioai/sim/pull/6454/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6454/files
88f9774 fix(knowledge): stop listing workspace knowledge bases on stale creat… waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6454/commits/88f97742e3da35ef1438416f68b0859fd06fca36
Clear filters https://github.com/simstudioai/sim/pull/6454/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6454/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6454/files
service.test.ts https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
service.ts https://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
database.mock.ts https://github.com/simstudioai/sim/pull/6454/files#diff-859f381ad1b6a93489bef08c44a1044a2c3cc6f9b98b8d973bb5b0ef893ba42b
apps/sim/lib/knowledge/service.test.tshttps://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
View file https://github.com/simstudioai/sim/blob/88f97742e3da35ef1438416f68b0859fd06fca36/apps/sim/lib/knowledge/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6454/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6454/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
apps/sim/lib/knowledge/service.tshttps://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
View file https://github.com/simstudioai/sim/blob/88f97742e3da35ef1438416f68b0859fd06fca36/apps/sim/lib/knowledge/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6454/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6454/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
packages/testing/src/mocks/database.mock.tshttps://github.com/simstudioai/sim/pull/6454/files#diff-859f381ad1b6a93489bef08c44a1044a2c3cc6f9b98b8d973bb5b0ef893ba42b
View file https://github.com/simstudioai/sim/blob/88f97742e3da35ef1438416f68b0859fd06fca36/packages/testing/src/mocks/database.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6454/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6454/files#diff-859f381ad1b6a93489bef08c44a1044a2c3cc6f9b98b8d973bb5b0ef893ba42b
https://github.com/simstudioai/sim/pull/6454/files#diff-859f381ad1b6a93489bef08c44a1044a2c3cc6f9b98b8d973bb5b0ef893ba42b
Please reload this pagehttps://github.com/simstudioai/sim/pull/6454/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.