René's URL Explorer Experiment


Title: fix(knowledge): validate tag slots and share the tag-name length limit by waleedlatif1 · Pull Request #6448 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): validate tag slots and share the tag-name length limit by waleedlatif1 · Pull Request #6448 · simstudioai/sim

X Title: fix(knowledge): validate tag slots and share the tag-name length limit by waleedlatif1 · Pull Request #6448 · simstudioai/sim

Description: Summary Validate the tag slot on write. It reached the DB unchecked: the contract types it as a plain string, the column is text (its Drizzle enum is types-only, so there is no DB constraint), and the service casts before inserting — so an unknown slot inserted a row nothing can ever read The create route checks the slot against its declared field type via the existing isValidSlotForFieldType, which also rejects a slot/field-type mismatch The bulk document route checks slot validity only. That route also renames existing definitions, which resend whatever pair is already stored, so a row that already holds a mismatched pair stays fixable Promote the tag display-name cap to a shared constant and apply it on every write path: both contracts, both modals, and the copilot create/update tools, whose names are model-generated and bypassed the contract entirely Drop two local copies of FIELD_TYPE_LABELS in favour of the shared one that two other components already import Notes The cap was already 100 on the bulk document route; this shares that number rather than inventing one. The internal create route previously had no cap, so a >100-char name posted there now returns 400 No new helper — the slot checks reuse isValidSlotForFieldType / getFieldTypeForSlot from lib/knowledge/constants Supersedes #6438, which was comment-only Type of Change Bug fix Testing Added route tests for an unknown slot, a slot/field-type mismatch, an unsupported field type, and the display-name cap; verified each fails without its guard. app/api/knowledge, tools, copilot-knowledge, webhooks, and inbox suites pass; type-check, lint:check, and check:api-validation:strict clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Validate the tag slot on write. It reached the DB unchecked: the contract types it as a plain string, the column is text (its Drizzle enum is types-only, so there is no DB constraint), and...

X Description: Summary Validate the tag slot on write. It reached the DB unchecked: the contract types it as a plain string, the column is text (its Drizzle enum is types-only, so there is no DB constraint), and...

Opengraph URL: https://github.com/simstudioai/sim/pull/6448

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee646a29-ecb0-f616-6ccc-327251adff5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC04:1D7E5A:981722:D15839:6AFB4C0D
html-safe-noncefa1a90b910403a9c953927549000203860269b09110a3d8927d2542f304f73fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzA0OjFEN0U1QTo5ODE3MjI6RDE1ODM5OjZBRkI0QzBEIiwidmlzaXRvcl9pZCI6IjUwMTI1OTMzMjE0OTEyNTQyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8a905b49033f24f39de3b7323a1dc62ae37682c37475aaee66a09433232b1b8b
hovercard-subject-tagpull_request:4236037597
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6448/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Validate the tag slot on write. It reached the DB unchecked: the contract types it as a plain string, the column is text (its Drizzle enum is types-only, so there is no DB constraint), and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6448/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6448%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6448%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6448/files
Reloadhttps://github.com/simstudioai/sim/pull/6448/files
Reloadhttps://github.com/simstudioai/sim/pull/6448/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
kb-tag-authz-followuphttps://github.com/simstudioai/sim/tree/kb-tag-authz-followup
Conversation 3 https://github.com/simstudioai/sim/pull/6448
Commits 1 https://github.com/simstudioai/sim/pull/6448/commits
Checks 30 https://github.com/simstudioai/sim/pull/6448/checks
Files changed https://github.com/simstudioai/sim/pull/6448/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6448/files
fix(knowledge): validate tag slots and share the tag-name length limit https://github.com/simstudioai/sim/pull/6448/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6448/files
1ca4b55 fix(knowledge): validate tag slots and share the tag-name length limit waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6448/commits/1ca4b559d38a20ab627bf0dba71d32176704433d
Clear filters https://github.com/simstudioai/sim/pull/6448/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6448/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6448/files
route.ts https://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
route.test.ts https://github.com/simstudioai/sim/pull/6448/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
route.ts https://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
document-tags-modal.tsx https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
base-tags-modal.tsx https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
tags.ts https://github.com/simstudioai/sim/pull/6448/files#diff-411f96f009355f5fb48408d5487ad8773675b746bc9259023ed1c1a064e95e5d
knowledge-base.ts https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
constants.ts https://github.com/simstudioai/sim/pull/6448/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
apps/sim/app/api/knowledge/[id]/documents/[documentId]/tag-definitions/route.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/app/api/knowledge/%5Bid%5D/documents/%5BdocumentId%5D/tag-definitions/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
https://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
https://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
https://github.com/simstudioai/sim/pull/6448/files#diff-e487ecd2ad408f0f48e5902c6b018b5b3b325ec7d9d4a4a57862ee7b2f068c51
apps/sim/app/api/knowledge/[id]/tag-definitions/route.test.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/app/api/knowledge/%5Bid%5D/tag-definitions/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
https://github.com/simstudioai/sim/pull/6448/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
https://github.com/simstudioai/sim/pull/6448/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
apps/sim/app/api/knowledge/[id]/tag-definitions/route.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/app/api/knowledge/%5Bid%5D/tag-definitions/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6448/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
...aceId]/knowledge/[id]/[documentId]/components/document-tags-modal/document-tags-modal.tsxhttps://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/%5BdocumentId%5D/components/document-tags-modal/document-tags-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
https://github.com/simstudioai/sim/pull/6448/files#diff-78cd7d90b9bc5d52ac1ddd910d5cce4e08605253caae9c183d2d4ebe88668eda
...app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal/base-tags-modal.tsxhttps://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/base-tags-modal/base-tags-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
https://github.com/simstudioai/sim/pull/6448/files#diff-137fe26a93dcc767bee01d05fc8e7e12d306bfd71795c040c8529d7f8cad0690
apps/sim/lib/api/contracts/knowledge/tags.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-411f96f009355f5fb48408d5487ad8773675b746bc9259023ed1c1a064e95e5d
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/lib/api/contracts/knowledge/tags.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-411f96f009355f5fb48408d5487ad8773675b746bc9259023ed1c1a064e95e5d
https://github.com/simstudioai/sim/pull/6448/files#diff-411f96f009355f5fb48408d5487ad8773675b746bc9259023ed1c1a064e95e5d
apps/sim/lib/copilot/tools/server/knowledge/knowledge-base.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/lib/copilot/tools/server/knowledge/knowledge-base.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
https://github.com/simstudioai/sim/pull/6448/files#diff-8d982a6c91da9f185f677492a89351171826dc834b3bb5c5923e776986d5027a
apps/sim/lib/knowledge/constants.tshttps://github.com/simstudioai/sim/pull/6448/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
View file https://github.com/simstudioai/sim/blob/1ca4b559d38a20ab627bf0dba71d32176704433d/apps/sim/lib/knowledge/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6448/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6448/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
https://github.com/simstudioai/sim/pull/6448/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
Please reload this pagehttps://github.com/simstudioai/sim/pull/6448/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.