René's URL Explorer Experiment


Title: fix(inbox): disable the inbox atomically and simplify its webhook tests by waleedlatif1 · Pull Request #6441 · simstudioai/sim · GitHub

Open Graph Title: fix(inbox): disable the inbox atomically and simplify its webhook tests by waleedlatif1 · Pull Request #6441 · simstudioai/sim

X Title: fix(inbox): disable the inbox atomically and simplify its webhook tests by waleedlatif1 · Pull Request #6441 · simstudioai/sim

Description: Follow-up audit of #6431 and #6436. Two findings, one behavioral and one test-quality. Atomic disable disableInbox deleted the webhook row and cleared the workspace inbox columns as two independent statements in a Promise.all. That was tolerable before, but workspace.inbox_provider_id is now uniquely indexed, which turns a half-applied disable into a fatal state: the workspace keeps the id of an AgentMail inbox that has already been deleted, that address becomes free at the provider, and the next workspace to claim the same username gets the same id back — so its enableInbox fails on the unique constraint and surfaces a raw Postgres error to the admin. Narrow (needs a partial failure plus username reuse) and self-inflicted, but it is a state the index newly makes unrecoverable, so both writes now run in one transaction. The AgentMail API deletes still happen before it, so no external I/O is held inside the transaction. Test simplification Dropped a ~35-line hand-rolled table fixture that schemaMock from @sim/testing already provides; the file now uses the repo idiom vi.mock('@sim/db', () => ({ ...dbChainMock, ...schemaMock })). Dropped a helper whose four queueTableRows calls were three-quarters no-ops — the shared chain mock already resolves unqueued chains to an empty array — along with its TSDoc, which was wrong about why the calls were needed. The unknown-inbox test previously queued an empty workspace result, which made it pass against the pre-fix code too. It now asserts the routed inbox id reaches the lookup, so it discriminates. Verified by checking out the pre-fix route from main and running the suite against it: 6 of 7 tests fail. The seventh is the oversized-body test, which guards the shared body cap that predates all of this and correctly passes on both. Audit findings that needed no change Recorded so they are on file rather than re-derived later: No legitimate delivery that previously succeeded now fails. Traced enable, rename, entitlement lapse, and both partial-write windows. In the one window that looked like a regression (webhook row written, workspace row not yet updated) the old code verified the signature and then failed its inboxProviderId mismatch check — same 401, same provider retry. The unverified inbox id influences nothing but secret selection. After the verification gate it is never read again; every downstream field comes from the post-verification parse. All 401 paths return an identical status and body, and both branches pay the same indexed round-trip, so there is no enumeration oracle. Removing the old post-verification mismatch check is provably redundant — there is now a single JSON.parse, so the routing id and the message id are the same object property. Every writer of inbox_provider_id audited: only enableInbox and disableInbox. Workspace creation and forking both omit the column, and no script-migration touches it.

Open Graph Description: Follow-up audit of #6431 and #6436. Two findings, one behavioral and one test-quality. Atomic disable disableInbox deleted the webhook row and cleared the workspace inbox columns as two independent...

X Description: Follow-up audit of #6431 and #6436. Two findings, one behavioral and one test-quality. Atomic disable disableInbox deleted the webhook row and cleared the workspace inbox columns as two independent...

Opengraph URL: https://github.com/simstudioai/sim/pull/6441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8000bd14-70af-2803-22ef-b13ad17a9ddd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9DC:7D93E:960E02:CDED73:6AFB4BCB
html-safe-nonceac25c1316c3a379838b67253ca69e23c7328dec8177dfe5be22cb62a787dbe09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOURDOjdEOTNFOjk2MEUwMjpDREVENzM6NkFGQjRCQ0IiLCJ2aXNpdG9yX2lkIjoiNzA4Mzk1MTU4MTg2MjUxMzYxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6958538664ef9dfbfe7af1a13df9bdc069c88a430e6a6a261bbc160b6048df2b
hovercard-subject-tagpull_request:4235973672
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6441/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up audit of #6431 and #6436. Two findings, one behavioral and one test-quality. Atomic disable disableInbox deleted the webhook row and cleared the workspace inbox columns as two independent...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6441/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6441%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6441%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6441/files
Reloadhttps://github.com/simstudioai/sim/pull/6441/files
Reloadhttps://github.com/simstudioai/sim/pull/6441/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
review/agentmail-test-hardeninghttps://github.com/simstudioai/sim/tree/review/agentmail-test-hardening
Conversation 3 https://github.com/simstudioai/sim/pull/6441
Commits 1 https://github.com/simstudioai/sim/pull/6441/commits
Checks 30 https://github.com/simstudioai/sim/pull/6441/checks
Files changed https://github.com/simstudioai/sim/pull/6441/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6441/files
fix(inbox): disable the inbox atomically and simplify its webhook tests https://github.com/simstudioai/sim/pull/6441/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6441/files
a1cef31 fix(inbox): disable the inbox atomically and simplify its webhook tests waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6441/commits/a1cef310a7be2dcc1058baf260ff7649d00576c8
Clear filters https://github.com/simstudioai/sim/pull/6441/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6441/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6441/files
route.test.ts https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
lifecycle.ts https://github.com/simstudioai/sim/pull/6441/files#diff-0944da2d1903e317696386696d0308b2ddddb08de7079911876b0ba79ce05ee1
apps/sim/app/api/webhooks/agentmail/route.test.tshttps://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
View file https://github.com/simstudioai/sim/blob/a1cef310a7be2dcc1058baf260ff7649d00576c8/apps/sim/app/api/webhooks/agentmail/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6441/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
https://github.com/simstudioai/sim/pull/6441/files#diff-4b24b495e724e59594a9d70b6f2aefe580a992ab01b181b8993645d93a16de1d
apps/sim/lib/mothership/inbox/lifecycle.tshttps://github.com/simstudioai/sim/pull/6441/files#diff-0944da2d1903e317696386696d0308b2ddddb08de7079911876b0ba79ce05ee1
View file https://github.com/simstudioai/sim/blob/a1cef310a7be2dcc1058baf260ff7649d00576c8/apps/sim/lib/mothership/inbox/lifecycle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6441/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6441/files#diff-0944da2d1903e317696386696d0308b2ddddb08de7079911876b0ba79ce05ee1
https://github.com/simstudioai/sim/pull/6441/files#diff-0944da2d1903e317696386696d0308b2ddddb08de7079911876b0ba79ce05ee1
Please reload this pagehttps://github.com/simstudioai/sim/pull/6441/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.