René's URL Explorer Experiment


Title: fix(cli): validate each install secret against its own requirement by waleedlatif1 · Pull Request #6440 · simstudioai/sim · GitHub

Open Graph Title: fix(cli): validate each install secret against its own requirement by waleedlatif1 · Pull Request #6440 · simstudioai/sim

X Title: fix(cli): validate each install secret against its own requirement by waleedlatif1 · Pull Request #6440 · simstudioai/sim

Description: Summary Follow-up review of the per-install secrets added in #6433. Four issues, all in that new code. Every secret was held to the 64-hex AES form, but only the encryption keys need it — BETTER_AUTH_SECRET and INTERNAL_API_SECRET are HMAC secrets needing 32 characters (env.ts, apps/realtime/src/env.ts). An operator-chosen passphrase in secrets.env was silently replaced on the next run, invalidating every sign-in. Now mirrors isUsableSecret in scripts/setup/env-files.ts. Published example values now rejected at any length. Relaxing to >= 32 would otherwise let dev-secret-at-least-32-characters-long (38 chars) and friends pass as real secrets. Replacing an existing value now backs the file up and says so, instead of logging it as a routine generation. Silently discarding a key that decrypts stored data was the one destructive path. API_ENCRYPTION_KEY is generated and passed. Without it the app stores workspace API keys in plain text. Safe on an existing install — values predating it lack the encrypted shape and are read as-is. Also: secrets are resolved before any container starts, so a filesystem problem reports a usable message rather than leaving a half-started stack behind; and the README documents the file, its format, and each key's requirement. Type of Change Bug fix Testing 17 lifecycle assertions, all passing: fresh install; second run is a byte-identical no-op; operator passphrases and hex keys preserved; published placeholders rejected, backed up and warned; API_ENCRYPTION_KEY added to an existing 3-key file without warning or backup; comment lines ignored; legacy values repaired. Full turbo run type-check (23/23), check:audits (22/22), and test:setup green. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up review of the per-install secrets added in #6433. Four issues, all in that new code. Every secret was held to the 64-hex AES form, but only the encryption keys need it — BETTER_A...

X Description: Summary Follow-up review of the per-install secrets added in #6433. Four issues, all in that new code. Every secret was held to the 64-hex AES form, but only the encryption keys need it — BETTER_A...

Opengraph URL: https://github.com/simstudioai/sim/pull/6440

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:435f733f-ace3-9b47-cf42-f71dcfb7d015
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3D4:3B3600:99C614:D38F23:6AFB4C0E
html-safe-nonce226b7ad2f62ef7f14b6bf2cfc64cf373a1b8a1563350980a5de679d83ea4508c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Q0OjNCMzYwMDo5OUM2MTQ6RDM4RjIzOjZBRkI0QzBFIiwidmlzaXRvcl9pZCI6IjU2MjE0NzczMDE2MDMyMjQ1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7d77299cf957736978adaf008c529eaa7ee865d2f85c873d00458c4747d6889b
hovercard-subject-tagpull_request:4235973662
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6440/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up review of the per-install secrets added in #6433. Four issues, all in that new code. Every secret was held to the 64-hex AES form, but only the encryption keys need it — BETTER_A...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6440/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6440%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6440%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6440/files
Reloadhttps://github.com/simstudioai/sim/pull/6440/files
Reloadhttps://github.com/simstudioai/sim/pull/6440/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
review/cli-install-secretshttps://github.com/simstudioai/sim/tree/review/cli-install-secrets
Conversation 7 https://github.com/simstudioai/sim/pull/6440
Commits 1 https://github.com/simstudioai/sim/pull/6440/commits
Checks 30 https://github.com/simstudioai/sim/pull/6440/checks
Files changed https://github.com/simstudioai/sim/pull/6440/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6440/files
fix(cli): validate each install secret against its own requirement https://github.com/simstudioai/sim/pull/6440/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6440/files
e1b8641 fix(cli): validate each install secret against its own requirement waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6440/commits/e1b86417649acb9634a10f10eb73fe850dc28619
Clear filters https://github.com/simstudioai/sim/pull/6440/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6440/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6440/files
README.md https://github.com/simstudioai/sim/pull/6440/files#diff-15986190ef9581ab59bcd5483b2c09e7fd0bd439d6f6cddbc94b0b1de094ee51
index.ts https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
packages/cli/README.mdhttps://github.com/simstudioai/sim/pull/6440/files#diff-15986190ef9581ab59bcd5483b2c09e7fd0bd439d6f6cddbc94b0b1de094ee51
View file https://github.com/simstudioai/sim/blob/e1b86417649acb9634a10f10eb73fe850dc28619/packages/cli/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6440/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6440/files#diff-15986190ef9581ab59bcd5483b2c09e7fd0bd439d6f6cddbc94b0b1de094ee51
https://github.com/simstudioai/sim/pull/6440/files#diff-15986190ef9581ab59bcd5483b2c09e7fd0bd439d6f6cddbc94b0b1de094ee51
packages/cli/src/index.tshttps://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
View file https://github.com/simstudioai/sim/blob/e1b86417649acb9634a10f10eb73fe850dc28619/packages/cli/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6440/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6440/files
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
https://github.com/simstudioai/sim/pull/6440/files#diff-2fb448d11702324cc59d657d5945d59cd325540eb87b71f2e66a5bc01ada834c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6440/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.