Title: fix(files): make the rich-markdown-field container a positioning context by waleedlatif1 · Pull Request #6435 · simstudioai/sim · GitHub
Open Graph Title: fix(files): make the rich-markdown-field container a positioning context by waleedlatif1 · Pull Request #6435 · simstudioai/sim
X Title: fix(files): make the rich-markdown-field container a positioning context by waleedlatif1 · Pull Request #6435 · simstudioai/sim
Description: Summary Follow-up to #6434 (native-pin bubble menus). That PR appended the menus into their scroll container using TipTap's default absolute strategy and made rich-markdown-editor's container a positioning context (relative) — but rich-markdown-field also mounts EditorBubbleMenu with its own container ref and was missed. Without relative there, the absolutely-positioned toolbar resolves against the wrong offset parent, so scroll tracking breaks in the field. Caught by Cursor Bugbot on #6434 after it merged. Adds relative to the field container. Safe in both modes: it adds no offset and no clipping, including the uncapped (page-scrolls) box. Type of Change Bug fix Testing Empirically verified in a harness against the real menu component: in the field's uncapped/page-scroll mode the toolbar pins to the cursor with 0 px drift on window scroll (the previously untested path). Capped mode uses the same mechanism already verified on #6434. 521 editor tests pass; type-check + biome clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #6434 (native-pin bubble menus). That PR appended the menus into their scroll container using TipTap's default absolute strategy and made rich-markdown-editor's contai...
X Description: Summary Follow-up to #6434 (native-pin bubble menus). That PR appended the menus into their scroll container using TipTap's default absolute strategy and made rich-markdown-editor'...
Opengraph URL: https://github.com/simstudioai/sim/pull/6435
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:411a65ad-3060-b021-419c-fe68484780ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1D4:3D53D8:9934D0:D297DD:6AFB4BD0 |
| html-safe-nonce | 7ff9519898dc1236ea4b0f9a390e1eacc802c186d4875419ee00f32933af39fa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQ0OjNENTNEODo5OTM0RDA6RDI5N0REOjZBRkI0QkQwIiwidmlzaXRvcl9pZCI6IjEwNDkzMDEwMTM3NDkyNTUxMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1bb929f9597631203df39bcfeb39611b980379dbc04bc827d744b0f0f185b24e |
| hovercard-subject-tag | pull_request:4235935331 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6435/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #6434 (native-pin bubble menus). That PR appended the menus into their scroll container using TipTap's default absolute strategy and made rich-markdown-editor's contai... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width