René's URL Explorer Experiment


Title: fix(files): escape user filenames in the Content-Disposition header by waleedlatif1 · Pull Request #6430 · simstudioai/sim · GitHub

Open Graph Title: fix(files): escape user filenames in the Content-Disposition header by waleedlatif1 · Pull Request #6430 · simstudioai/sim

X Title: fix(files): escape user filenames in the Content-Disposition header by waleedlatif1 · Pull Request #6430 · simstudioai/sim

Description: Summary escape the user-supplied filename before it is interpolated into the quoted filename parameter, so it cannot terminate the parameter or append parameters of its own always percent-encode the filename* ext-value fully, including the characters encodeURIComponent leaves raw filenames that are already safe printable ASCII keep their exact previous header, so ordinary downloads are unchanged a control character in a name no longer produces an invalid header value (that previously made the download 500) Type of Change Bug fix Testing Added unit tests covering each case, including that an ordinary filename is byte-identical to before. app/api/files suite passes (247 tests); type-check and lint clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary escape the user-supplied filename before it is interpolated into the quoted filename parameter, so it cannot terminate the parameter or append parameters of its own always percent-encode t...

X Description: Summary escape the user-supplied filename before it is interpolated into the quoted filename parameter, so it cannot terminate the parameter or append parameters of its own always percent-encode t...

Opengraph URL: https://github.com/simstudioai/sim/pull/6430

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8780f11e-2e95-6676-c067-efa1fac77c69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD31E:71DFA:825486:B896EE:6AFB4D57
html-safe-nonce14330a7fd3044bc57eb84bd47cde87800eeb512e0c04e5e5ec434157bd66cdaa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzFFOjcxREZBOjgyNTQ4NjpCODk2RUU6NkFGQjRENTciLCJ2aXNpdG9yX2lkIjoiNDE3NjM1MTA5MDAzNzE4MTc4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4216448fd8e3953fda1ac0b61432b1e4395207b210167226328a21e7f2bc40a
hovercard-subject-tagpull_request:4235772706
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6430/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary escape the user-supplied filename before it is interpolated into the quoted filename parameter, so it cannot terminate the parameter or append parameters of its own always percent-encode t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6430/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6430%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6430%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6430/files
Reloadhttps://github.com/simstudioai/sim/pull/6430/files
Reloadhttps://github.com/simstudioai/sim/pull/6430/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
content-disposition-escapinghttps://github.com/simstudioai/sim/tree/content-disposition-escaping
Conversation 3 https://github.com/simstudioai/sim/pull/6430
Commits 1 https://github.com/simstudioai/sim/pull/6430/commits
Checks 30 https://github.com/simstudioai/sim/pull/6430/checks
Files changed https://github.com/simstudioai/sim/pull/6430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6430/files
fix(files): escape user filenames in the Content-Disposition header https://github.com/simstudioai/sim/pull/6430/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6430/files
bbeee90 fix(files): escape user filenames in the Content-Disposition header waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6430/commits/bbeee9014a6badb7cab0f5cbde2cc943dd4021bb
Clear filters https://github.com/simstudioai/sim/pull/6430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6430/files
utils.test.ts https://github.com/simstudioai/sim/pull/6430/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
utils.ts https://github.com/simstudioai/sim/pull/6430/files#diff-cf0dbd7a02f4ac25fd4c864b014708c1d978d75efe972fae5ffcb021be58a9d3
apps/sim/app/api/files/utils.test.tshttps://github.com/simstudioai/sim/pull/6430/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
View file https://github.com/simstudioai/sim/blob/bbeee9014a6badb7cab0f5cbde2cc943dd4021bb/apps/sim/app/api/files/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6430/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6430/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
https://github.com/simstudioai/sim/pull/6430/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
https://github.com/simstudioai/sim/pull/6430/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
apps/sim/app/api/files/utils.tshttps://github.com/simstudioai/sim/pull/6430/files#diff-cf0dbd7a02f4ac25fd4c864b014708c1d978d75efe972fae5ffcb021be58a9d3
View file https://github.com/simstudioai/sim/blob/bbeee9014a6badb7cab0f5cbde2cc943dd4021bb/apps/sim/app/api/files/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6430/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6430/files#diff-cf0dbd7a02f4ac25fd4c864b014708c1d978d75efe972fae5ffcb021be58a9d3
https://github.com/simstudioai/sim/pull/6430/files#diff-cf0dbd7a02f4ac25fd4c864b014708c1d978d75efe972fae5ffcb021be58a9d3
Please reload this pagehttps://github.com/simstudioai/sim/pull/6430/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.