René's URL Explorer Experiment


Title: fix(knowledge): apply knowledge-base access checks consistently across auth types by waleedlatif1 · Pull Request #6426 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): apply knowledge-base access checks consistently across auth types by waleedlatif1 · Pull Request #6426 · simstudioai/sim

X Title: fix(knowledge): apply knowledge-base access checks consistently across auth types by waleedlatif1 · Pull Request #6426 · simstudioai/sim

Description: Summary Run the knowledge-base access check on the acting user for every auth type on /api/knowledge/[id]/tag-definitions, instead of only for browser sessions Use read access for GET and write access for POST, matching the sibling knowledge routes Require an acting user to be present before authorizing Thread the acting user through the KB tag schema enrichers so their request carries the identity the route authorizes Type of Change Bug fix Testing Added route tests covering both auth types and the granted/denied/not-found/no-acting-user paths, plus enricher tests. Verified each new test fails against the previous behavior. Full app/api/knowledge + tools suites pass (550 tests), type-check, lint:check, and check:api-validation:strict clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Run the knowledge-base access check on the acting user for every auth type on /api/knowledge/[id]/tag-definitions, instead of only for browser sessions Use read access for GET and write ac...

X Description: Summary Run the knowledge-base access check on the acting user for every auth type on /api/knowledge/[id]/tag-definitions, instead of only for browser sessions Use read access for GET and write ac...

Opengraph URL: https://github.com/simstudioai/sim/pull/6426

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5759c873-105f-9756-17d5-425a80c8e025
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D34:2B8D95:77A849:AA1B7D:6AFB4BFE
html-safe-noncef593cf01ddc8b3bf139917a77b5a27aa9adbb38203a45e0aa3c744166af47a8f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDM0OjJCOEQ5NTo3N0E4NDk6QUExQjdEOjZBRkI0QkZFIiwidmlzaXRvcl9pZCI6IjgyOTE4MzM0ODA4NTM4MDE5ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac51fc0cf8a1255c36a7a6f3fac1c0d5abde28326aded1d45dd758b11948f38a4e
hovercard-subject-tagpull_request:4235702146
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6426/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Run the knowledge-base access check on the acting user for every auth type on /api/knowledge/[id]/tag-definitions, instead of only for browser sessions Use read access for GET and write ac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6426/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6426%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6426%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6426/files
Reloadhttps://github.com/simstudioai/sim/pull/6426/files
Reloadhttps://github.com/simstudioai/sim/pull/6426/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-kb-tag-definitions-authzhttps://github.com/simstudioai/sim/tree/worktree-kb-tag-definitions-authz
Conversation 7 https://github.com/simstudioai/sim/pull/6426
Commits 2 https://github.com/simstudioai/sim/pull/6426/commits
Checks 30 https://github.com/simstudioai/sim/pull/6426/checks
Files changed https://github.com/simstudioai/sim/pull/6426/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6426/files
fix(knowledge): apply knowledge-base access checks consistently across auth types https://github.com/simstudioai/sim/pull/6426/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6426/files
51826e4 fix(knowledge): apply knowledge-base access checks consistently acros… waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6426/commits/51826e4775a297e5ff4a0471b87245ee4e3c4269
3419e4f chore(tests): mark tag-definition test fixtures as const waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6426/commits/3419e4f56a7b3e9d22e604486a7a284f5e6db224
Clear filters https://github.com/simstudioai/sim/pull/6426/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6426/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6426/files
route.test.ts https://github.com/simstudioai/sim/pull/6426/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
route.ts https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
params.ts https://github.com/simstudioai/sim/pull/6426/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
schema-enrichers.test.ts https://github.com/simstudioai/sim/pull/6426/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
schema-enrichers.ts https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
types.ts https://github.com/simstudioai/sim/pull/6426/files#diff-183540ce4359174673a854639c5032c16e740cb4951781bf2591b50f1cb68fac
apps/sim/app/api/knowledge/[id]/tag-definitions/route.test.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-901455fe42161e8a27d9c64dacc76fa4abef4024e2239a9772edb9467b694e1c
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/app/api/knowledge/%5Bid%5D/tag-definitions/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6426/files
apps/sim/app/api/knowledge/[id]/tag-definitions/route.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/app/api/knowledge/%5Bid%5D/tag-definitions/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
https://github.com/simstudioai/sim/pull/6426/files#diff-22369007075b21035311580cbc94ece8c939fca6276444b558952ce4c35a0c88
apps/sim/tools/params.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/tools/params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6426/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6426/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
apps/sim/tools/schema-enrichers.test.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/tools/schema-enrichers.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6426/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6426/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
https://github.com/simstudioai/sim/pull/6426/files#diff-57ef9bcb417356a1e5693652da28311a81a09ea4853dc10de30b5ab6f3027281
apps/sim/tools/schema-enrichers.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/tools/schema-enrichers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
https://github.com/simstudioai/sim/pull/6426/files#diff-6b7d7df16c3e579f487a4654102ba6ddb9ff5daef71f14766288411d5465dadc
apps/sim/tools/types.tshttps://github.com/simstudioai/sim/pull/6426/files#diff-183540ce4359174673a854639c5032c16e740cb4951781bf2591b50f1cb68fac
View file https://github.com/simstudioai/sim/blob/3419e4f56a7b3e9d22e604486a7a284f5e6db224/apps/sim/tools/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6426/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6426/files#diff-183540ce4359174673a854639c5032c16e740cb4951781bf2591b50f1cb68fac
https://github.com/simstudioai/sim/pull/6426/files#diff-183540ce4359174673a854639c5032c16e740cb4951781bf2591b50f1cb68fac
Please reload this pagehttps://github.com/simstudioai/sim/pull/6426/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.