René's URL Explorer Experiment


Title: improvement(files): harden untrusted document preview and parsing by waleedlatif1 · Pull Request #6420 · simstudioai/sim · GitHub

Open Graph Title: improvement(files): harden untrusted document preview and parsing by waleedlatif1 · Pull Request #6420 · simstudioai/sim

X Title: improvement(files): harden untrusted document preview and parsing by waleedlatif1 · Pull Request #6420 · simstudioai/sim

Description: Summary Tighten the render options the docx preview passes to docx-preview so it only renders the document body, and drop embedded frames/plugin elements from rendered content Tighten the OOXML archive size guard: cap the largest single XML part and lower the total expanded-size ceiling so oversized archives are rejected before a parser materializes them Type of Change Improvement Testing Unit tests for the sanitizer pass and the archive guard (per-entry cap, total cap, media-part scoping); measured against crafted inputs locally. Type-check and lint clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Tighten the render options the docx preview passes to docx-preview so it only renders the document body, and drop embedded frames/plugin elements from rendered content Tighten the OOXML ar...

X Description: Summary Tighten the render options the docx preview passes to docx-preview so it only renders the document body, and drop embedded frames/plugin elements from rendered content Tighten the OOXML ar...

Opengraph URL: https://github.com/simstudioai/sim/pull/6420

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:21b229d1-bbbd-aae3-f864-7d3a4e69ce44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF42:2F4711:2770D1:37499D:6AFB52D2
html-safe-nonce5812c6f84e233a478f47607f537ccd4bbc2236ae39da824895e3206877f76b48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjQyOjJGNDcxMToyNzcwRDE6Mzc0OTlEOjZBRkI1MkQyIiwidmlzaXRvcl9pZCI6Ijc2ODk5OTI5Mzc4Njk2MjgxMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac624c34f5504315b1718de079fa72bb1184607bb6db9ba9e6a2b836b484284575
hovercard-subject-tagpull_request:4235669740
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6420/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Tighten the render options the docx preview passes to docx-preview so it only renders the document body, and drop embedded frames/plugin elements from rendered content Tighten the OOXML ar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6420/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6420%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6420%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6420/files
Reloadhttps://github.com/simstudioai/sim/pull/6420/files
Reloadhttps://github.com/simstudioai/sim/pull/6420/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
docx-preview-hardeninghttps://github.com/simstudioai/sim/tree/docx-preview-hardening
Conversation 12 https://github.com/simstudioai/sim/pull/6420
Commits 3 https://github.com/simstudioai/sim/pull/6420/commits
Checks 30 https://github.com/simstudioai/sim/pull/6420/checks
Files changed https://github.com/simstudioai/sim/pull/6420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
improvement(files): harden untrusted document preview and parsing https://github.com/simstudioai/sim/pull/6420/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6420/files
4123f07 improvement(files): harden the docx preview renderer waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6420/commits/4123f07a79d551d1e0ce97628dd88165822816f5
518c4e0 fix(files): tighten the OOXML archive size guard against parser OOM waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6420/commits/518c4e0a6e73f070fd9d4dcb903c33de915a16dc
b4bcd00 fix(files): apply the per-entry OOXML cap to every part, not just XML… waleedlatif1 Aug 8, 2026 https://github.com/simstudioai/sim/pull/6420/commits/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6
Clear filters https://github.com/simstudioai/sim/pull/6420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
docx-preview.tsx https://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
url-safety.test.ts https://github.com/simstudioai/sim/pull/6420/files#diff-6b90caa490c1dba8f5292f374acbd479aa24477434ed5f9bfae29de58aa203e1
url-safety.ts https://github.com/simstudioai/sim/pull/6420/files#diff-a6f9cb689c266186e2d6c5b7c3a3f93b491bddb1cdce5d716b30c1c12d23c09a
zip-guard.test.ts https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
zip-guard.ts https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/docx-preview.tsxhttps://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
View file https://github.com/simstudioai/sim/blob/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/docx-preview.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
https://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
https://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
https://github.com/simstudioai/sim/pull/6420/files#diff-07a52d21389f1388c0ff695dd4222845f6392c1a1fd6c5a1dbc3cd9d685ad3d9
apps/sim/lib/core/security/url-safety.test.tshttps://github.com/simstudioai/sim/pull/6420/files#diff-6b90caa490c1dba8f5292f374acbd479aa24477434ed5f9bfae29de58aa203e1
View file https://github.com/simstudioai/sim/blob/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6/apps/sim/lib/core/security/url-safety.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6420/files#diff-6b90caa490c1dba8f5292f374acbd479aa24477434ed5f9bfae29de58aa203e1
https://github.com/simstudioai/sim/pull/6420/files#diff-6b90caa490c1dba8f5292f374acbd479aa24477434ed5f9bfae29de58aa203e1
https://github.com/simstudioai/sim/pull/6420/files#diff-6b90caa490c1dba8f5292f374acbd479aa24477434ed5f9bfae29de58aa203e1
apps/sim/lib/core/security/url-safety.tshttps://github.com/simstudioai/sim/pull/6420/files#diff-a6f9cb689c266186e2d6c5b7c3a3f93b491bddb1cdce5d716b30c1c12d23c09a
View file https://github.com/simstudioai/sim/blob/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6/apps/sim/lib/core/security/url-safety.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6420/files#diff-a6f9cb689c266186e2d6c5b7c3a3f93b491bddb1cdce5d716b30c1c12d23c09a
https://github.com/simstudioai/sim/pull/6420/files#diff-a6f9cb689c266186e2d6c5b7c3a3f93b491bddb1cdce5d716b30c1c12d23c09a
apps/sim/lib/file-parsers/zip-guard.test.tshttps://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
View file https://github.com/simstudioai/sim/blob/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6/apps/sim/lib/file-parsers/zip-guard.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
https://github.com/simstudioai/sim/pull/6420/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
apps/sim/lib/file-parsers/zip-guard.tshttps://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
View file https://github.com/simstudioai/sim/blob/b4bcd0072f23843e9678cdacbd6d4bfd5f4e2eb6/apps/sim/lib/file-parsers/zip-guard.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/6420/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
Please reload this pagehttps://github.com/simstudioai/sim/pull/6420/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.