René's URL Explorer Experiment


Title: fix(files): stop the file-viewer image reshift on open by waleedlatif1 · Pull Request #6390 · simstudioai/sim · GitHub

Open Graph Title: fix(files): stop the file-viewer image reshift on open by waleedlatif1 · Pull Request #6390 · simstudioai/sim

X Title: fix(files): stop the file-viewer image reshift on open by waleedlatif1 · Pull Request #6390 · simstudioai/sim

Description: Summary Embedded images in a markdown file reshifted on every open: the image loaded ~2.3s in with no reserved box and shoved everything below it down (CLS ~0.17). The untitled.md mention itself never moved — the image just popped in nearby. Root cause: the intrinsic dimensions are stored server-side, but useWorkspaceImageDimensionsAdapter read the files list via queryClient.getQueryData non-reactively. On a cold file-view load the list isn't cached when the image renders, so it returned null; and with a stable adapter identity it never re-checked when the list resolved → no reservation → reflow. Fix: read the list via a reactive useWorkspaceFiles subscription. The adapter re-identifies when the list arrives, re-running the image node view's memoized dimension read so it reserves the box from the stored dims before the slower image download finishes. Query key is shared (dedupes with surrounding views). Gated behind enabled: !contentSource so the public share page (which passes a share token as workspaceId) doesn't fire a 404. Also fixes a pre-existing warning surfaced during investigation: the @-menu extension and the mention node were both named mention (Duplicate extension names found: ['mention']). Renamed the menu extension to mentionMenu (node keeps mention, its persisted doc type) + moved its storage key. Type of Change Bug fix Testing Reproduced + verified in a Playwright CLS harness that drives the real collaborative load path (placeholder→live swap seeded via the same converter the realtime server uses): dims present → 0 shift; dims absent → 0.20. 521 rich-markdown-editor unit tests pass; type-check clean; duplicate-mention warning confirmed gone. ⚠️ Not yet confirmed on deployed staging — the reserve depends on the list fetch (~100–300ms) resolving before the image download (~2.3s), which it should comfortably; a post-deploy re-run of the CLS probe on the staging file page is the final confirmation. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Embedded images in a markdown file reshifted on every open: the image loaded ~2.3s in with no reserved box and shoved everything below it down (CLS ~0.17). The untitled.md mention itself n...

X Description: Summary Embedded images in a markdown file reshifted on every open: the image loaded ~2.3s in with no reserved box and shoved everything below it down (CLS ~0.17). The untitled.md mention itself n...

Opengraph URL: https://github.com/simstudioai/sim/pull/6390

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5906177f-d0be-d39d-2e76-eef43e9c1e89
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA410:1D4A3:A8BF64:E758A3:6AFB4F49
html-safe-nonced2ab7480be695feb2fec33ea4dc9e0e1390666393f8bf62382097e1ab3e7bed3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDEwOjFENEEzOkE4QkY2NDpFNzU4QTM6NkFGQjRGNDkiLCJ2aXNpdG9yX2lkIjoiMTYwMjQxMDAxNTk3OTQyNTYwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd56d705a571ece73b05230b31b775107b4233a836f2aefd243316477a6b87573
hovercard-subject-tagpull_request:4231861902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6390/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Embedded images in a markdown file reshifted on every open: the image loaded ~2.3s in with no reserved box and shoved everything below it down (CLS ~0.17). The untitled.md mention itself n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6390/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6390%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6390%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6390/files
Reloadhttps://github.com/simstudioai/sim/pull/6390/files
Reloadhttps://github.com/simstudioai/sim/pull/6390/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-viewer-image-reshifthttps://github.com/simstudioai/sim/tree/fix/file-viewer-image-reshift
Conversation 10 https://github.com/simstudioai/sim/pull/6390
Commits 2 https://github.com/simstudioai/sim/pull/6390/commits
Checks 30 https://github.com/simstudioai/sim/pull/6390/checks
Files changed https://github.com/simstudioai/sim/pull/6390/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6390/files
fix(files): stop the file-viewer image reshift on open https://github.com/simstudioai/sim/pull/6390/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6390/files
affb1d8 fix(files): reserve embedded-image space on direct file-view loads waleedlatif1 Aug 7, 2026 https://github.com/simstudioai/sim/pull/6390/commits/affb1d87aac1bfbf8200f540917de2a3f6157c5d
08682da fix(files): stop the duplicate 'mention' extension-name warning waleedlatif1 Aug 7, 2026 https://github.com/simstudioai/sim/pull/6390/commits/08682dab8ccab1433bb3794a6d5b59951c6e9627
Clear filters https://github.com/simstudioai/sim/pull/6390/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6390/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6390/files
file-viewer.tsx https://github.com/simstudioai/sim/pull/6390/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
mention-chip.test.tsx https://github.com/simstudioai/sim/pull/6390/files#diff-be7daee935edb2660a96c63821073eac2119d601b7e2e29a6313c43edaddee16
mention-chip.tsx https://github.com/simstudioai/sim/pull/6390/files#diff-dcf48e3b6c606a22166f4056ee26aa3615ad1ad3257e22d9398998855865ee84
mention.ts https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
use-editor-mentions.ts https://github.com/simstudioai/sim/pull/6390/files#diff-8cf2889b1b63eeb93a7260be74f0e9e95b3cd0e34481367c540899af348b8cf6
workspace-files.ts https://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsxhttps://github.com/simstudioai/sim/pull/6390/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/file-viewer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
https://github.com/simstudioai/sim/pull/6390/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
...kspaceId]/files/components/file-viewer/rich-markdown-editor/mention/mention-chip.test.tsxhttps://github.com/simstudioai/sim/pull/6390/files#diff-be7daee935edb2660a96c63821073eac2119d601b7e2e29a6313c43edaddee16
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/mention/mention-chip.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-be7daee935edb2660a96c63821073eac2119d601b7e2e29a6313c43edaddee16
https://github.com/simstudioai/sim/pull/6390/files#diff-be7daee935edb2660a96c63821073eac2119d601b7e2e29a6313c43edaddee16
.../[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/mention-chip.tsxhttps://github.com/simstudioai/sim/pull/6390/files#diff-dcf48e3b6c606a22166f4056ee26aa3615ad1ad3257e22d9398998855865ee84
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/mention/mention-chip.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-dcf48e3b6c606a22166f4056ee26aa3615ad1ad3257e22d9398998855865ee84
Please reload this pagehttps://github.com/simstudioai/sim/pull/6390/files
https://github.com/simstudioai/sim/pull/6390/files#diff-dcf48e3b6c606a22166f4056ee26aa3615ad1ad3257e22d9398998855865ee84
...kspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/mention.tshttps://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/mention/mention.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
https://github.com/simstudioai/sim/pull/6390/files#diff-893353a58f0d8e9f61c1f05a55ded08f39758799dc40b3acac8a93b13ff0263b
...spaceId]/files/components/file-viewer/rich-markdown-editor/mention/use-editor-mentions.tshttps://github.com/simstudioai/sim/pull/6390/files#diff-8cf2889b1b63eeb93a7260be74f0e9e95b3cd0e34481367c540899af348b8cf6
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/mention/use-editor-mentions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-8cf2889b1b63eeb93a7260be74f0e9e95b3cd0e34481367c540899af348b8cf6
apps/sim/hooks/queries/workspace-files.tshttps://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
View file https://github.com/simstudioai/sim/blob/08682dab8ccab1433bb3794a6d5b59951c6e9627/apps/sim/hooks/queries/workspace-files.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6390/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
https://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
https://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
https://github.com/simstudioai/sim/pull/6390/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
Please reload this pagehttps://github.com/simstudioai/sim/pull/6390/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.