Title: fix(providers): stop reporting an absent Ollama as an error by waleedlatif1 · Pull Request #6387 · simstudioai/sim · GitHub
Open Graph Title: fix(providers): stop reporting an absent Ollama as an error by waleedlatif1 · Pull Request #6387 · simstudioai/sim
X Title: fix(providers): stop reporting an absent Ollama as an error by waleedlatif1 · Pull Request #6387 · simstudioai/sim
Description: Summary OllamaModelsAPI is the single largest error stream in the app: 10,068 in 14 days, and every one is the same line — Unable to connect to http://localhost:11434. OLLAMA_URL is unset in production, so the route falls back to a hardcoded loopback default and dials it on every poll. Its siblings already handle this correctly, and produce zero errors over the same window: Route Absent-service handling Errors / 14d vLLM logger.info('VLLM_BASE_URL not configured') 0 LiteLLM logger.info('LITELLM_BASE_URL not configured') 0 Ollama none — always dials the default 10,068 Changes An unreachable Ollama logs at info, not error. It is optional; a deployment that runs none refuses the connection on every poll, which is an expected state, not a failure of this route. This is the half that helps self-hosters The hosted platform skips the probe, since it has no local runtime and the loopback default cannot answer — but only when OLLAMA_URL is unset. An explicit URL states intent and is still honoured, even on hosted isOllamaUrlConfigured() sits beside getOllamaUrl() so OLLAMA_URL keeps a single owner, rather than the route reaching around it to read the same variable The response is { models: [] } on every non-success path, exactly as before — the same value a blacklisted provider already returns. Nothing changes for self-hosters All four permutations are exercised as tests: Deployment Probes Ollama? vs. before Self-hosted, localhost default, no configuration yes identical Self-hosted, explicit OLLAMA_URL yes identical Hosted, no configuration skipped the fix Hosted, explicit OLLAMA_URL yes honoured Verified preconditions rather than assumed them: OLLAMA_URL is declared in the env schema (z.string().url().optional()), so the configured-check reads a real value isHosted is forceHosted || hostname === 'sim.ai' || *.sim.ai, and forceHosted requires !isProd — a self-hosted production deployment can never satisfy it providers/utils already imports env-flags, so the new import adds no dependency weight The Ollama provider (providers/ollama/index.ts, the execution path) is untouched; this only affects the model-listing route Type of Change Bug fix Testing 5 tests. Both halves verified red on their own revert — removing the gate fails the hosted case, restoring logger.error fails the unreachable case. The first version of the level test passed either way (it only asserted the response body), so it now asserts the level itself. app/api/providers 50 passing / 5 files; wider sweep 1,593 passing. Typecheck, biome, and check:api-validation clean. One unrelated suite fails in the worktree from a tailwind v4/v3 resolution artifact — it fails with my changes stashed and passes on the main checkout (13/13). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary OllamaModelsAPI is the single largest error stream in the app: 10,068 in 14 days, and every one is the same line — Unable to connect to http://localhost:11434. OLLAMA_URL is unset in produc...
X Description: Summary OllamaModelsAPI is the single largest error stream in the app: 10,068 in 14 days, and every one is the same line — Unable to connect to http://localhost:11434. OLLAMA_URL is unset in produc...
Opengraph URL: https://github.com/simstudioai/sim/pull/6387
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1307f708-9712-db2f-1bc4-94ce1cf76816 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC88:4466C:27A16F:377F95:6AFB52FC |
| html-safe-nonce | 9f4c66638b5d2bb581feaea92c33e4fcc54321d5fac01ce479c354eb39e58ca9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzg4OjQ0NjZDOjI3QTE2RjozNzdGOTU6NkFGQjUyRkMiLCJ2aXNpdG9yX2lkIjoiMTU5ODE5MzU0MzUwNTcyODI1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f4d147537462f4099c2b1cfc179430fc51d462e2031ead42af0368084e150ed5 |
| hovercard-subject-tag | pull_request:4231170263 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6387/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary OllamaModelsAPI is the single largest error stream in the app: 10,068 in 14 days, and every one is the same line — Unable to connect to http://localhost:11434. OLLAMA_URL is unset in produc... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width