René's URL Explorer Experiment


Title: fix(files): render the file-viewer placeholder through the live node views by waleedlatif1 · Pull Request #6379 · simstudioai/sim · GitHub

Open Graph Title: fix(files): render the file-viewer placeholder through the live node views by waleedlatif1 · Pull Request #6379 · simstudioai/sim

X Title: fix(files): render the file-viewer placeholder through the live node views by waleedlatif1 · Pull Request #6379 · simstudioai/sim

Description: Summary The collaborative markdown viewer painted a static generateHTML placeholder while the Yjs doc seeded, then swapped to the live editor. generateHTML runs only schema renderHTML — never the React node views or decoration plugins — so content repainted on the swap: syntax highlighting popped in, mention-chip icons shifted their labels, mermaid blocks jumped from source to diagram, and media embeds appeared out of nowhere. Render the placeholder through a read-only editor that shares the live editor's extension set instead. It uses the same node views and decoration plugins, so the placeholder is pixel-identical to the live editor and the swap neither repaints nor reflows. Highlighting, mention icons, images, mermaid (via its existing SVG cache), and embeds (which already reserve their aspect-ratio box) all render up front. The placeholder carries no Collaboration extension, Y.Doc, or awareness, so it structurally cannot write to the shared document (seed-only-on-server preserved); editable={false} disables every editing affordance. Type of Change Bug fix Testing 521 rich-markdown-editor unit tests pass; type-check clean. Known inherent residual: the very first render of a never-before-rendered mermaid diagram is async (one bounded reflow); every render after that is instant via the process-lifetime SVG cache. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The collaborative markdown viewer painted a static generateHTML placeholder while the Yjs doc seeded, then swapped to the live editor. generateHTML runs only schema renderHTML — never the ...

X Description: Summary The collaborative markdown viewer painted a static generateHTML placeholder while the Yjs doc seeded, then swapped to the live editor. generateHTML runs only schema renderHTML — never the ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6379

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17fb1b1e-08a1-dfb8-53ea-cd1f2a77a3dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88BA:3491F9:EFF580:14915C7:6AFB5F26
html-safe-nonce72296135d60e8f5a9368699b6bb80038255ab60e512698ae800c445de3e99b18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEJBOjM0OTFGOTpFRkY1ODA6MTQ5MTVDNzo2QUZCNUYyNiIsInZpc2l0b3JfaWQiOiI2ODA1MjMzODY2NzgxNzEyMTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0ec963d6ba6b903f33871eb5525b131c9ad4abe5d9b7edd4b0a1e4f88d4ac14d
hovercard-subject-tagpull_request:4230469433
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6379/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The collaborative markdown viewer painted a static generateHTML placeholder while the Yjs doc seeded, then swapped to the live editor. generateHTML runs only schema renderHTML — never the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6379/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6379%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6379%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6379/files
Reloadhttps://github.com/simstudioai/sim/pull/6379/files
Reloadhttps://github.com/simstudioai/sim/pull/6379/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-viewer-reflow-on-loadhttps://github.com/simstudioai/sim/tree/fix/file-viewer-reflow-on-load
Conversation 12 https://github.com/simstudioai/sim/pull/6379
Commits 2 https://github.com/simstudioai/sim/pull/6379/commits
Checks 31 https://github.com/simstudioai/sim/pull/6379/checks
Files changed https://github.com/simstudioai/sim/pull/6379/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6379/files
fix(files): render the file-viewer placeholder through the live node views https://github.com/simstudioai/sim/pull/6379/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6379/files
b5cc8f6 fix(files): render the file-viewer placeholder through the live node … waleedlatif1 Aug 7, 2026 https://github.com/simstudioai/sim/pull/6379/commits/b5cc8f6937be3b6f05f2bc89749baff370feb407
98ed8bc fix(files): address review on the placeholder editor waleedlatif1 Aug 7, 2026 https://github.com/simstudioai/sim/pull/6379/commits/98ed8bc38fe64640ed6a8cec93ca70830aeec6a5
Clear filters https://github.com/simstudioai/sim/pull/6379/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6379/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6379/files
.../[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsxhttps://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
View file https://github.com/simstudioai/sim/blob/98ed8bc38fe64640ed6a8cec93ca70830aeec6a5/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6379/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
https://github.com/simstudioai/sim/pull/6379/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
Please reload this pagehttps://github.com/simstudioai/sim/pull/6379/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.