Title: fix(sidebar): keep the pin visible on the chat you're viewing by waleedlatif1 · Pull Request #6377 · simstudioai/sim · GitHub
Open Graph Title: fix(sidebar): keep the pin visible on the chat you're viewing by waleedlatif1 · Pull Request #6377 · simstudioai/sim
X Title: fix(sidebar): keep the pin visible on the chat you're viewing by waleedlatif1 · Pull Request #6377 · simstudioai/sim
Description: Summary Pinned chats lost their pin glyph the moment you opened them. The pin's guard carried a stale !isCurrentRoute term, copy-pasted from the status dot's guard back when the dot was also hidden on the current route — #4354 relaxed the dot's guard and left the pin's byte-identical. Derive showStatusDot once and express the pin as its negation, so the two conditions in that slot can't drift apart again. Collapsed rail never forwarded isCurrentRoute to ConversationListItem, so the chat you were already reading showed an unread dot there but not in the expanded sidebar. Same chat, same data, two answers. Pin now hides by the same transition-opacity mechanism the dot uses, instead of group-hover:hidden plus a mount guard. That asymmetry is what let the guards drift in the first place. Behavior The trailing 18px slot holds one glyph. Precedence is unchanged: status dot > pin, and the ... button covers both on hover. So a pinned chat that is currently generating still shows the yellow dot, and the pin returns once it settles — the dot is transient and time-sensitive, the pin is persistent and already implied by the row sorting to the top. Type of Change Bug fix Testing bun run type-check and biome check pass. Not verified in a browser — worth a visual pass on the hover/menu-open states, and on the pin's fade, which is new motion. Follow-ups (not in this PR) SidebarChatItem duplicates the dot that ConversationListItem already owns for two other call sites, including an identically-named showStatusDot const with a different formula. Folding them together means teaching the shared component about the stacked slot, absolute positioning, and the overlaid ... — too big for a 4-line fix. #EAB308 is a raw hex in exactly two files repo-wide (here and conversation-list-item.tsx); it wants a real token. The collapsed rail renders no pin at all. Feature gap rather than this bug — pinned chats already sort to the head of that list. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Pinned chats lost their pin glyph the moment you opened them. The pin's guard carried a stale !isCurrentRoute term, copy-pasted from the status dot's guard back when the dot was al...
X Description: Summary Pinned chats lost their pin glyph the moment you opened them. The pin's guard carried a stale !isCurrentRoute term, copy-pasted from the status dot's guard back when the do...
Opengraph URL: https://github.com/simstudioai/sim/pull/6377
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:638663c6-a805-3790-4ea1-0f2bdfc41b5f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3DE:23CE74:B357CC:F6A23B:6AFB5247 |
| html-safe-nonce | 2ef18043f0c40e627eac35425d7c8c491a2bbb333e0582aca745d113fb190b90 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0RFOjIzQ0U3NDpCMzU3Q0M6RjZBMjNCOjZBRkI1MjQ3IiwidmlzaXRvcl9pZCI6IjgwODQzMDU0NTg1ODk1NTMyMjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7f8167aa7f95e1cce6ae3b97fc67a0e8a949cffd03f5a6be7676606f3d1d2969 |
| hovercard-subject-tag | pull_request:4230342487 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6377/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Pinned chats lost their pin glyph the moment you opened them. The pin's guard carried a stale !isCurrentRoute term, copy-pasted from the status dot's guard back when the dot was al... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width