René's URL Explorer Experiment
Title: fix(files): render HTML files shared via a public file link by TheodoreSpeaks · Pull Request #6363 · simstudioai/sim · GitHub
Open Graph Title: fix(files): render HTML files shared via a public file link by TheodoreSpeaks · Pull Request #6363 · simstudioai/sim
X Title: fix(files): render HTML files shared via a public file link by TheodoreSpeaks · Pull Request #6363 · simstudioai/sim
Description: Summary
HTML files shared via /f/ rendered a blank area under the header. The page root (.desktop-title-bar-page) sets only min-height: 100vh, so h-full on every descendant of resolved to auto → 0. HtmlPreview only mounts its sandboxed iframe once its container measures non-zero, so it silently never mounted
Gave the public share page root a definite height (h-screen, overflow-hidden) so the whole /f/ surface behaves like the in-app viewer; the header's now-dead sticky becomes shrink-0
Made the read-only preview chain flex-based (min-h-0 flex-1) instead of h-full, so it fills its parent rather than depending on an ancestor's definite height — covers the HTML, CSV, SVG, and mermaid branches plus the plain-text and loading frames
text-editor's preview pane becomes a flex column — it's HtmlPreview's other parent, so flex-1 would have been inert there
Markdown, plain text, CSV, and image shares were unaffected before (their content has intrinsic height) and are unchanged after.
Type of Change
Bug fix
Testing
Tested manually against a real local public share, driven headless at 1280x800.
Before (patch reverted on disk), on /f/ for a text/html file:
main 1280x736 flex min-h-0 flex-1 flex-col
wrap 1280x0 h-full min-h-0 w-full overflow-auto
container 1280x0 h-full overflow-hidden
iframeCount: 0
After: wrap and container are 1280x736, iframeCount: 1, inline