René's URL Explorer Experiment


Title: fix(files): bound the HEIF fallback decode input by waleedlatif1 · Pull Request #6348 · simstudioai/sim · GitHub

Open Graph Title: fix(files): bound the HEIF fallback decode input by waleedlatif1 · Pull Request #6348 · simstudioai/sim

X Title: fix(files): bound the HEIF fallback decode input by waleedlatif1 · Pull Request #6348 · simstudioai/sim

Description: Summary Follow-up to #6346, which merged before this commit landed on the branch — the HEIF decoder went out without an input bound. Nothing upstream capped what could reach the WebAssembly decoder: uploads allow 100MB (validation.ts:15) and prepareImageForVision runs sharp with limitInputPixels: false. A tenant-controlled file could therefore spend unbounded CPU and memory on a single-threaded decode during one copilot read. transcodeHeicToJpeg now refuses input above a 20MB ceiling and returns null, which the existing "[Image unavailable]" path already handles. 20MB leaves generous headroom over any phone photo — a 12MP iPhone HEIC runs 1-4MB. Scope — what this does and does not cover Bounds file size. A large HEIF no longer reaches the decoder at all. Does not bound pixel count. A small file declaring enormous dimensions is a separate vector. It stays bounded by libheif's own security limits during parse, which are demonstrably active: the sharp attempt on a real iPhone HEIC fails with libheif's Security limit exceeded before any decode happens. No timeout or cancellation on the decode itself; the byte ceiling is what bounds its duration. Raised by Greptile on #6346 and worth disagreeing with if 20MB or the pixel-vector reasoning looks wrong. Type of Change Bug fix Testing Added a test asserting input above the ceiling returns null without invoking the decoder. 19 tests, typecheck clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6346, which merged before this commit landed on the branch — the HEIF decoder went out without an input bound. Nothing upstream capped what could reach the WebAssembly decoder...

X Description: Summary Follow-up to #6346, which merged before this commit landed on the branch — the HEIF decoder went out without an input bound. Nothing upstream capped what could reach the WebAssembly decoder...

Opengraph URL: https://github.com/simstudioai/sim/pull/6348

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:048b48a4-2d22-294d-a3e6-62e9741719b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB2A:71943:93651C:CFD503:6AFB507E
html-safe-nonce8d072b10fd36e81c7cc8d98420f0381a6e828d0cce5a95c312df1b01ae84d42a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjJBOjcxOTQzOjkzNjUxQzpDRkQ1MDM6NkFGQjUwN0UiLCJ2aXNpdG9yX2lkIjoiNzE0NzQ5NDI0ODYxNzMwMDA5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c0d08a71e2cde2a47d96919dcf32733a61f370f88ccbb958b6affe771512a4a
hovercard-subject-tagpull_request:4224345067
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6348/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6346, which merged before this commit landed on the branch — the HEIF decoder went out without an input bound. Nothing upstream capped what could reach the WebAssembly decoder...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6348/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6348%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6348%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6348/files
Reloadhttps://github.com/simstudioai/sim/pull/6348/files
Reloadhttps://github.com/simstudioai/sim/pull/6348/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/heic-transcode-input-ceilinghttps://github.com/simstudioai/sim/tree/fix/heic-transcode-input-ceiling
Conversation 3 https://github.com/simstudioai/sim/pull/6348
Commits 1 https://github.com/simstudioai/sim/pull/6348/commits
Checks 29 https://github.com/simstudioai/sim/pull/6348/checks
Files changed https://github.com/simstudioai/sim/pull/6348/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6348/files
fix(files): bound the HEIF fallback decode input https://github.com/simstudioai/sim/pull/6348/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6348/files
bc6d949 fix(files): bound the HEIF fallback decode input waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6348/commits/bc6d949f6b3af54cc16816a4b8b2fab97cddf81b
Clear filters https://github.com/simstudioai/sim/pull/6348/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6348/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6348/files
heic.test.ts https://github.com/simstudioai/sim/pull/6348/files#diff-a31fedbaf2f023abeae6990c30e6fdfc18f0178a53670e425e9eb9f05b7759df
heic.ts https://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
apps/sim/lib/uploads/server/heic.test.tshttps://github.com/simstudioai/sim/pull/6348/files#diff-a31fedbaf2f023abeae6990c30e6fdfc18f0178a53670e425e9eb9f05b7759df
View file https://github.com/simstudioai/sim/blob/bc6d949f6b3af54cc16816a4b8b2fab97cddf81b/apps/sim/lib/uploads/server/heic.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6348/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6348/files#diff-a31fedbaf2f023abeae6990c30e6fdfc18f0178a53670e425e9eb9f05b7759df
https://github.com/simstudioai/sim/pull/6348/files#diff-a31fedbaf2f023abeae6990c30e6fdfc18f0178a53670e425e9eb9f05b7759df
apps/sim/lib/uploads/server/heic.tshttps://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
View file https://github.com/simstudioai/sim/blob/bc6d949f6b3af54cc16816a4b8b2fab97cddf81b/apps/sim/lib/uploads/server/heic.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6348/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
https://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
https://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
https://github.com/simstudioai/sim/pull/6348/files#diff-96e4d84defe31b86dc5e215bc3ad22c94a53285895473f8f90d9b2a8f1a89a58
Please reload this pagehttps://github.com/simstudioai/sim/pull/6348/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.