René's URL Explorer Experiment


Title: fix(logger): stop a server-side jsdom window from silencing all logging in production by waleedlatif1 · Pull Request #6339 · simstudioai/sim · GitHub

Open Graph Title: fix(logger): stop a server-side jsdom window from silencing all logging in production by waleedlatif1 · Pull Request #6339 · simstudioai/sim

X Title: fix(logger): stop a server-side jsdom window from silencing all logging in production by waleedlatif1 · Pull Request #6339 · simstudioai/sim

Description: Summary shouldLog() treated typeof window !== 'undefined' as "we are in a browser" and, in production, returned false for every level — permanently, process-wide, with no diagnostic ensureDomForTipTap() (apps/sim/lib/collab-doc/converter.ts:68) assigns globalThis.window = jsdomWindow so TipTap can run headless. The first collab-markdown request a task serves therefore kills that task's structured logging for the rest of its life jsdom is a production dependency and next.config.ts explicitly traces it into the standalone output for /api/internal/file-doc/{seed,merge,persist}, so this is live in prod. This is the only non-test window assignment in the repo Fixed by testing for a real browser instead: Node always exposes process.versions.node, a browser never does. The original intent — suppress logging in the browser in production — is preserved Evidence This is the cause of the recurring multi-hour structured-logging blackouts: Structured logs went from ~30k/30min to exactly zero while all five ECS tasks kept emitting 400–1,100 raw lines/30min — the processes were alive and console.* worked; only @sim/logger was silent Tasks went dark staggered, one at a time over ~15 minutes — the signature of a per-process latch, not a global event It self-recovered only when five brand-new task IDs appeared (a deploy). A restart cannot fix bad log data; it does clear a latched global Task a5989f51 served file-doc traffic at 15:00 and went dark at 15:08 Type of Change Bug fix Testing Two regression tests, both directions: should keep logging when the server installs a DOM — red before the fix, green after should stay silent in a real browser — passes both before and after, proving the guard's original behavior is intact and this is not simply removing it 27/27 passing. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary shouldLog() treated typeof window !== 'undefined' as "we are in a browser" and, in production, returned false for every level — permanently, process-wide, with no diagnos...

X Description: Summary shouldLog() treated typeof window !== 'undefined' as "we are in a browser" and, in production, returned false for every level — permanently, process-wide,...

Opengraph URL: https://github.com/simstudioai/sim/pull/6339

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d77f3be6-2478-ee8f-cb3a-8bb82413d96d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE94:8CC91:2E01BE:3EEFDF:6AFB52D4
html-safe-nonce7a75e0989518a1c99462a84bd215d070714985b82aaf9c0c9572ea640a7a845b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTk0OjhDQzkxOjJFMDFCRTozRUVGREY6NkFGQjUyRDQiLCJ2aXNpdG9yX2lkIjoiNDA1Mzc5MzkyMzM2NzkxNjI0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac08f5b71f10e5c903ce5ad627a862ab875d5c737a5f04e99c112c1f4c99aa0276
hovercard-subject-tagpull_request:4223610301
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6339/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary shouldLog() treated typeof window !== 'undefined' as "we are in a browser" and, in production, returned false for every level — permanently, process-wide, with no diagnos...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6339/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6339%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6339%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6339/files
Reloadhttps://github.com/simstudioai/sim/pull/6339/files
Reloadhttps://github.com/simstudioai/sim/pull/6339/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/logger-jsdom-window-kill-switchhttps://github.com/simstudioai/sim/tree/fix/logger-jsdom-window-kill-switch
Conversation 6 https://github.com/simstudioai/sim/pull/6339
Commits 2 https://github.com/simstudioai/sim/pull/6339/commits
Checks 4 https://github.com/simstudioai/sim/pull/6339/checks
Files changed https://github.com/simstudioai/sim/pull/6339/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6339/files
fix(logger): stop a server-side jsdom window from silencing all logging in production https://github.com/simstudioai/sim/pull/6339/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6339/files
a6cd918 fix(logger): stop a server-side jsdom window from silencing all loggi… waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6339/commits/a6cd91887fb0fcad5449456c3c18999811ae17d9
05c305c fix(logger): widen the stubbed process cast so type-check passes waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6339/commits/05c305c0bf40a99647018294ef308e06b50dc8b2
Clear filters https://github.com/simstudioai/sim/pull/6339/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6339/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6339/files
index.test.ts https://github.com/simstudioai/sim/pull/6339/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
index.ts https://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
packages/logger/src/index.test.tshttps://github.com/simstudioai/sim/pull/6339/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
View file https://github.com/simstudioai/sim/blob/05c305c0bf40a99647018294ef308e06b50dc8b2/packages/logger/src/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6339/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6339/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
https://github.com/simstudioai/sim/pull/6339/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
packages/logger/src/index.tshttps://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
View file https://github.com/simstudioai/sim/blob/05c305c0bf40a99647018294ef308e06b50dc8b2/packages/logger/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6339/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6339/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.