René's URL Explorer Experiment


Title: fix(uploads): drop the stray 'use server' directive that enables Server Actions app-wide by waleedlatif1 · Pull Request #6335 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): drop the stray 'use server' directive that enables Server Actions app-wide by waleedlatif1 · Pull Request #6335 · simstudioai/sim

X Title: fix(uploads): drop the stray 'use server' directive that enables Server Actions app-wide by waleedlatif1 · Pull Request #6335 · simstudioai/sim

Description: Problem Any unauthenticated POST with Content-Type: multipart/form-data to any App Router path returns HTTP 500. Next decides a request is a Server Action from headers alone — next/dist/server/app-render/server-action-request-meta.js:36, no body inspection, no auth. The fetch-style action path returns a graceful 404, but the non-fetch multipart path does a bare throw (action-handler.js:589,743) that becomes a 500. Next has an escape hatch at action-handler.js:412: when hasServerActions() is false it returns 404 early and none of this runs. Sim had exactly one 'use server' file — apps/sim/lib/uploads/utils/file-utils.server.ts — and it was the sole reason that flag was true. Availability impact ~180 requests (60/min for 3 min from a single IP) is enough to drive the ALB 5xx alarm ...-alb-high-error-percentage (>5% for 3 consecutive 60s periods) and page on-call. It fired today at 17:22:16Z. This is an unauthenticated, zero-cost DoS against the alerting path. Auth-surface impact 'use server' also published every export of that module as a remotely invocable endpoint with no auth wrapper: downloadFileFromUrl, resolveInternalFileUrl, downloadFileFromStorage, downloadServableFileFromStorage, resolveFileInputToUrl. Several take a caller-supplied URL and fetch it — SSRF-shaped. Exploitability was not confirmed (Next's action IDs are build-derived and hard to guess), but the surface should not exist at all. Removing the directive removes it. Fix Delete the directive. Nothing ever invoked these as Server Actions. server-only was considered and rejected: it is not currently a dependency, is used nowhere in the repo, and the .server.ts suffix already carries the server-only convention here. Adding a dependency for a one-line deletion is not the minimal fix. Verification Only 'use server' in the repo (rg over apps/ + packages/): 1 hit, this file. Zero 'use client' importers: all ~77 importers are route handlers, executor code, and other .server.ts modules. No useActionState/useFormState/

anywhere. Actions manifest — the load-bearing check. .next/server/server-reference-manifest.json: node actions edge actions before 5 0 after 0 0 After: {"node":{},"edge":{},"encryptionKey":"..."} — hasServerActions() is now false, so Next takes the early-404 path and the multipart 500 is gone. (Both builds compiled successfully and then failed identically at page-data collection on Missing DATABASE_URL — a local-env limitation, unrelated to this change and present on both sides. The manifest is written at compile time, so the evidence is valid.) Regression guard scripts/check-client-boundary-imports.ts (already wired into CI as bun run check:client-boundary) now also fails on any 'use server' directive — module prologue or inline in a function body — across apps/ and packages/. Directive detection was factored into a shared leadingDirective() helper rather than duplicated. Confirmed the guard fails without the fix: ✗ 1 'use server' directive(s) found. apps/sim/lib/uploads/utils/file-utils.server.ts:1 and passes with it. Checks bunx tsc --noEmit -p tsconfig.json — clean bun run lint — 23/23 tasks pass bunx vitest run lib/uploads/ providers/file-attachments.server.test.ts executor/utils/file-tool-processor.test.ts lib/execution/payloads/materialization.server.test.ts — 315 passed / 30 files bun run check:client-boundary — passes Not verified SSRF exploitability of the exposed action endpoints (surface removed regardless). No live reproduction of the 500 against a deployed environment; the causal chain is established from the Next source, the manifest delta, and the alarm timing.

Open Graph Description: Problem Any unauthenticated POST with Content-Type: multipart/form-data to any App Router path returns HTTP 500. Next decides a request is a Server Action from headers alone — next/dist/server/app-...

X Description: Problem Any unauthenticated POST with Content-Type: multipart/form-data to any App Router path returns HTTP 500. Next decides a request is a Server Action from headers alone — next/dist/server/app-...

Opengraph URL: https://github.com/simstudioai/sim/pull/6335

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:55f89733-e737-b51c-397a-caaeb7de129a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE372:2F2AB3:C57B2E:10FC6B0:6AFB56BD
html-safe-nonce2f654bcffb86c9145954119aa9c3876e28fbe4c197ef8fd9ba88d68cf0b89bd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzcyOjJGMkFCMzpDNTdCMkU6MTBGQzZCMDo2QUZCNTZCRCIsInZpc2l0b3JfaWQiOiI0NzM5MzAyOTE2MDY0MjM3MjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac143c5c2c5fa22aedcee7702db30e3f8bdaca04d183dbae4f44be4c42bbb41c0f
hovercard-subject-tagpull_request:4223286629
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6335/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altProblem Any unauthenticated POST with Content-Type: multipart/form-data to any App Router path returns HTTP 500. Next decides a request is a Server Action from headers alone — next/dist/server/app-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6335/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6335%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6335%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6335/files
Reloadhttps://github.com/simstudioai/sim/pull/6335/files
Reloadhttps://github.com/simstudioai/sim/pull/6335/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/remove-use-server-directivehttps://github.com/simstudioai/sim/tree/fix/remove-use-server-directive
Conversation 10 https://github.com/simstudioai/sim/pull/6335
Commits 2 https://github.com/simstudioai/sim/pull/6335/commits
Checks 28 https://github.com/simstudioai/sim/pull/6335/checks
Files changed https://github.com/simstudioai/sim/pull/6335/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6335/files
fix(uploads): drop the stray 'use server' directive that enables Server Actions app-wide https://github.com/simstudioai/sim/pull/6335/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6335/files
1250943 fix(uploads): drop the stray 'use server' directive that enables Serv… waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6335/commits/1250943537b06800a20f9bfae767ca0ce6fe57b4
c39ddeb fix(scripts): match boundary directives that carry a trailing comment waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6335/commits/c39ddeb99aa5ffca56ce0e8807f47124ec53a281
Clear filters https://github.com/simstudioai/sim/pull/6335/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6335/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6335/files
file-utils.server.ts https://github.com/simstudioai/sim/pull/6335/files#diff-56073f04957682936465d04d9660e33d45b8f6151b8ce0947b9cfd6ad3e3533e
check-client-boundary-imports.ts https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
apps/sim/lib/uploads/utils/file-utils.server.tshttps://github.com/simstudioai/sim/pull/6335/files#diff-56073f04957682936465d04d9660e33d45b8f6151b8ce0947b9cfd6ad3e3533e
View file https://github.com/simstudioai/sim/blob/c39ddeb99aa5ffca56ce0e8807f47124ec53a281/apps/sim/lib/uploads/utils/file-utils.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6335/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6335/files#diff-56073f04957682936465d04d9660e33d45b8f6151b8ce0947b9cfd6ad3e3533e
scripts/check-client-boundary-imports.tshttps://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
View file https://github.com/simstudioai/sim/blob/c39ddeb99aa5ffca56ce0e8807f47124ec53a281/scripts/check-client-boundary-imports.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6335/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
https://github.com/simstudioai/sim/pull/6335/files#diff-7797e82b5655773dd954c596b1695f00d08424b6a36e936eceaadd7e66da0b1d
Please reload this pagehttps://github.com/simstudioai/sim/pull/6335/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.