René's URL Explorer Experiment


Title: fix(billing): stop the false unbilled-charge error on zero-cost runs by waleedlatif1 · Pull Request #6333 · simstudioai/sim · GitHub

Open Graph Title: fix(billing): stop the false unbilled-charge error on zero-cost runs by waleedlatif1 · Pull Request #6333 · simstudioai/sim

X Title: fix(billing): stop the false unbilled-charge error on zero-cost runs by waleedlatif1 · Pull Request #6333 · simstudioai/sim

Description: Problem Every usage-gated (blocked) execution emitted an ERROR-level log: Failed to record execution usage to usage_log ledger; charge may be unbilled This is a 100% false positive on that path. It claims possible revenue loss on runs that never executed and have zero cost — exactly the line an engineer pages on. It misdirected a production investigation for hours. Across 5 days / 683 occurrences, sum(totalCost) = 0 and max(totalCost) = 0. Mechanism (verified) apps/sim/lib/execution/preprocessing.ts logPreprocessingError calls session.safeCompleteWithError({ skipCost: true }) and passes no billingAttribution. skipCost: true makes logging-session.ts build an all-zero costSummary (no base charge, no models, no charges). logger.ts recordExecutionUsage required a billing context before building targets[]: if (workflowRecord.workspaceId && !billingContext) { throw new Error('Billing attribution is required for workspace execution usage') } The throw was caught by the surrounding catch, which logs the unbilled-charge ERROR — even though targets[] would have been empty and recordUsage would never have been called. Fix Move the existing if (targets.length === 0) return 0 early return above the attribution requirement. Pure reordering — no new predicate. No charge can be lost by this change. When targets.length === 0 there is nothing to insert into usage_log: both the old path (throw → catch → log → return 0) and the new path (return 0) record exactly zero. The only difference is the spurious ERROR. Every path with a non-zero target still requires billingContext and still throws when it is missing. Genuine under-billing still alerts The ERROR log is not silenced. Any real ledger failure — a recordUsage insert failure, a transaction/advisory-lock failure, or missing billing attribution on a run that does have cost — still reaches the same catch and still logs at ERROR with the full costSummary. Alerting on this line remains valid; it is now specific. Tests a structurally zero-cost run without billing context logs no unbilled-charge error — fails without the fix (1 spurious ERROR call). a genuine ledger write failure still logs the unbilled-charge error — regression guard; fails if anyone downgrades or removes the ERROR (verified by temporarily switching it to warn). The file's @sim/logger mock is overridden locally so withMetadata() children share one spy set, making log level assertable. Verification bunx vitest run lib/logs/execution/logger.test.ts lib/logs/execution/logging-session.test.ts — 98 passed bunx tsc --noEmit -p apps/sim/tsconfig.json — clean bun run lint — clean

Open Graph Description: Problem Every usage-gated (blocked) execution emitted an ERROR-level log: Failed to record execution usage to usage_log ledger; charge may be unbilled This is a 100% false positive on that path. ...

X Description: Problem Every usage-gated (blocked) execution emitted an ERROR-level log: Failed to record execution usage to usage_log ledger; charge may be unbilled This is a 100% false positive on that path. ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6333

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d67dac20-ed53-93b9-61cf-36e1ef08a4cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC438:1EFDE9:B09B1C:F29080:6AFB521D
html-safe-noncebf20a21f90ac4ddc638b45facb9039913d81b02ab04085229e34c524933e28d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDM4OjFFRkRFOTpCMDlCMUM6RjI5MDgwOjZBRkI1MjFEIiwidmlzaXRvcl9pZCI6IjE1MjQ2NzIyNTg5NzMwNjE2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac50b92f8994a535042e3ccbb4e4be57b1d8b47287168c6ad7287b99a779c6b8eb
hovercard-subject-tagpull_request:4223273146
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6333/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altProblem Every usage-gated (blocked) execution emitted an ERROR-level log: Failed to record execution usage to usage_log ledger; charge may be unbilled This is a 100% false positive on that path. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6333/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6333%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6333%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6333/files
Reloadhttps://github.com/simstudioai/sim/pull/6333/files
Reloadhttps://github.com/simstudioai/sim/pull/6333/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/usage-ledger-false-unbilled-errorhttps://github.com/simstudioai/sim/tree/fix/usage-ledger-false-unbilled-error
Conversation 3 https://github.com/simstudioai/sim/pull/6333
Commits 1 https://github.com/simstudioai/sim/pull/6333/commits
Checks 4 https://github.com/simstudioai/sim/pull/6333/checks
Files changed https://github.com/simstudioai/sim/pull/6333/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6333/files
fix(billing): stop the false unbilled-charge error on zero-cost runs https://github.com/simstudioai/sim/pull/6333/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6333/files
5235a4d fix(billing): stop the false unbilled-charge error on zero-cost runs waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6333/commits/5235a4d90b50d35f4cebe8082226d83b540a9eee
Clear filters https://github.com/simstudioai/sim/pull/6333/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6333/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6333/files
logger.test.ts https://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
logger.ts https://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
apps/sim/lib/logs/execution/logger.test.tshttps://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
View file https://github.com/simstudioai/sim/blob/5235a4d90b50d35f4cebe8082226d83b540a9eee/apps/sim/lib/logs/execution/logger.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6333/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/6333/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
apps/sim/lib/logs/execution/logger.tshttps://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
View file https://github.com/simstudioai/sim/blob/5235a4d90b50d35f4cebe8082226d83b540a9eee/apps/sim/lib/logs/execution/logger.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6333/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
https://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
https://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
https://github.com/simstudioai/sim/pull/6333/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.