René's URL Explorer Experiment


Title: fix(logger): never let structured serialization throw into the caller by waleedlatif1 · Pull Request #6331 · simstudioai/sim · GitHub

Open Graph Title: fix(logger): never let structured serialization throw into the caller by waleedlatif1 · Pull Request #6331 · simstudioai/sim

X Title: fix(logger): never let structured serialization throw into the caller by waleedlatif1 · Pull Request #6331 · simstudioai/sim

Description: Context Production structured logging went fully silent for hours across all five sim-production-us-east-1-app ECS tasks — INFO/WARN/ERROR all dropped to zero per 30 min, and a raw substring search for \"module\": returned nothing. Confirmed as genuine loss via AWS/Logs IncomingLogEvents (~25k → ~2-6k per 30 min), not a query artifact. Non-JSON output (Next.js internals, Better Auth, raw stack traces) kept shipping, and the socket service on the same cluster and same awslogs driver was unaffected — so it was localized to the app containers' own output, not the driver or the account. This PR fixes one concrete, reproducible defect on that path. It is not claimed to be the whole root cause. The bug In the production JSON branch, Logger.log merged caller-supplied arguments into the entry with Object.assign and then called JSON.stringify, with no error handling on either step. If that metadata contained a cyclic reference, a BigInt, or a throwing getter, the call raised a TypeError out of logger.info(...) into the caller — the line was lost and whatever was being logged about was aborted. Verified against the current staging logger under NODE_ENV=production: RESULT: circular -> THREW: TypeError | JSON.stringify cannot serialize cyclic structures. RESULT: bigint -> THREW: TypeError | JSON.stringify cannot serialize BigInt. Cyclic metadata is easy to hit unintentionally — errors carrying request/response/cause chains, ORM rows with back-references, socket handles. The development path was never affected: the colorized branch routes objects through formatObject, which already has a try/catch. So this class of bug is invisible locally and only appears in production, where its signature is exactly structured logs vanish while raw stack traces keep shipping. The fix Entry construction and serialization now go through serializeEntry, which degrades instead of throwing: normal JSON.stringify retry with a replacer that tolerates cycles ([Circular]) and BigInt (stringified) minimal entry preserving timestamp/level/module/message, flagged serializationError: true A logger must never be able to break its caller. Tests Three regression tests in packages/logger/src/index.test.ts covering cyclic, BigInt, and throwing-getter metadata. All three were confirmed to fail against the unfixed source (git stash on index.ts → 3 failed | 25 passed) and pass with it (28 passed). bun run lint and tsc --noEmit are clean. Follow-ups (not in this repo) Alarms and ECS task definitions live in the private sibling CDK repo, not here. Two gaps found there and reported separately: No alarm exists on AWS/Logs IncomingLogEvents for the app log group. Every metric filter over that group sees zero matches during a blackout and sits in OK — a silent alarm indistinguishable from healthy. A log-absence alarm with treatMissingData: BREACHING is specified in the report. Both app and socket LogDrivers.awsLogs({ ... }) calls omit mode, so both default to blocking.

Open Graph Description: Context Production structured logging went fully silent for hours across all five sim-production-us-east-1-app ECS tasks — INFO/WARN/ERROR all dropped to zero per 30 min, and a raw substring search...

X Description: Context Production structured logging went fully silent for hours across all five sim-production-us-east-1-app ECS tasks — INFO/WARN/ERROR all dropped to zero per 30 min, and a raw substring search...

Opengraph URL: https://github.com/simstudioai/sim/pull/6331

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17a1ee29-efeb-4eae-5aea-5a71857f8ead
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBE4:C4B81:99FCA4:D4A1D3:6AFB4DFB
html-safe-nonceab86030c84e35e4edb0bc0a043554d85d7f488227c1be1e9042b7128f614f86d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkU0OkM0QjgxOjk5RkNBNDpENEExRDM6NkFGQjRERkIiLCJ2aXNpdG9yX2lkIjoiNDM0NjAyMTg5NjE2NDk1MzU5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac39fc5010aa361c41f25d9ff9bea8a6e948ab54f11c8f996cd2c47291ab29f3a0
hovercard-subject-tagpull_request:4223263426
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6331/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altContext Production structured logging went fully silent for hours across all five sim-production-us-east-1-app ECS tasks — INFO/WARN/ERROR all dropped to zero per 30 min, and a raw substring search...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6331/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6331%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6331%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6331/files
Reloadhttps://github.com/simstudioai/sim/pull/6331/files
Reloadhttps://github.com/simstudioai/sim/pull/6331/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/logger-safe-json-serializationhttps://github.com/simstudioai/sim/tree/fix/logger-safe-json-serialization
Conversation 15 https://github.com/simstudioai/sim/pull/6331
Commits 4 https://github.com/simstudioai/sim/pull/6331/commits
Checks 27 https://github.com/simstudioai/sim/pull/6331/checks
Files changed https://github.com/simstudioai/sim/pull/6331/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6331/files
fix(logger): never let structured serialization throw into the caller https://github.com/simstudioai/sim/pull/6331/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/6331/files
80f46c4 fix(logger): never let structured serialization throw into the caller waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6331/commits/80f46c418fa2ef2854902240f8048f616a1268c4
3b3e5a1 fix(logger): keep hostile child metadata from throwing into the caller waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6331/commits/3b3e5a1685e699fc2d8337b33758d61fa63cefff
aea66d0 fix(logger): keep a throwing toJSON from escaping the final fallback waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6331/commits/aea66d0432dbee9d1835998579c97607971585e2
8d5863e fix(logger): keep repeated references out of the circular-reference f… waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6331/commits/8d5863e70cd639e1a1d84c22e5d21d0aacc1ac11
Clear filters https://github.com/simstudioai/sim/pull/6331/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6331/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6331/files
index.test.ts https://github.com/simstudioai/sim/pull/6331/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
index.ts https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
packages/logger/src/index.test.tshttps://github.com/simstudioai/sim/pull/6331/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
View file https://github.com/simstudioai/sim/blob/8d5863e70cd639e1a1d84c22e5d21d0aacc1ac11/packages/logger/src/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6331/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6331/files#diff-77afe35db02ed4a3b948b79b41c5de9f96366ffdd050a5a4ac2bec8aaaa9017a
packages/logger/src/index.tshttps://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
View file https://github.com/simstudioai/sim/blob/8d5863e70cd639e1a1d84c22e5d21d0aacc1ac11/packages/logger/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6331/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
Please reload this pagehttps://github.com/simstudioai/sim/pull/6331/files
https://github.com/simstudioai/sim/pull/6331/files#diff-28fa80c3ade4a6f73b01125812c6da6d545508404cea375af71fac932fd5595a
Please reload this pagehttps://github.com/simstudioai/sim/pull/6331/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.