René's URL Explorer Experiment


Title: fix(sso): re-grant provider trust when an already-verified domain is re-submitted by waleedlatif1 · Pull Request #6320 · simstudioai/sim · GitHub

Open Graph Title: fix(sso): re-grant provider trust when an already-verified domain is re-submitted by waleedlatif1 · Pull Request #6320 · simstudioai/sim

X Title: fix(sso): re-grant provider trust when an already-verified domain is re-submitted by waleedlatif1 · Pull Request #6320 · simstudioai/sim

Description: Summary Re-submitting an already-verified domain now re-grants domainVerified to the providers that proof covers, instead of returning success having done nothing Extracted the provider-match expression into one providersOnDomain helper shared by both grant paths, so it can't drift from the revocation on delete Follow-up to #6311. A provider can hold a verified domain while its own trust flag is off: an SSO update whose trust grant is refused reverts the config and clears the flag. The verify route's idempotent branch previously short-circuited to a 200 without touching providers, so re-running verification — the obvious recovery — converged nothing. The proof is present in that branch, which is exactly what authorizes the grant. Scope note: this is an API-level correctness fix, not a UX change. The Verify control only renders for pending domains, so this branch is not reachable from the settings UI; the user-facing recovery for a stuck provider remains re-saving the SSO form. No UI is touched by this PR. Type of Change Bug fix Testing bunx vitest run app/api/organizations — 67 passed. The new test was verified to fail without the fix (removing the re-grant turns it red). Typecheck, lint, and check:api-validation all clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Re-submitting an already-verified domain now re-grants domainVerified to the providers that proof covers, instead of returning success having done nothing Extracted the provider-match expr...

X Description: Summary Re-submitting an already-verified domain now re-grants domainVerified to the providers that proof covers, instead of returning success having done nothing Extracted the provider-match expr...

Opengraph URL: https://github.com/simstudioai/sim/pull/6320

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7b77fde4-4d83-d5c9-042d-4aeb22bc34c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC496:1C8E04:A5BD82:E409E8:6AFB50BB
html-safe-nonce65de1df353e90893e10fc9089a3776050be3a48deb43ffcfc9fc537f3639ea0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDk2OjFDOEUwNDpBNUJEODI6RTQwOUU4OjZBRkI1MEJCIiwidmlzaXRvcl9pZCI6IjE0ODM2NjU4OTU1MDU3NDQwNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace21908e8142c5650f9b58e33669a5a53dc182451886f0c686213afe0cb27c446
hovercard-subject-tagpull_request:4219150586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6320/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Re-submitting an already-verified domain now re-grants domainVerified to the providers that proof covers, instead of returning success having done nothing Extracted the provider-match expr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6320/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6320%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6320%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6320/files
Reloadhttps://github.com/simstudioai/sim/pull/6320/files
Reloadhttps://github.com/simstudioai/sim/pull/6320/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
sso-verify-regranthttps://github.com/simstudioai/sim/tree/sso-verify-regrant
Conversation 13 https://github.com/simstudioai/sim/pull/6320
Commits 4 https://github.com/simstudioai/sim/pull/6320/commits
Checks 28 https://github.com/simstudioai/sim/pull/6320/checks
Files changed https://github.com/simstudioai/sim/pull/6320/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
fix(sso): re-grant provider trust when an already-verified domain is re-submitted https://github.com/simstudioai/sim/pull/6320/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/6320/files
775b120 fix(sso): re-grant provider trust when an already-verified domain is … waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6320/commits/775b120ad5336b4c82319d51dd6b8985acb81f82
97161ec fix(sso): distinguish a failed DNS lookup from a missing record, and … waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6320/commits/97161ec1653b32da42a8bf6287511a6e1010fd2f
f5a3de6 chore(sso): tighten the re-grant rationale comment waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6320/commits/f5a3de6b6a104b8328ccfddb0d0691f4c6c1fcfd
45ec9a8 fix(sso): state what a failed DNS lookup tells us instead of assignin… waleedlatif1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6320/commits/45ec9a825321d122fbf9c54d6f8147601a1d8e99
Clear filters https://github.com/simstudioai/sim/pull/6320/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
route.test.ts https://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
route.ts https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
verified-domains-section.tsx https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
domain-verification.test.ts https://github.com/simstudioai/sim/pull/6320/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
domain-verification.ts https://github.com/simstudioai/sim/pull/6320/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
apps/sim/app/api/organizations/[id]/domains/[domainId]/verify/route.test.tshttps://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
View file https://github.com/simstudioai/sim/blob/45ec9a825321d122fbf9c54d6f8147601a1d8e99/apps/sim/app/api/organizations/%5Bid%5D/domains/%5BdomainId%5D/verify/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6320/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
https://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
https://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
https://github.com/simstudioai/sim/pull/6320/files#diff-05a9b4d35fbae9639578a050f1d82c44bdb9f3c9399c2bd78b1a733ccb8469f9
apps/sim/app/api/organizations/[id]/domains/[domainId]/verify/route.tshttps://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
View file https://github.com/simstudioai/sim/blob/45ec9a825321d122fbf9c54d6f8147601a1d8e99/apps/sim/app/api/organizations/%5Bid%5D/domains/%5BdomainId%5D/verify/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6320/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
cursorhttps://github.com/apps/cursor
Aug 6, 2026https://github.com/simstudioai/sim/pull/6320/files#r3727170987
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjE0M2Y2N2U1LTA5YzItNDZkOS1hZmEyLTMxNTllMDA5MDYyNCIsImVuY3J5cHRpb25LZXkiOiJXbTJJZ1ZpaXNKMGxrbjZvWmFwU2NxZ0lDeUpqbUI2RGdaUjhhQTJVSkdFIiwiYnJhbmNoIjoic3NvLXZlcmlmeS1yZWdyYW50IiwicmVwb093bmVyIjoic2ltc3R1ZGlvYWkiLCJyZXBvTmFtZSI6InNpbSIsInByb3ZpZGVyIjoiZ2l0aHViIn19
https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjE0M2Y2N2U1LTA5YzItNDZkOS1hZmEyLTMxNTllMDA5MDYyNCIsImVuY3J5cHRpb25LZXkiOiJXbTJJZ1ZpaXNKMGxrbjZvWmFwU2NxZ0lDeUpqbUI2RGdaUjhhQTJVSkdFIiwiYnJhbmNoIjoic3NvLXZlcmlmeS1yZWdyYW50IiwicmVwb093bmVyIjoic2ltc3R1ZGlvYWkiLCJyZXBvTmFtZSI6InNpbSIsInByTnVtYmVyIjo2MzIwLCJjb21taXRTaGEiOiJmNWEzZGU2YjZhMTA0YjgzMjhjY2ZkZGIwZDA2OTFmNGM2YzFmY2ZkIiwicHJvdmlkZXIiOiJnaXRodWIifX0
Cursor Bugbothttps://cursor.com/bugbot
f5a3de6https://github.com/simstudioai/sim/commit/f5a3de6b6a104b8328ccfddb0d0691f4c6c1fcfd
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
https://github.com/simstudioai/sim/pull/6320/files#diff-29df4ea82eab18d3f740874a6993479f27e5d36b9cb3fc1cf08db485f0e3fbb0
apps/sim/ee/sso/components/verified-domains-section.tsxhttps://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
View file https://github.com/simstudioai/sim/blob/45ec9a825321d122fbf9c54d6f8147601a1d8e99/apps/sim/ee/sso/components/verified-domains-section.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6320/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
https://github.com/simstudioai/sim/pull/6320/files#diff-a12831066127985116f59f7c789f4b7349cd0e79141173031dc4f44c4e660afb
apps/sim/lib/auth/sso/domain-verification.test.tshttps://github.com/simstudioai/sim/pull/6320/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
View file https://github.com/simstudioai/sim/blob/45ec9a825321d122fbf9c54d6f8147601a1d8e99/apps/sim/lib/auth/sso/domain-verification.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6320/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6320/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
https://github.com/simstudioai/sim/pull/6320/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
apps/sim/lib/auth/sso/domain-verification.tshttps://github.com/simstudioai/sim/pull/6320/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
View file https://github.com/simstudioai/sim/blob/45ec9a825321d122fbf9c54d6f8147601a1d8e99/apps/sim/lib/auth/sso/domain-verification.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6320/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6320/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
https://github.com/simstudioai/sim/pull/6320/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
Please reload this pagehttps://github.com/simstudioai/sim/pull/6320/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.