René's URL Explorer Experiment


Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim · GitHub

Open Graph Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim

X Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim

Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A single operation can carry several KB of block state (an agent block with a large system prompt, for example), so active editing across a few workflows lets the persisted history grow to multiple megabytes and consume most of the origin's shared ~5 MB budget. Once that budget is exhausted, the next setItem from any other persisted Zustand store throws QuotaExceededError. That is why the error surfaces from unrelated stores such as notification-storage or panel-editor-state — whichever one happens to write next is the victim, not the culprit. The existing safeStorageAdapter catches QuotaExceededError on this store's own writes, but that only stops this store from throwing. It does nothing to stop it from starving its siblings, which is the failure users actually see. Fix Cap the serialized footprint of the persisted state and trim inside partialize: MAX_PERSISTED_BYTES (2 MB) bounds what gets written to storage. trimPersistedStateToBudget() evicts the oldest operations by createdAt across all stacks until the payload fits, and drops any stack left empty to reclaim its overhead. Eviction runs in two passes: a bulk pass that subtracts each entry's own serialized length (avoiding an O(n^2) re-serialization of megabytes on every drop), then an exact verification pass that keeps dropping the oldest survivors until the invariant actually holds. In practice the second pass runs zero or one times. The input state is never mutated. Only the persisted copy is trimmed. On the 2 MB figure: it is a deliberately conservative share of the ~5 MB origin budget, chosen to leave roughly 3 MB for every other persisted store, rather than a measured optimum. It is a single exported constant and easy to tune if you would prefer a different split. Behavior change worth calling out: because only the persisted copy is trimmed, the in-memory history is untouched and the current session remains fully undoable. A user who reloads will find that older undo history beyond the budget is gone. That seemed clearly better than truncating history someone is actively using, but it is a real change and I would rather surface it than have it discovered later. Tests Six new tests in stores/undo-redo/store.test.ts: Reproduction: heavy editing with large block snapshots keeps the persisted payload within a sane byte budget. Recent history stays usable after trimming (newest operations survive). trimPersistedStateToBudget returns state unchanged when already within budget. Evicts oldest-first across stacks until under budget. Does not mutate the input state. Drops stacks emptied by eviction. vitest run stores/undo-redo/store.test.ts — 45/45 pass (39 existing, unchanged). biome check clean. Typecheck note: a full-repo tsc --noEmit exhausts the heap on my machine, so I typechecked the two changed files and their transitive imports in isolation, which passes cleanly. I have not verified a full-repo typecheck locally. Fixes #4737

Open Graph Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si...

X Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si...

Opengraph URL: https://github.com/simstudioai/sim/pull/6313

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8986b7e-a05a-25fb-24a5-34ac074b7a15
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB124:CEB06:AC2EE3:F2518E:6AFB79B9
html-safe-noncecc48cb5b75a7cd223e173ba9220c474f2fc0d7e3e1a45e677bebc3c3ce08e375
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTI0OkNFQjA2OkFDMkVFMzpGMjUxOEU6NkFGQjc5QjkiLCJ2aXNpdG9yX2lkIjoiNjgwMDAwMDgxODQ5ODczMDQyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50c63ee645c4a733bddbd7a62b89a4aad4f6d4fcee1a4b22dc308c81e202cbe9
hovercard-subject-tagpull_request:4218169635
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6313/files
twitter:imagehttps://avatars.githubusercontent.com/u/50651418?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50651418?s=400&v=4
og:image:altRoot cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6313/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6313%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6313%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6313/files
Reloadhttps://github.com/simstudioai/sim/pull/6313/files
Reloadhttps://github.com/simstudioai/sim/pull/6313/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
rohitsudhakar1https://github.com/rohitsudhakar1
simstudioai:mainhttps://github.com/simstudioai/sim/tree/main
rohitsudhakar1:fix-4737-undo-redo-persist-budgethttps://github.com/rohitsudhakar1/sim/tree/fix-4737-undo-redo-persist-budget
Conversation 11 https://github.com/simstudioai/sim/pull/6313
Commits 2 https://github.com/simstudioai/sim/pull/6313/commits
Checks 2 https://github.com/simstudioai/sim/pull/6313/checks
Files changed https://github.com/simstudioai/sim/pull/6313/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6313/files
fix(undo-redo): bound persisted history by size, not just operation count https://github.com/simstudioai/sim/pull/6313/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6313/files
1f4cb5b fix(undo-redo): bound persisted history by size, not just operation c… rohitsudhakar1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6313/commits/1f4cb5b823b9bab3c8473ac821cb9d1eb41eba0e
4326caa fix(undo-redo): evict furthest-from-use first so redo order survives … rohitsudhakar1 Aug 6, 2026 https://github.com/simstudioai/sim/pull/6313/commits/4326caada45b7c3971245c8a7dd2eb54ce7c3bfa
Clear filters https://github.com/simstudioai/sim/pull/6313/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6313/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6313/files
store.test.ts https://github.com/simstudioai/sim/pull/6313/files#diff-ef94f570cb360ff32095f9cc6f6ed33e3340f19e8d5166915491dc2b988e6416
store.ts https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
apps/sim/stores/undo-redo/store.test.tshttps://github.com/simstudioai/sim/pull/6313/files#diff-ef94f570cb360ff32095f9cc6f6ed33e3340f19e8d5166915491dc2b988e6416
View file https://github.com/simstudioai/sim/blob/4326caada45b7c3971245c8a7dd2eb54ce7c3bfa/apps/sim/stores/undo-redo/store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6313/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6313/files#diff-ef94f570cb360ff32095f9cc6f6ed33e3340f19e8d5166915491dc2b988e6416
https://github.com/simstudioai/sim/pull/6313/files#diff-ef94f570cb360ff32095f9cc6f6ed33e3340f19e8d5166915491dc2b988e6416
https://github.com/simstudioai/sim/pull/6313/files#diff-ef94f570cb360ff32095f9cc6f6ed33e3340f19e8d5166915491dc2b988e6416
apps/sim/stores/undo-redo/store.tshttps://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
View file https://github.com/simstudioai/sim/blob/4326caada45b7c3971245c8a7dd2eb54ce7c3bfa/apps/sim/stores/undo-redo/store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6313/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
https://github.com/simstudioai/sim/pull/6313/files#diff-e6248d4db5595d1c9660638e8261961eee7e39d533c8439e52d8c1242598481f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.