Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim · GitHub
Open Graph Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim
X Title: fix(undo-redo): bound persisted history by size, not just operation count by rohitsudhakar1 · Pull Request #6313 · simstudioai/sim
Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A single operation can carry several KB of block state (an agent block with a large system prompt, for example), so active editing across a few workflows lets the persisted history grow to multiple megabytes and consume most of the origin's shared ~5 MB budget. Once that budget is exhausted, the next setItem from any other persisted Zustand store throws QuotaExceededError. That is why the error surfaces from unrelated stores such as notification-storage or panel-editor-state — whichever one happens to write next is the victim, not the culprit. The existing safeStorageAdapter catches QuotaExceededError on this store's own writes, but that only stops this store from throwing. It does nothing to stop it from starving its siblings, which is the failure users actually see. Fix Cap the serialized footprint of the persisted state and trim inside partialize: MAX_PERSISTED_BYTES (2 MB) bounds what gets written to storage. trimPersistedStateToBudget() evicts the oldest operations by createdAt across all stacks until the payload fits, and drops any stack left empty to reclaim its overhead. Eviction runs in two passes: a bulk pass that subtracts each entry's own serialized length (avoiding an O(n^2) re-serialization of megabytes on every drop), then an exact verification pass that keeps dropping the oldest survivors until the invariant actually holds. In practice the second pass runs zero or one times. The input state is never mutated. Only the persisted copy is trimmed. On the 2 MB figure: it is a deliberately conservative share of the ~5 MB origin budget, chosen to leave roughly 3 MB for every other persisted store, rather than a measured optimum. It is a single exported constant and easy to tune if you would prefer a different split. Behavior change worth calling out: because only the persisted copy is trimmed, the in-memory history is untouched and the current session remains fully undoable. A user who reloads will find that older undo history beyond the budget is gone. That seemed clearly better than truncating history someone is actively using, but it is a real change and I would rather surface it than have it discovered later. Tests Six new tests in stores/undo-redo/store.test.ts: Reproduction: heavy editing with large block snapshots keeps the persisted payload within a sane byte budget. Recent history stays usable after trimming (newest operations survive). trimPersistedStateToBudget returns state unchanged when already within budget. Evicts oldest-first across stacks until under budget. Does not mutate the input state. Drops stacks emptied by eviction. vitest run stores/undo-redo/store.test.ts — 45/45 pass (39 existing, unchanged). biome check clean. Typecheck note: a full-repo tsc --noEmit exhausts the heap on my machine, so I typechecked the two changed files and their transitive imports in isolation, which passes cleanly. I have not verified a full-repo typecheck locally. Fixes #4737
Open Graph Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si...
X Description: Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si...
Opengraph URL: https://github.com/simstudioai/sim/pull/6313
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c8986b7e-a05a-25fb-24a5-34ac074b7a15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B124:CEB06:AC2EE3:F2518E:6AFB79B9 |
| html-safe-nonce | cc48cb5b75a7cd223e173ba9220c474f2fc0d7e3e1a45e677bebc3c3ce08e375 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTI0OkNFQjA2OkFDMkVFMzpGMjUxOEU6NkFGQjc5QjkiLCJ2aXNpdG9yX2lkIjoiNjgwMDAwMDgxODQ5ODczMDQyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 50c63ee645c4a733bddbd7a62b89a4aad4f6d4fcee1a4b22dc308c81e202cbe9 |
| hovercard-subject-tag | pull_request:4218169635 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6313/files |
| twitter:image | https://avatars.githubusercontent.com/u/50651418?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/50651418?s=400&v=4 |
| og:image:alt | Root cause workflow-undo-redo persists operation snapshots to localStorage, but the eviction policy bounds them by count, not by size: MAX_STACKS = 5 x DEFAULT_CAPACITY = 100 = 500 operations. A si... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width