Title: fix(files): stop markdown reflow on open by matching placeholder wrapping to the editor by waleedlatif1 · Pull Request #6285 · simstudioai/sim · GitHub
Open Graph Title: fix(files): stop markdown reflow on open by matching placeholder wrapping to the editor by waleedlatif1 · Pull Request #6285 · simstudioai/sim
X Title: fix(files): stop markdown reflow on open by matching placeholder wrapping to the editor by waleedlatif1 · Pull Request #6285 · simstudioai/sim
Description: Summary Fixes the flicker where a line's word-wrap shifts on first open/refresh of a markdown file (e.g. "…shook only a little" starts on one line, then "little" jumps down as the doc settles). Root cause: collaborative files render a static placeholderHtml while the Yjs doc seeds, then swap to the live TipTap editor. The placeholder was .rich-markdown-prose only (browser-default white-space: normal), but the live editable is .ProseMirror.rich-markdown-prose, and prosemirror-view sets white-space: break-spaces and disables ligatures on .ProseMirror. Different wrapping model → identical text wraps at a different point → the visible re-wrap on the swap. Fix: give the placeholder the same ProseMirror class as the live editable, so both share the exact base text layout and wrap identically. One class added; no width/scrollbar/font changes. Type of Change Bug fix Testing Traced empirically, no guesswork: confirmed prosemirror-view/style/prosemirror.css sets white-space: break-spaces + font-variant-ligatures: none on .ProseMirror, and the placeholder lacked both. Both render sites already share width (max-w-[48rem] px-8), ruling out container width; ruled out scrollbar (macOS overlay scrollbars take no layout width) and font-swap (the bug repros on refresh with the font cached). Cross-checked prior art (TipTap docs/issues + inkeep/open-knowledge): inkeep's warm-HTML fallback avoids swap reflow precisely by reusing the live editor's exact classes — this mirrors that. No UX downside: the placeholder was already read-only; only its wrap model now matches the editor. Visual confirmation on staging recommended after deploy. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Fixes the flicker where a line's word-wrap shifts on first open/refresh of a markdown file (e.g. "…shook only a little" starts on one line, then "little" jumps down...
X Description: Summary Fixes the flicker where a line's word-wrap shifts on first open/refresh of a markdown file (e.g. "…shook only a little" starts on one line, then "little&...
Opengraph URL: https://github.com/simstudioai/sim/pull/6285
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2a23459b-fd28-d4f3-750e-9d3fddb621e5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 99A8:73CE1:9D5402:D7F9D1:6AFB4C92 |
| html-safe-nonce | e74271f496f23f4529d6c509f184807248f892c384bdfcad8df512ad3daacacc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUE4OjczQ0UxOjlENTQwMjpEN0Y5RDE6NkFGQjRDOTIiLCJ2aXNpdG9yX2lkIjoiMTc3MTcwMTc3ODM1ODQyMjY3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 76f4986d3c0b58dd842f4e133d8e35b0af2c57c282ebee245ff25ae5e6b3a053 |
| hovercard-subject-tag | pull_request:4209597539 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6285/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fixes the flicker where a line's word-wrap shifts on first open/refresh of a markdown file (e.g. "…shook only a little" starts on one line, then "little" jumps down... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width