René's URL Explorer Experiment


Title: improvement(emcn): let a modal refuse every dismissal while an action runs by waleedlatif1 · Pull Request #6276 · simstudioai/sim · GitHub

Open Graph Title: improvement(emcn): let a modal refuse every dismissal while an action runs by waleedlatif1 · Pull Request #6276 · simstudioai/sim

X Title: improvement(emcn): let a modal refuse every dismissal while an action runs by waleedlatif1 · Pull Request #6276 · simstudioai/sim

Description: Summary ChipModal / ModalContent take dismissDisabled, which holds all four exits shut while an action is in flight: Escape, outside-click, the header close button, and the footer Cancel ChipConfirmModal now passes dismissDisabled={confirm.pending}, making its TSDoc true — it promised "a single dismiss path shared by the header X / dismiss button / Escape … and disabling dismiss while the confirm is in flight", but only the dismiss button was ever guarded Fixes two live bugs: edit-connector-modal and add-connector-modal guarded onOpenChange against a pending save, then handed the header X a direct onOpenChange(false) that skipped the guard — you could close them mid-save via the X Turns on turbo run type-check for every workspace (was --filter=@sim/realtime only) Why the guard lives in ModalContent {...props} is spread after that component's own handlers, so a consumer-passed onEscapeKeyDown / onInteractOutside would silently drop the floating-layer guard whose comment explains it prevents a frozen-page bug. The flag is published through a context that ChipModalHeader, ChipModalFooter and ModalHeader read, so ModalHeader's built-in DialogPrimitive.Close is covered too — otherwise the five non-ChipModal consumers would get a modal that traps Escape and outside-click but still closes on X. closeDisabled / cancelDisabled compose with ||, matching ButtonGroupItem's precedent: an explicit true still disables one button, an explicit false cannot re-enable a button whose click Radix has already been told to ignore. All 60 existing ChipModalHeader sites and 28 cancelDisabled consumers are unaffected. Type-check gate All 23 workspaces pass today, so it lands green. packages/emcn, packages/utils, apps/desktop and apps/docs had no type check in CI; apps/sim's source was covered only as a side effect of next build. Added inputs to the turbo task so non-TS changes stop busting the cache. This does not cover apps/sim's tests — its tsconfig excludes *.test.ts(x), and including them surfaces ~2.2k errors. That's its own cleanup, not a gate to switch on here. Testing packages/emcn/src/components/chip-modal/chip-modal.test.tsx covers the buttons, Escape, both composition directions, and ChipConfirmModal's pending state. Each assertion verified to fail with the guard reverted. Checked all 62 ChipConfirmModal usages for a pending flag that could stick — the change removes Escape as an escape hatch, so a flag that never resets would trap the user. Every manual useState flag resets in a finally; the rest use React Query's .isPending. None can strand. Not covered: outside-click is guarded by the same flag but is not asserted — jsdom cannot drive Radix's outside-interaction path, so the assertion could never fail. It's code-reviewed only. Nothing here has been opened in a browser. Follow-ups (not in this PR) 29 modals still pass cancelDisabled={pending} alone, leaving Escape and outside-click open. Each needs its pending source verified, so it's a separate reviewed change rather than a blind sweep ModalContent.showClose is destructured and never read — ChipModal passes showClose={false} believing it does something. Pre-existing no-op deploy-modal's chatSubmitting is the most fragile consumer: three early returns inside its try, correct only because finally resets it Type of Change Bug fix Improvement Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary ChipModal / ModalContent take dismissDisabled, which holds all four exits shut while an action is in flight: Escape, outside-click, the header close button, and the footer Cancel ChipConfi...

X Description: Summary ChipModal / ModalContent take dismissDisabled, which holds all four exits shut while an action is in flight: Escape, outside-click, the header close button, and the footer Cancel ChipConfi...

Opengraph URL: https://github.com/simstudioai/sim/pull/6276

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:048cded8-e193-03d1-6908-3a097069ef74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBE4:47529:8A7285:C459D7:6AFB5083
html-safe-noncec9cd0d972c82def40100593c836cb3b0ac1eb926174cc7e0b87d287c8cef92f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkU0OjQ3NTI5OjhBNzI4NTpDNDU5RDc6NkFGQjUwODMiLCJ2aXNpdG9yX2lkIjoiMTk1ODcwOTA0ODE3NzgwNzQ5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c9f442815baa9d276d50200ef9fb192c12f9cbc7ab52709c820bffe061f8887
hovercard-subject-tagpull_request:4208561259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6276/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary ChipModal / ModalContent take dismissDisabled, which holds all four exits shut while an action is in flight: Escape, outside-click, the header close button, and the footer Cancel ChipConfi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6276/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6276%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6276%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6276/files
Reloadhttps://github.com/simstudioai/sim/pull/6276/files
Reloadhttps://github.com/simstudioai/sim/pull/6276/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/modal-dismiss-guardhttps://github.com/simstudioai/sim/tree/improvement/modal-dismiss-guard
Conversation 8 https://github.com/simstudioai/sim/pull/6276
Commits 3 https://github.com/simstudioai/sim/pull/6276/commits
Checks 30 https://github.com/simstudioai/sim/pull/6276/checks
Files changed https://github.com/simstudioai/sim/pull/6276/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6276/files
improvement(emcn): let a modal refuse every dismissal while an action runs https://github.com/simstudioai/sim/pull/6276/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6276/files
947df6d improvement(emcn): let a modal refuse every dismissal while an action… waleedlatif1 Aug 5, 2026 https://github.com/simstudioai/sim/pull/6276/commits/947df6d082c071fc2aadeaa1eb683ce505e25c4c
03f6449 fix(emcn): compose consumer dismiss handlers instead of replacing the… waleedlatif1 Aug 5, 2026 https://github.com/simstudioai/sim/pull/6276/commits/03f6449b3a90a514e9f22a7b42833815945ffa16
993e8fa revert(ci): drop the type-check inputs allowlist waleedlatif1 Aug 5, 2026 https://github.com/simstudioai/sim/pull/6276/commits/993e8fa7df5bc1789d7423041eef12fee140ae73
Clear filters https://github.com/simstudioai/sim/pull/6276/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6276/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6276/files
test-build.yml https://github.com/simstudioai/sim/pull/6276/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
add-connector-modal.tsx https://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
edit-connector-modal.tsx https://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
chip-modal.test.tsx https://github.com/simstudioai/sim/pull/6276/files#diff-1df5483901764f50c8d221fea424b637ac6b98a9974c34b3c9631b8617769cd4
chip-modal.tsx https://github.com/simstudioai/sim/pull/6276/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
index.ts https://github.com/simstudioai/sim/pull/6276/files#diff-85e8dc45d20ed0821f684422d4e98d66a0ff6aa5ab8dc44237165078e6fa95e4
modal.tsx https://github.com/simstudioai/sim/pull/6276/files#diff-51423e0d7e1b79a1155de6b0ea446557ff5b5d08285cd4cce2b2c79db878165d
.github/workflows/test-build.ymlhttps://github.com/simstudioai/sim/pull/6276/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
View file https://github.com/simstudioai/sim/blob/993e8fa7df5bc1789d7423041eef12fee140ae73/.github/workflows/test-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6276/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6276/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/6276/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
...space/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsxhttps://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
View file https://github.com/simstudioai/sim/blob/993e8fa7df5bc1789d7423041eef12fee140ae73/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/add-connector-modal/add-connector-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6276/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
https://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
https://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
https://github.com/simstudioai/sim/pull/6276/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
...ace/[workspaceId]/knowledge/[id]/components/edit-connector-modal/edit-connector-modal.tsxhttps://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
View file https://github.com/simstudioai/sim/blob/993e8fa7df5bc1789d7423041eef12fee140ae73/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/edit-connector-modal/edit-connector-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6276/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
https://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
https://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
https://github.com/simstudioai/sim/pull/6276/files#diff-b64f3b1c2f4d41bacda637da1e78307cdb12c0429da8a8aa38a7d02c37877113
packages/emcn/src/components/chip-modal/chip-modal.test.tsxhttps://github.com/simstudioai/sim/pull/6276/files#diff-1df5483901764f50c8d221fea424b637ac6b98a9974c34b3c9631b8617769cd4
View file https://github.com/simstudioai/sim/blob/993e8fa7df5bc1789d7423041eef12fee140ae73/packages/emcn/src/components/chip-modal/chip-modal.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6276/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6276/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6276/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.