Title: fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode by waleedlatif1 · Pull Request #6263 · simstudioai/sim · GitHub
Open Graph Title: fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode by waleedlatif1 · Pull Request #6263 · simstudioai/sim
X Title: fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode by waleedlatif1 · Pull Request #6263 · simstudioai/sim
Description: Some resource-header breadcrumb dropdowns rendered icons next to their labels and some rendered bare text. The split turned out to be perfectly systematic: Resource crumb menus — all had icons Site Items tables/[tableId]/table.tsx:1097 Rename · Lock settings · Delete knowledge/[id]/base.tsx:892 Rename · Tags · Delete knowledge/[id]/[documentId]/document.tsx:541 Rename · Tags · Delete files/files.tsx:1260 Download · Rename · Share · Delete Folder crumb menus — none had icons Site Items files/files.tsx:1794 Rename tables/tables.tsx:463 Rename · Delete knowledge/knowledge.tsx:923 Rename · Delete Both menus open from adjacent segments of the same breadcrumb, so the inconsistency was visible side by side. This adds Pencil/Trash to the three folder-crumb menus, reusing the exact icons their resource-crumb counterparts already use. DropdownOption.icon was already optional and already rendered by resource-header.tsx:332 — no component change needed. Swept for stragglers A repo-wide scan for { label, onClick } options without an icon in any file building dropdownItems/currentFolderActions now returns zero. Three initial hits were false positives, left as-is: table.tsx:1165 and files.tsx:1127 — toast actions (toast.error(..., { action })), not menu items. files.tsx:1244 — the root "Files" crumb itself, which takes its glyph from the header's crumb.icon ?? Icon fallback. Checks biome clean · type-check --force 23/23 (0 cached) Also in this PR: Connections redrawn on the house geometry Connections was a filled glyph in a tight 0 0 13 13 box with a 0.2 hairline stroke. Measured at size-[14px]: icon glyph stroke library 9.3px 0.90px globe 8.1px 0.90px database 9.2px 0.90px pencil 10.8px 0.90px connections (before) 21.5px 0.22px connections (after) 10.9px 0.90px It sits in RESOURCE_REGISTRY beside Library, Globe and Database and renders through the same renderTabIcon(className), so it read as a different weight class in a single row. Redrawn as a stroke outline on the 24-box at 1.55, preserving the topology: a 2×2 grid with a circle top-right, linked left-to-right along the top, down the right column, and left-to-right along the bottom. Verified by rendering old and new side by side against their registry neighbours at both 14px and 96px before committing. Call-site safety The intrinsic size changes 13×13 → 24×24, so every render path was checked — all pass an explicit square size: resource-tabs.tsx:242 → size-[14px] recently-deleted.tsx → ICON_CLASS = size-5 shrink-0 add-resource-dropdown.tsx:492,669,677 → size-[14px] biome clean · type-check --force 23/23 (0 cached) Also in this PR: FolderCode — rescued from #6262 #6262 was merged at its first commit (86532fed9) while GitHub was still showing the PR as one commit, so its second commit — the FolderCode geometry fix — never shipped. folder.tsx is on staging; folder-code.tsx was left as the original. That commit is cherry-picked here (99b3f626b). Its body path is byte-identical to the Folder body that merged in #6262. FolderCode carried the same fill-based construction Folder did — 0 0 15 13 with a 0.3 hairline stroke. At size-[14px] it rendered a 19.9px glyph at 0.28px stroke where a standard icon renders ~10.5px at 0.90px. Now 10.1px / 0.90px, matching folder and folder-open. Call sites (agent-group.tsx, FeaturePlatformPanel, agent-code-graphic.tsx, playground) all pass an explicit square size-*, so the intrinsic 15×13 → 24×24 change is absorbed. Rebased onto current staging (which now carries the merged Folder fix). biome clean · type-check --force 23/23 (0 cached).
Open Graph Description: Some resource-header breadcrumb dropdowns rendered icons next to their labels and some rendered bare text. The split turned out to be perfectly systematic: Resource crumb menus — all had icons S...
X Description: Some resource-header breadcrumb dropdowns rendered icons next to their labels and some rendered bare text. The split turned out to be perfectly systematic: Resource crumb menus — all had icons S...
Opengraph URL: https://github.com/simstudioai/sim/pull/6263
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f9d926d5-4fe7-85d6-9903-f06d19dae5a7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E870:375283:16EA55:1FFC4E:6AFB4E14 |
| html-safe-nonce | 5d4263f98f3d3b3f2b7ec66987282f35e973084c100606b1e3d2353b70dd86d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODcwOjM3NTI4MzoxNkVBNTU6MUZGQzRFOjZBRkI0RTE0IiwidmlzaXRvcl9pZCI6IjE2MzExNjU2NDY2NTk4NjYxMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 62eb8201ac3ca9dc42f39a4e5f5398920ce9505bfddc7ec2c1497c447a6b704b |
| hovercard-subject-tag | pull_request:4206783912 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6263/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Some resource-header breadcrumb dropdowns rendered icons next to their labels and some rendered bare text. The split turned out to be perfectly systematic: Resource crumb menus — all had icons S... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width