Title: fix(setup): launch the docker app the CLI is actually pointed at by waleedlatif1 · Pull Request #6253 · simstudioai/sim · GitHub
Open Graph Title: fix(setup): launch the docker app the CLI is actually pointed at by waleedlatif1 · Pull Request #6253 · simstudioai/sim
X Title: fix(setup): launch the docker app the CLI is actually pointed at by waleedlatif1 · Pull Request #6253 · simstudioai/sim
Description: Summary Carries over #6250 by @BohdanVilischuk (commits cherry-picked, authorship preserved) and adds a follow-up fix. Full credit for finding and fixing this goes to them. bun run setup only knew how to relaunch Docker Desktop, so OrbStack users got open -a Docker against an app they don't have, a 90s wait, then an error about Docker Desktop's license screen. The wizard now detects which app owns the docker CLI and launches, prompts, and errors with the right name. Follow-up: detection only fell back to the installed app bundle when docker context show failed outright. An OrbStack-only Mac sitting on the default context (OrbStack symlinks /var/run/docker.sock; also anyone who ran docker context use default) still resolved to Docker Desktop — the same hang the fix exists to remove. An explicit OrbStack selection is now the only positive context signal; otherwise we pick whichever app is actually installed, which also covers CLIs too old for docker context show. Follow-up: read DOCKER_HOST first. It overrides the active context, so the context name isn't authoritative while it's set. Docker Desktop stays the tiebreak when both apps are installed and nothing points at OrbStack, matching today's behavior. Non-macOS paths are untouched. Type of Change Bug fix Testing Verified the resolver against a real Docker Desktop install (context desktop-linux) plus shimmed docker binaries covering every branch: Signal Resolves to no DOCKER_HOST, context desktop-linux Docker DOCKER_HOST=unix://…/.orbstack/run/docker.sock OrbStack DOCKER_HOST=tcp://… (remote daemon) Docker DOCKER_CONTEXT=orbstack OrbStack context orbstack OrbStack context default, Docker.app installed Docker docker context show exits non-zero (old CLI) falls back to installed app Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Carries over #6250 by @BohdanVilischuk (commits cherry-picked, authorship preserved) and adds a follow-up fix. Full credit for finding and fixing this goes to them. bun run setup only knew...
X Description: Summary Carries over #6250 by @BohdanVilischuk (commits cherry-picked, authorship preserved) and adds a follow-up fix. Full credit for finding and fixing this goes to them. bun run setup only knew...
Opengraph URL: https://github.com/simstudioai/sim/pull/6253
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:acd99ad1-1739-62e2-e2ff-cef90fe820ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D786:1BD5CA:B56CC5:F93C13:6AFB5284 |
| html-safe-nonce | b0601329641823c49025a867645410c93ca5feee5025531bc89a5bdf8a4ce890 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzg2OjFCRDVDQTpCNTZDQzU6RjkzQzEzOjZBRkI1Mjg0IiwidmlzaXRvcl9pZCI6Ijg1NzU1MDQwOTYzODU3ODI0MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5a1dd0e2fadb513ffaff789ab5c3b9555ecb12c1212e05df72c57abf10c33807 |
| hovercard-subject-tag | pull_request:4205778906 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6253/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Carries over #6250 by @BohdanVilischuk (commits cherry-picked, authorship preserved) and adds a follow-up fix. Full credit for finding and fixing this goes to them. bun run setup only knew... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width