René's URL Explorer Experiment


Title: fix(execution): stop the event buffer retaining a run-length backlog by waleedlatif1 · Pull Request #6229 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): stop the event buffer retaining a run-length backlog by waleedlatif1 · Pull Request #6229 · simstudioai/sim

X Title: fix(execution): stop the event buffer retaining a run-length backlog by waleedlatif1 · Pull Request #6229 · simstudioai/sim

Description: Summary doFlush's Redis byte-budget branch requeued the rejected batch and rethrew, skipping the MAX_PENDING_EVENTS trim every other failure path applies — so the backlog grew for the rest of the run and each retry re-serialized the whole thing (O(n²)). A wide parallel fan-out could drive unbounded heap growth and stall the event loop. Drop rejected chunks instead of requeueing, and increment consecutiveFlushFailures so the existing backoff actually engages — the old branch threw before the increment, so budget failures retried at the 15ms interval. Split batches above the single-write cap. Two large block outputs coalescing into one batch previously stalled the buffer permanently, since no retry can shrink a batch it keeps whole. Terminal status is writer-scoped rather than call-scoped: a concurrent scheduled flush carries no status of its own and can be the loop that drains the final chunk, which left the terminal event written with no status while writeTerminal reported success. A terminal event whose batch was dropped is retried on its own rather than lost with it. Record terminal stream meta when the terminal event cannot be buffered. The reconnect route already documents this degraded case, but nothing wrote the metadata, so reconnecting readers polled an active stream until the poll deadline and then errored. Remove reserveExecutionRedisBytes/releaseExecutionRedisBytes — zero callers repo-wide. Their TTL invariants are already pinned against the surviving flush script. Tradeoff Dropped chunks leave an interior gap in the replay buffer. readExecutionEventsState only signals leading truncation, so a reconnecting client silently misses those events (live SSE delivery is unaffected). Those bytes were never going to persist, so the alternative was retaining them forever. Only signal today is a Dropped execution events… warn. Type of Change Bug fix Testing Unit tests only — each new test verified to fail against the unfixed source before landing. Not yet exercised against a real Redis or a live run; the Lua is mocked in all tests. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary doFlush's Redis byte-budget branch requeued the rejected batch and rethrew, skipping the MAX_PENDING_EVENTS trim every other failure path applies — so the backlog grew for the rest of ...

X Description: Summary doFlush's Redis byte-budget branch requeued the rejected batch and rethrew, skipping the MAX_PENDING_EVENTS trim every other failure path applies — so the backlog grew for the rest...

Opengraph URL: https://github.com/simstudioai/sim/pull/6229

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61840776-fe76-5cb0-ad3d-2820db6fe0f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8468:B85F4:B90EE2:FDBD03:6AFB5266
html-safe-noncee058cdefecc1c07850e1422f1894f2d06cc93b3ee950649e279519c8c4e924fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDY4OkI4NUY0OkI5MEVFMjpGREJEMDM6NkFGQjUyNjYiLCJ2aXNpdG9yX2lkIjoiNTgzNzQ3MzEwMDk5OTY0Mzc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb51fb5d1072cb80351872ac569ed28fcf1540e29d1e01de255c9a35082fbfede
hovercard-subject-tagpull_request:4198449399
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6229/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary doFlush's Redis byte-budget branch requeued the rejected batch and rethrew, skipping the MAX_PENDING_EVENTS trim every other failure path applies — so the backlog grew for the rest of ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6229/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6229%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6229%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6229/files
Reloadhttps://github.com/simstudioai/sim/pull/6229/files
Reloadhttps://github.com/simstudioai/sim/pull/6229/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/execution-event-buffer-backloghttps://github.com/simstudioai/sim/tree/fix/execution-event-buffer-backlog
Conversation 12 https://github.com/simstudioai/sim/pull/6229
Commits 1 https://github.com/simstudioai/sim/pull/6229/commits
Checks 30 https://github.com/simstudioai/sim/pull/6229/checks
Files changed https://github.com/simstudioai/sim/pull/6229/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6229/files
fix(execution): stop the event buffer retaining a run-length backlog https://github.com/simstudioai/sim/pull/6229/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6229/files
7c396f7 fix(execution): stop the event buffer retaining a run-length backlog waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6229/commits/7c396f7c1a0e2a30dbe3b56bd47513936c3a44c0
Clear filters https://github.com/simstudioai/sim/pull/6229/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6229/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6229/files
route.async.test.ts https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
route.ts https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
event-buffer.test.ts https://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
event-buffer.ts https://github.com/simstudioai/sim/pull/6229/files#diff-7d7525d18ecf7583efaa0d408ec6beace469e423fbbf40183f61673a4f0fc802
redis-budget.server.test.ts https://github.com/simstudioai/sim/pull/6229/files#diff-eea3bba0edab094730c69f9d71f043cac47fc6537d3589123814879dc7c78ce5
redis-budget.server.ts https://github.com/simstudioai/sim/pull/6229/files#diff-ef75a1d85215e0147119836b4684db6c1c9df11fee79d06b56b0293ba8ab57ce
apps/sim/app/api/workflows/[id]/execute/route.async.test.tshttps://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
View file https://github.com/simstudioai/sim/blob/7c396f7c1a0e2a30dbe3b56bd47513936c3a44c0/apps/sim/app/api/workflows/%5Bid%5D/execute/route.async.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6229/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/6229/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/simstudioai/sim/blob/7c396f7c1a0e2a30dbe3b56bd47513936c3a44c0/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6229/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/6229/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/lib/execution/event-buffer.test.tshttps://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
View file https://github.com/simstudioai/sim/blob/7c396f7c1a0e2a30dbe3b56bd47513936c3a44c0/apps/sim/lib/execution/event-buffer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6229/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
https://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
https://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
https://github.com/simstudioai/sim/pull/6229/files#diff-96e6a19189fb5b803c6648633ad07c7f9cc7cc68f3926fbbd46bc4bc20b9f9da
Please reload this pagehttps://github.com/simstudioai/sim/pull/6229/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6229/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.