René's URL Explorer Experiment


Title: fix(env): drop the getBaseUrl browser-origin fallback by waleedlatif1 · Pull Request #6221 · simstudioai/sim · GitHub

Open Graph Title: fix(env): drop the getBaseUrl browser-origin fallback by waleedlatif1 · Pull Request #6221 · simstudioai/sim

X Title: fix(env): drop the getBaseUrl browser-origin fallback by waleedlatif1 · Pull Request #6221 · simstudioai/sim

Description: Summary The window.location.origin fallback in getBaseUrl() was added in #6214 as a safety net while the real cause — the hosted env script losing its beforeInteractive strategy — was fixed in the same PR. With injection ordering restored, window.__ENV is populated before hydration, so the fallback is unreachable in any correctly configured deployment. Guessing the origin was also unsafe in the one case it could still fire. An opaque origin — a sandboxed iframe, and /chat/* is deliberately embeddable (no X-Frame-Options) — serializes to the string 'null', which is truthy. getBaseUrl() would have returned 'null' and every call site would have silently built null/api/.... A throw surfaces the misconfiguration instead of encoding it into request URLs. Restores the unconditional throw, mirrors it in the shared testing mock, and flips the two fallback tests to assert the throw (whitespace-only coverage kept). Server-side behavior is unchanged. There was never a window to fall back to, so the server always threw. Callers that already guard getBaseUrl() — getBaseDomain(), and validateCallbackUrl() via #6217 — keep their existing fail-closed paths untouched. Type of Change Bug fix Testing Full apps/sim suite: 18195 passed. The single failure is executor/handlers/pi/cloud-review-tools.test.ts, which shells out to rg via a python subprocess — ripgrep is a shell function rather than a binary on my machine, so it is an environment artifact unrelated to these files. packages/testing suite passes (39). tsc clean, bun run lint:check clean. Also ran the structural gates: check:boundaries, check:client-boundary, check:realtime-prune, check:tool-registry-boundary, check:react-query, check:utils, check:api-validation — all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The window.location.origin fallback in getBaseUrl() was added in #6214 as a safety net while the real cause — the hosted env script losing its beforeInteractive strategy — was fixed in the...

X Description: Summary The window.location.origin fallback in getBaseUrl() was added in #6214 as a safety net while the real cause — the hosted env script losing its beforeInteractive strategy — was fixed in the...

Opengraph URL: https://github.com/simstudioai/sim/pull/6221

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:235fbe98-7749-e07c-d101-83ab3bb7f545
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E34:FBC06:A62C8D:E5A53A:6AFB5154
html-safe-noncefb1d689502fad9ea626ec152fafadf5f812b289f42875d1965dd226a873ec975
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTM0OkZCQzA2OkE2MkM4RDpFNUE1M0E6NkFGQjUxNTQiLCJ2aXNpdG9yX2lkIjoiNzE4NTg1MTU3NTA0MDY5MjU2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca15b2a43fb0a2bbe5f1ba4a8eab9a1678491a4ef1a104f4727136b2c222b038e
hovercard-subject-tagpull_request:4197512571
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6221/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The window.location.origin fallback in getBaseUrl() was added in #6214 as a safety net while the real cause — the hosted env script losing its beforeInteractive strategy — was fixed in the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6221/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6221%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6221%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6221/files
Reloadhttps://github.com/simstudioai/sim/pull/6221/files
Reloadhttps://github.com/simstudioai/sim/pull/6221/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
remove-getbaseurl-origin-fallbackhttps://github.com/simstudioai/sim/tree/remove-getbaseurl-origin-fallback
Conversation 4 https://github.com/simstudioai/sim/pull/6221
Commits 1 https://github.com/simstudioai/sim/pull/6221/commits
Checks 27 https://github.com/simstudioai/sim/pull/6221/checks
Files changed https://github.com/simstudioai/sim/pull/6221/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6221/files
fix(env): drop the getBaseUrl browser-origin fallback https://github.com/simstudioai/sim/pull/6221/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6221/files
ba89105 fix(env): drop the getBaseUrl browser-origin fallback waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6221/commits/ba8910549845512371100436009772685bdbbcf0
Clear filters https://github.com/simstudioai/sim/pull/6221/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6221/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6221/files
urls.test.ts https://github.com/simstudioai/sim/pull/6221/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
urls.ts https://github.com/simstudioai/sim/pull/6221/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
urls.mock.ts https://github.com/simstudioai/sim/pull/6221/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
apps/sim/lib/core/utils/urls.test.tshttps://github.com/simstudioai/sim/pull/6221/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
View file https://github.com/simstudioai/sim/blob/ba8910549845512371100436009772685bdbbcf0/apps/sim/lib/core/utils/urls.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6221/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6221/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
https://github.com/simstudioai/sim/pull/6221/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
apps/sim/lib/core/utils/urls.tshttps://github.com/simstudioai/sim/pull/6221/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
View file https://github.com/simstudioai/sim/blob/ba8910549845512371100436009772685bdbbcf0/apps/sim/lib/core/utils/urls.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6221/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6221/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
https://github.com/simstudioai/sim/pull/6221/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
packages/testing/src/mocks/urls.mock.tshttps://github.com/simstudioai/sim/pull/6221/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
View file https://github.com/simstudioai/sim/blob/ba8910549845512371100436009772685bdbbcf0/packages/testing/src/mocks/urls.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6221/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6221/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
https://github.com/simstudioai/sim/pull/6221/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/6221/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.