René's URL Explorer Experiment


Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim

X Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim

Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and then overwritten from a useEffect, so the first painted frame always carried the default. On any deep link with ?callbackUrl=, the "Sign in with email" and "Sign up" links briefly pointed at /workspace — a click landing in that window navigated to the wrong place. Now derived during render, matching login-form.tsx:104 and signup-form.tsx:118, which already did this; /sso was the lone outlier. The rejected-value warning moves to an effect keyed on the param itself rather than the searchParams object, so it fires once per actual change. 2. Resolve callback URLs against the app origin server-side (73587c7ea) Both reviewers flagged an SSR/client divergence. validateCallbackUrl resolved against a sentinel base (https://callback-url-validator.invalid) when window was undefined, so the server rejected every absolute URL — including the same-origin ones its own docstring documents as valid. Server and client disagreed, and a callback URL derived during render produced one destination in the SSR markup and another after hydration. That exposure was not new to this PR — login-form.tsx and signup-form.tsx already derive during render on force-dynamic pages, so both carried it. Fixed at the root rather than worked around: function getCallbackValidationOrigin(): string { if (typeof window !== 'undefined') return window.location.origin try { return new URL(getBaseUrl()).origin } catch { return CALLBACK_URL_SERVER_BASE } } This makes the server match the documented contract rather than loosening it. The base is operator-controlled env, never attacker-controlled, and it stays fail-closed — an unset or unparseable app URL falls back to the sentinel and rejects every absolute URL exactly as before. 3. Drop the getBaseUrl browser-origin fallback (24f09409a) The window.location.origin fallback was added in #6214 as a safety net while the real cause — the hosted env script losing beforeInteractive — was fixed in the same PR. With injection ordering restored, window.__ENV is populated before hydration, so the fallback is unreachable in any correctly configured deployment. It was also unsafe in the one case it could still fire: an opaque origin — a sandboxed iframe, and /chat/* is deliberately embeddable — serializes to the string 'null', which is truthy. getBaseUrl() would have returned 'null' and every call site would have silently built null/api/.... A throw surfaces the misconfiguration instead of encoding it into request URLs. Server-side behavior is unchanged throughout: there was never a window to fall back to, so getBaseDomain() and getCallbackValidationOrigin() keep their existing fail-closed paths. Type of Change Bug fix Testing sso-form.test.tsx renders via renderToString, which runs no effects and so captures exactly the first-frame window the old code got wrong: a valid callbackUrl present on the first frame, no param falling back to /workspace, and an off-origin value (https://evil.example.com/steal) rejected and absent from the markup. Confirmed the first-frame test fails against the pre-fix implementation. input-validation.test.ts gains the absolute same-origin acceptance and the unset-app-URL fail-closed fallback. All 15 existing open-redirect rejection cases (//evil.com, userinfo smuggling, subdomain confusion, wrong port, wrong protocol, javascript:, data:, tab/newline-stripped variants) pass unchanged. Confirmed the new acceptance test fails against the sentinel-only version. urls.test.ts flips the two fallback tests to assert the throw, keeping whitespace-only coverage. 503 tests pass across the directly affected suites. Full apps/sim suite: 18195 passing — the single failure is executor/handlers/pi/cloud-review-tools.test.ts, which shells out to rg via a python subprocess; ripgrep is a shell function rather than a binary on my machine, so it is an environment artifact unrelated to these files. tsc clean, bun run lint:check clean. Structural gates all pass: check:boundaries, check:client-boundary, check:realtime-prune, check:tool-registry-boundary, check:react-query, check:utils, check:api-validation. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and th...

X Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace'...

Opengraph URL: https://github.com/simstudioai/sim/pull/6217

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2c41f54-b195-8556-483c-bd6a0b499b7c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3F2:1BB96C:B51729:F81D3F:6AFB5249
html-safe-nonce3afdec694a671997f34c1eeb308157cbeb537b79b747f511f3b0a766afdde2e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0YyOjFCQjk2QzpCNTE3Mjk6RjgxRDNGOjZBRkI1MjQ5IiwidmlzaXRvcl9pZCI6IjI2MTk0NzgxNDQ0ODU5MDQ5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac34a672488d8ac20d8d100763f1e049bd446b63ea1622e7fa39e1d670da29e0a2
hovercard-subject-tagpull_request:4197300787
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6217/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6217/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6217%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6217%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6217/files
Reloadhttps://github.com/simstudioai/sim/pull/6217/files
Reloadhttps://github.com/simstudioai/sim/pull/6217/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix-sso-callback-url-derived-statehttps://github.com/simstudioai/sim/tree/fix-sso-callback-url-derived-state
Conversation 15 https://github.com/simstudioai/sim/pull/6217
Commits 3 https://github.com/simstudioai/sim/pull/6217/commits
Checks 28 https://github.com/simstudioai/sim/pull/6217/checks
Files changed https://github.com/simstudioai/sim/pull/6217/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
fix(auth): correct callback URL resolution across SSR and hydration https://github.com/simstudioai/sim/pull/6217/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6217/files
fb97b27 fix(sso): derive the SSO callback URL during render waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6217/commits/fb97b27610e8757975edfa7caaecddc8c7b2a69f
73587c7 fix(auth): resolve callback URLs against the app origin server-side waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6217/commits/73587c7ead435b224fb181391f42d0329f9c5bfd
24f0940 fix(env): drop the getBaseUrl browser-origin fallback waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6217/commits/24f09409a0a5ec5834b4a29fba6fa8d85ef82066
Clear filters https://github.com/simstudioai/sim/pull/6217/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
sso-form.test.tsx https://github.com/simstudioai/sim/pull/6217/files#diff-5930dec231c4beb2b61bf77994dceda839d88d6813e50568337ca23a517d79bb
sso-form.tsx https://github.com/simstudioai/sim/pull/6217/files#diff-ef5b4087760eadee5edf5370f0d200711694865d34885b9465459674f9b1fffc
input-validation.test.ts https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
input-validation.ts https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
urls.test.ts https://github.com/simstudioai/sim/pull/6217/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
urls.ts https://github.com/simstudioai/sim/pull/6217/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
urls.mock.ts https://github.com/simstudioai/sim/pull/6217/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
apps/sim/ee/sso/components/sso-form.test.tsxhttps://github.com/simstudioai/sim/pull/6217/files#diff-5930dec231c4beb2b61bf77994dceda839d88d6813e50568337ca23a517d79bb
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/ee/sso/components/sso-form.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
apps/sim/ee/sso/components/sso-form.tsxhttps://github.com/simstudioai/sim/pull/6217/files#diff-ef5b4087760eadee5edf5370f0d200711694865d34885b9465459674f9b1fffc
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/ee/sso/components/sso-form.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-ef5b4087760eadee5edf5370f0d200711694865d34885b9465459674f9b1fffc
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
https://github.com/simstudioai/sim/pull/6217/files#diff-ef5b4087760eadee5edf5370f0d200711694865d34885b9465459674f9b1fffc
apps/sim/lib/core/security/input-validation.test.tshttps://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/lib/core/security/input-validation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/6217/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
apps/sim/lib/core/security/input-validation.tshttps://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/lib/core/security/input-validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/6217/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
apps/sim/lib/core/utils/urls.test.tshttps://github.com/simstudioai/sim/pull/6217/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/lib/core/utils/urls.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
https://github.com/simstudioai/sim/pull/6217/files#diff-2d9858bd35e3d8ecb2256554f3eca4bfc6d15ae2b888d5c50f3d9a248ad3c33a
apps/sim/lib/core/utils/urls.tshttps://github.com/simstudioai/sim/pull/6217/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/apps/sim/lib/core/utils/urls.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
https://github.com/simstudioai/sim/pull/6217/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
packages/testing/src/mocks/urls.mock.tshttps://github.com/simstudioai/sim/pull/6217/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
View file https://github.com/simstudioai/sim/blob/24f09409a0a5ec5834b4a29fba6fa8d85ef82066/packages/testing/src/mocks/urls.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6217/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6217/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
https://github.com/simstudioai/sim/pull/6217/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/6217/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.