Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim · GitHub
Open Graph Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim
X Title: fix(auth): correct callback URL resolution across SSR and hydration by waleedlatif1 · Pull Request #6217 · simstudioai/sim
Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and then overwritten from a useEffect, so the first painted frame always carried the default. On any deep link with ?callbackUrl=, the "Sign in with email" and "Sign up" links briefly pointed at /workspace — a click landing in that window navigated to the wrong place. Now derived during render, matching login-form.tsx:104 and signup-form.tsx:118, which already did this; /sso was the lone outlier. The rejected-value warning moves to an effect keyed on the param itself rather than the searchParams object, so it fires once per actual change. 2. Resolve callback URLs against the app origin server-side (73587c7ea) Both reviewers flagged an SSR/client divergence. validateCallbackUrl resolved against a sentinel base (https://callback-url-validator.invalid) when window was undefined, so the server rejected every absolute URL — including the same-origin ones its own docstring documents as valid. Server and client disagreed, and a callback URL derived during render produced one destination in the SSR markup and another after hydration. That exposure was not new to this PR — login-form.tsx and signup-form.tsx already derive during render on force-dynamic pages, so both carried it. Fixed at the root rather than worked around: function getCallbackValidationOrigin(): string { if (typeof window !== 'undefined') return window.location.origin try { return new URL(getBaseUrl()).origin } catch { return CALLBACK_URL_SERVER_BASE } } This makes the server match the documented contract rather than loosening it. The base is operator-controlled env, never attacker-controlled, and it stays fail-closed — an unset or unparseable app URL falls back to the sentinel and rejects every absolute URL exactly as before. 3. Drop the getBaseUrl browser-origin fallback (24f09409a) The window.location.origin fallback was added in #6214 as a safety net while the real cause — the hosted env script losing beforeInteractive — was fixed in the same PR. With injection ordering restored, window.__ENV is populated before hydration, so the fallback is unreachable in any correctly configured deployment. It was also unsafe in the one case it could still fire: an opaque origin — a sandboxed iframe, and /chat/* is deliberately embeddable — serializes to the string 'null', which is truthy. getBaseUrl() would have returned 'null' and every call site would have silently built null/api/.... A throw surfaces the misconfiguration instead of encoding it into request URLs. Server-side behavior is unchanged throughout: there was never a window to fall back to, so getBaseDomain() and getCallbackValidationOrigin() keep their existing fail-closed paths. Type of Change Bug fix Testing sso-form.test.tsx renders via renderToString, which runs no effects and so captures exactly the first-frame window the old code got wrong: a valid callbackUrl present on the first frame, no param falling back to /workspace, and an off-origin value (https://evil.example.com/steal) rejected and absent from the markup. Confirmed the first-frame test fails against the pre-fix implementation. input-validation.test.ts gains the absolute same-origin acceptance and the unset-app-URL fail-closed fallback. All 15 existing open-redirect rejection cases (//evil.com, userinfo smuggling, subdomain confusion, wrong port, wrong protocol, javascript:, data:, tab/newline-stripped variants) pass unchanged. Confirmed the new acceptance test fails against the sentinel-only version. urls.test.ts flips the two fallback tests to assert the throw, keeping whitespace-only coverage. 503 tests pass across the directly affected suites. Full apps/sim suite: 18195 passing — the single failure is executor/handlers/pi/cloud-review-tools.test.ts, which shells out to rg via a python subprocess; ripgrep is a shell function rather than a binary on my machine, so it is an environment artifact unrelated to these files. tsc clean, bun run lint:check clean. Structural gates all pass: check:boundaries, check:client-boundary, check:realtime-prune, check:tool-registry-boundary, check:react-query, check:utils, check:api-validation. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and th...
X Description: Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace'...
Opengraph URL: https://github.com/simstudioai/sim/pull/6217
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f2c41f54-b195-8556-483c-bd6a0b499b7c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3F2:1BB96C:B51729:F81D3F:6AFB5249 |
| html-safe-nonce | 3afdec694a671997f34c1eeb308157cbeb537b79b747f511f3b0a766afdde2e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0YyOjFCQjk2QzpCNTE3Mjk6RjgxRDNGOjZBRkI1MjQ5IiwidmlzaXRvcl9pZCI6IjI2MTk0NzgxNDQ0ODU5MDQ5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 34a672488d8ac20d8d100763f1e049bd446b63ea1622e7fa39e1d670da29e0a2 |
| hovercard-subject-tag | pull_request:4197300787 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6217/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Three follow-ups to #6214, all on the same URL-resolution surface. 1. Derive the SSO callback URL during render (fb97b2761) callbackUrl was seeded into useState('/workspace') and th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width