René's URL Explorer Experiment


Title: improvement(settings): one header action order across detail pages by waleedlatif1 · Pull Request #6206 · simstudioai/sim · GitHub

Open Graph Title: improvement(settings): one header action order across detail pages by waleedlatif1 · Pull Request #6206 · simstudioai/sim

X Title: improvement(settings): one header action order across detail pages by waleedlatif1 · Pull Request #6206 · simstudioai/sim

Description: Summary Every detail header now reads [secondary] → Delete → Discard → Save, matching the skills detail page. Five pages rendered Discard → Save → Delete — a destructive chip to the right of the primary one — because they spread saveDiscardActions() first and appended Delete: sandboxes, custom tools, custom blocks, permission groups, data retention. Fixed in the shell, not at nine callsites: orderHeaderActions() ranks actions (secondary → id:'discard' → variant:'primary'), stable within each band. Writing the array the natural way now produces the right header, so a new detail page can't get it wrong. Generalizes past Save — workflow MCP servers' Add workflows primary is now right-most with Delete before it. Delete is a plain chip on the nine resource-detail headers, matching skills, each with a stable id:'delete' (three lacked one, so the chip remounted when its label flipped to Deleting...). variant:'destructive' kept for actions destructive at scale — Delete all passwords, Clear all browsing data, Sign out all members. Removing the single resource you're viewing is already confirm-gated. action.id added to the header re-render signature, since the sort key now reads it. Note on the risky part The shell routes onSelect through configRef.current.actions[index] to avoid stale closures. Reordering the render without preserving the source index would bind every chip to the wrong handler — clicking Delete would Save. orderHeaderActions carries {action, index} pairs, and settings-header-shell.test.tsx pins that at the render level including the conditional-Discard case where a missing action shifts every index. I verified the tests go red when the indices are renumbered. Type of Change Improvement Testing tsc and biome clean; 668 tests pass across settings/skills/integrations/ee. Two new test files (14 cases) cover the ranking and the render-level handler routing; both verified to fail when the mechanism is removed. Not exercised in a browser. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every detail header now reads [secondary] → Delete → Discard → Save, matching the skills detail page. Five pages rendered Discard → Save → Delete — a destructive chip to the right of the p...

X Description: Summary Every detail header now reads [secondary] → Delete → Discard → Save, matching the skills detail page. Five pages rendered Discard → Save → Delete — a destructive chip to the right of the p...

Opengraph URL: https://github.com/simstudioai/sim/pull/6206

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23015255-9036-89aa-076c-33bcc068d2ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2D6:29D5DB:E1424D:134D2BB:6AFB5DF6
html-safe-nonce70fe94e26dc860ce70948955b3549fe0ae9cfe9644d738ab392173d42a67cae4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkQ2OjI5RDVEQjpFMTQyNEQ6MTM0RDJCQjo2QUZCNURGNiIsInZpc2l0b3JfaWQiOiI4NzE4ODE1OTQwODkzNjk1NDc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3d837baeca3d466fab5c76d6146986ae0ac270841b4be06120faa8dc0458b03f
hovercard-subject-tagpull_request:4196497590
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6206/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every detail header now reads [secondary] → Delete → Discard → Save, matching the skills detail page. Five pages rendered Discard → Save → Delete — a destructive chip to the right of the p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6206/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6206%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6206%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6206/files
Reloadhttps://github.com/simstudioai/sim/pull/6206/files
Reloadhttps://github.com/simstudioai/sim/pull/6206/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
settings-header-action-orderhttps://github.com/simstudioai/sim/tree/settings-header-action-order
Conversation 3 https://github.com/simstudioai/sim/pull/6206
Commits 1 https://github.com/simstudioai/sim/pull/6206/commits
Checks 27 https://github.com/simstudioai/sim/pull/6206/checks
Files changed https://github.com/simstudioai/sim/pull/6206/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6206/files
improvement(settings): one header action order across detail pages https://github.com/simstudioai/sim/pull/6206/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6206/files
2cdda6c improvement(settings): one header action order across detail pages waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6206/commits/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a
Clear filters https://github.com/simstudioai/sim/pull/6206/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6206/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6206/files
sim-settings-pages.md https://github.com/simstudioai/sim/pull/6206/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
password-detail.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-b1bed1ea8aed1f1bcc19ff0fe78a4db9ef85fba66e93c1292b3d3eeaadaec523
custom-tool-detail.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-11eb089de269637676a7a35fea835149846787cce4d88f9284c0812a95e85fcd
mcp.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-a4da5c277b6d754bb18bdf732cde648008b9624c1d73729926799e4a5c6a8fbc
sandboxes.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-3a6836b794a6579f7b60d44d6e48ac602216fd7d67c902d34fa8587b17f831a9
workflow-mcp-servers.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-837f49406d0f223c875fd1223cf42f35ad614c98e32feae2b37fc87192767919
settings-header-order.test.ts https://github.com/simstudioai/sim/pull/6206/files#diff-8ab6d483af82e28156371914514ff513533900b6f25487ac31d683fb4bcd20ea
settings-header-shell.test.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-4b6bb285c930568f847aaed9668a30f76f1ea2d7496cd06fce3680de4d45892d
settings-header.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-3d234352f39ccc5c170e72e9f5262bc343c0db7782b47097cb6f802e3348f89e
group-detail.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-21da9abd0aabdc46d5b40bb02d16aaab5be8123ad85290a5e43ebf707cb0d8b2
custom-block-detail.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-e36433dffd6e63e79316556f140cf08718477316572ffb4a268488f11bbfc2f7
data-drain-detail.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-f766b2f4006fd0c48d77761fd9ccfb73b36638cd27ba6e9f38dbf484f569e4c5
data-retention-settings.tsx https://github.com/simstudioai/sim/pull/6206/files#diff-764e9cf912d26c066290a0b604241370dd169586b89737be53eb4827da0b53ee
.claude/rules/sim-settings-pages.mdhttps://github.com/simstudioai/sim/pull/6206/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/.claude/rules/sim-settings-pages.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/6206/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/6206/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
.../[workspaceId]/settings/components/browser/components/password-detail/password-detail.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-b1bed1ea8aed1f1bcc19ff0fe78a4db9ef85fba66e93c1292b3d3eeaadaec523
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/browser/components/password-detail/password-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-b1bed1ea8aed1f1bcc19ff0fe78a4db9ef85fba66e93c1292b3d3eeaadaec523
https://github.com/simstudioai/sim/pull/6206/files#diff-b1bed1ea8aed1f1bcc19ff0fe78a4db9ef85fba66e93c1292b3d3eeaadaec523
...Id]/settings/components/custom-tools/components/custom-tool-detail/custom-tool-detail.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-11eb089de269637676a7a35fea835149846787cce4d88f9284c0812a95e85fcd
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/custom-tools/components/custom-tool-detail/custom-tool-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-11eb089de269637676a7a35fea835149846787cce4d88f9284c0812a95e85fcd
https://github.com/simstudioai/sim/pull/6206/files#diff-11eb089de269637676a7a35fea835149846787cce4d88f9284c0812a95e85fcd
apps/sim/app/workspace/[workspaceId]/settings/components/mcp/mcp.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-a4da5c277b6d754bb18bdf732cde648008b9624c1d73729926799e4a5c6a8fbc
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/mcp/mcp.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-a4da5c277b6d754bb18bdf732cde648008b9624c1d73729926799e4a5c6a8fbc
https://github.com/simstudioai/sim/pull/6206/files#diff-a4da5c277b6d754bb18bdf732cde648008b9624c1d73729926799e4a5c6a8fbc
apps/sim/app/workspace/[workspaceId]/settings/components/sandboxes/sandboxes.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-3a6836b794a6579f7b60d44d6e48ac602216fd7d67c902d34fa8587b17f831a9
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/sandboxes/sandboxes.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-3a6836b794a6579f7b60d44d6e48ac602216fd7d67c902d34fa8587b17f831a9
https://github.com/simstudioai/sim/pull/6206/files#diff-3a6836b794a6579f7b60d44d6e48ac602216fd7d67c902d34fa8587b17f831a9
...workspace/[workspaceId]/settings/components/workflow-mcp-servers/workflow-mcp-servers.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-837f49406d0f223c875fd1223cf42f35ad614c98e32feae2b37fc87192767919
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/workflow-mcp-servers/workflow-mcp-servers.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6206/files#diff-837f49406d0f223c875fd1223cf42f35ad614c98e32feae2b37fc87192767919
https://github.com/simstudioai/sim/pull/6206/files#diff-837f49406d0f223c875fd1223cf42f35ad614c98e32feae2b37fc87192767919
apps/sim/components/settings/settings-header-order.test.tshttps://github.com/simstudioai/sim/pull/6206/files#diff-8ab6d483af82e28156371914514ff513533900b6f25487ac31d683fb4bcd20ea
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/components/settings/settings-header-order.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
apps/sim/components/settings/settings-header-shell.test.tsxhttps://github.com/simstudioai/sim/pull/6206/files#diff-4b6bb285c930568f847aaed9668a30f76f1ea2d7496cd06fce3680de4d45892d
View file https://github.com/simstudioai/sim/blob/2cdda6ce505bafbd9cacaf1552fa1f4a2561a85a/apps/sim/components/settings/settings-header-shell.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6206/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6206/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6206/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.