René's URL Explorer Experiment


Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim · GitHub

Open Graph Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim

X Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim

Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant editing the same file that configures sessions, databaseHooks and Stripe. Moved to lib/auth/connectors/providers.ts behind buildConnectorProviders(); auth.ts drops to 1,489 lines Relocated getMicrosoftUserInfoFromIdToken to lib/oauth/microsoft.ts, next to the three Microsoft helpers it already imports from. It was the last Microsoft identity helper outside that module, and it now has a home where it can be unit-tested auth.ts's own diff is 3 insertions / 2,441 deletions This is a pure move — verified mechanically, not by eye Review with git diff -w; dedenting by four spaces made Biome reflow ~10 wrapped calls. Connector array is token-identical — whitespace-stripped, 60,432 chars on both sides All 179 template literals emit byte-identical strings. Worth calling out: whitespace-stripping alone could not prove this, since template-literal interiors are significant. Comparing the static chunks separately from the ${} expressions showed the one apparent difference was reindentation inside an interpolation, not in emitted text Every one of the 2,441 deleted lines is accounted for: 2,339 array + 86 types/helper + 2 array-literal lines + 14 now-unused import lines. Each removed import verified to have zero remaining references Evaluation order, single call site, and log scopes all unchanged One thing that is not cosmetic The explicit GenericOAuthConfig[] return type is load-bearing. Inline, the entries were contextually typed by the config property. Without the annotation prompt: 'consent' widens to string and stops matching its union, and every getUserInfo parameter becomes implicitly any — the extraction would have silently weakened type checking. Caught by tsc, fixed by the annotation. Type of Change Refactor (no functional change) Testing 667 tests pass across the touched suites. Typecheck, biome, check:api-validation, check:boundaries, check:client-boundary, check:utils, check:tool-registry-boundary all clean. Known follow-ups (deliberately not in this PR) Folding these in would destroy the reviewer's ability to diff the move with -w: ~550 lines of duplication remain. The 14 Google entries are identical modulo the providerId string; so are the 8 Microsoft ones. Two factories collapse them to ~85 lines. That duplication has already caused a live drift: google-ads is missing the await response.text().catch(() => {}) body-drain that the other 13 Google entries have Token endpoints are written twice — Notion, Jira, Linear, Slack and others restate the same URL in providers.ts (initial exchange) and lib/oauth/oauth.ts getProviderAuthConfig (refresh). Change one and connect keeps working while refresh silently dies. getCanonicalScopesForProvider already shows the right pattern The error contract is incoherent across connectors: ~49 return null vs ~17 throw, and readResponseJsonWithLimit is used in 5 of 42 response reads. lib/credentials/token-service-accounts/validators/* is the same problem already solved properly in this repo The module arguably belongs under lib/oauth/ rather than lib/auth/ Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant...

X Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant...

Opengraph URL: https://github.com/simstudioai/sim/pull/6203

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dc6bf28f-0f38-f3af-8c62-b0df13fff4cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6C2:1D7E5A:E86B79:13EFD11:6AFB5EE8
html-safe-nonce8bf183670da8dad1f46d3229d4f0ef002577808d86864cacaca6a875323bf1d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkMyOjFEN0U1QTpFODZCNzk6MTNFRkQxMTo2QUZCNUVFOCIsInZpc2l0b3JfaWQiOiI2NTUwNjk0NTg0MTk0MzkxNzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac20c22fff5f0961fb81f3488fd8c830efd54829e20c25028637a903dd0c0355c9
hovercard-subject-tagpull_request:4191893454
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6203/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altStacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6203/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6203%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6203%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6203/files
Reloadhttps://github.com/simstudioai/sim/pull/6203/files
Reloadhttps://github.com/simstudioai/sim/pull/6203/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
refactor/auth-connectors-extracthttps://github.com/simstudioai/sim/tree/refactor/auth-connectors-extract
Conversation 3 https://github.com/simstudioai/sim/pull/6203
Commits 1 https://github.com/simstudioai/sim/pull/6203/commits
Checks 25 https://github.com/simstudioai/sim/pull/6203/checks
Files changed https://github.com/simstudioai/sim/pull/6203/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6203/files
refactor(auth): extract connector definitions out of auth.ts https://github.com/simstudioai/sim/pull/6203/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6203/files
d8bc901 refactor(auth): extract connector definitions out of auth.ts waleedlatif1 Aug 3, 2026 https://github.com/simstudioai/sim/pull/6203/commits/d8bc9015082d6ac72d564bdd8b77623943ff9cd6
Clear filters https://github.com/simstudioai/sim/pull/6203/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6203/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6203/files
auth.ts https://github.com/simstudioai/sim/pull/6203/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
providers.ts https://github.com/simstudioai/sim/pull/6203/files#diff-8b56f2f3754547ba3fc02e45b285f4f141b2affcc822094c636d90507d69c983
microsoft.ts https://github.com/simstudioai/sim/pull/6203/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
Please reload this pagehttps://github.com/simstudioai/sim/pull/6203/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6203/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.