Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim · GitHub
Open Graph Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim
X Title: refactor(auth): extract connector definitions out of auth.ts by waleedlatif1 · Pull Request #6203 · simstudioai/sim
Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant editing the same file that configures sessions, databaseHooks and Stripe. Moved to lib/auth/connectors/providers.ts behind buildConnectorProviders(); auth.ts drops to 1,489 lines Relocated getMicrosoftUserInfoFromIdToken to lib/oauth/microsoft.ts, next to the three Microsoft helpers it already imports from. It was the last Microsoft identity helper outside that module, and it now has a home where it can be unit-tested auth.ts's own diff is 3 insertions / 2,441 deletions This is a pure move — verified mechanically, not by eye Review with git diff -w; dedenting by four spaces made Biome reflow ~10 wrapped calls. Connector array is token-identical — whitespace-stripped, 60,432 chars on both sides All 179 template literals emit byte-identical strings. Worth calling out: whitespace-stripping alone could not prove this, since template-literal interiors are significant. Comparing the static chunks separately from the ${} expressions showed the one apparent difference was reindentation inside an interpolation, not in emitted text Every one of the 2,441 deleted lines is accounted for: 2,339 array + 86 types/helper + 2 array-literal lines + 14 now-unused import lines. Each removed import verified to have zero remaining references Evaluation order, single call site, and log scopes all unchanged One thing that is not cosmetic The explicit GenericOAuthConfig[] return type is load-bearing. Inline, the entries were contextually typed by the config property. Without the annotation prompt: 'consent' widens to string and stops matching its union, and every getUserInfo parameter becomes implicitly any — the extraction would have silently weakened type checking. Caught by tsc, fixed by the annotation. Type of Change Refactor (no functional change) Testing 667 tests pass across the touched suites. Typecheck, biome, check:api-validation, check:boundaries, check:client-boundary, check:utils, check:tool-registry-boundary all clean. Known follow-ups (deliberately not in this PR) Folding these in would destroy the reviewer's ability to diff the move with -w: ~550 lines of duplication remain. The 14 Google entries are identical modulo the providerId string; so are the 8 Microsoft ones. Two factories collapse them to ~85 lines. That duplication has already caused a live drift: google-ads is missing the await response.text().catch(() => {}) body-drain that the other 13 Google entries have Token endpoints are written twice — Notion, Jira, Linear, Slack and others restate the same URL in providers.ts (initial exchange) and lib/oauth/oauth.ts getProviderAuthConfig (refresh). Change one and connect keeps working while refresh silently dies. getCanonicalScopesForProvider already shows the right pattern The error contract is incoherent across connectors: ~49 return null vs ~17 throw, and readResponseJsonWithLimit is used in 5 of 42 response reads. lib/credentials/token-service-accounts/validators/* is the same problem already solved properly in this repo The module arguably belongs under lib/oauth/ rather than lib/auth/ Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant...
X Description: Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant...
Opengraph URL: https://github.com/simstudioai/sim/pull/6203
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dc6bf28f-0f38-f3af-8c62-b0df13fff4cc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6C2:1D7E5A:E86B79:13EFD11:6AFB5EE8 |
| html-safe-nonce | 8bf183670da8dad1f46d3229d4f0ef002577808d86864cacaca6a875323bf1d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkMyOjFEN0U1QTpFODZCNzk6MTNFRkQxMTo2QUZCNUVFOCIsInZpc2l0b3JfaWQiOiI2NTUwNjk0NTg0MTk0MzkxNzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 20c22fff5f0961fb81f3488fd8c830efd54829e20c25028637a903dd0c0355c9 |
| hovercard-subject-tag | pull_request:4191893454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6203/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Stacked on #6201 — review that one first. Base will retarget to staging once #6201 merges. Summary auth.ts was 3,927 lines, ~2,340 of them the genericOAuth connector list. Adding a connector meant... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width