Title: fix(chat): show table and knowledge base folders in the resource menus by waleedlatif1 · Pull Request #6190 · simstudioai/sim · GitHub
Open Graph Title: fix(chat): show table and knowledge base folders in the resource menus by waleedlatif1 · Pull Request #6190 · simstudioai/sim
X Title: fix(chat): show table and knowledge base folders in the resource menus by waleedlatif1 · Pull Request #6190 · simstudioai/sim
Description: Summary Tables and knowledge bases have folders now, but the chat attachment menu (+ / @) and the embedded resource menu still listed them flat — both now show the same hierarchy as the Tables and Knowledge pages Collapsed the two near-duplicate workflow/file tree builders + renderers into one shared buildResourceFolderTree / ResourceFolderTreeItems / ResourceTreeSections, so all four foldered families (workflows, files, tables, KBs) go through one code path A single FOLDERED_SECTION_SPECS table now drives display order, folder source, ordering, and folder selectability — the skip-set is derived from it, so a new family can't be added in one place and missed in the other (which would render it twice) Side effect of the unification: items whose folder no longer resolves surface at the root instead of silently vanishing (this was a latent bug in the Files submenu) Table/KB folders are structure only, not attachable resources — making them attachable needs resource-policy, invalidator, and copilot VFS support, so it's deliberately out of scope Type of Change Bug fix Testing 10 unit tests for the shared tree builder; mutation-checked that each can actually fail (broke orphan-healing → 2 red, pruning → 1 red, sort ordering → 3 red) tsc -p apps/sim clean, bun run lint:check clean Not yet verified in a running app Notes / follow-ups (not in this PR) Cmd-K search modal builds table/KB rows without folderPath, while workflows and files include it — the receiving UI already renders the breadcrumb The table and knowledge-base selectors in workflow blocks are still flat comboboxes; two tables named the same in different folders are indistinguishable Copilot VFS asserts tables/ and knowledgebases/ are flat namespaces — that's the reason the "not attachable" call above is a deferral rather than a resolution The viewport clamp on the chat menu's submenus (calc(100vw-32px)) arguably belongs in emcn's DropdownMenuSubContent for every submenu, not as a consumer override Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Tables and knowledge bases have folders now, but the chat attachment menu (+ / @) and the embedded resource menu still listed them flat — both now show the same hierarchy as the Tables and...
X Description: Summary Tables and knowledge bases have folders now, but the chat attachment menu (+ / @) and the embedded resource menu still listed them flat — both now show the same hierarchy as the Tables and...
Opengraph URL: https://github.com/simstudioai/sim/pull/6190
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:df7b6cd9-6021-5ca4-f7c6-42b51d0be3b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9B8:C0BA8:778979:A4F322:6AFB43CC |
| html-safe-nonce | 93c092163c3b7020766dbf1c00a16f9eb516caadcf8c9842d3fc6b908e970a4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUI4OkMwQkE4Ojc3ODk3OTpBNEYzMjI6NkFGQjQzQ0MiLCJ2aXNpdG9yX2lkIjoiNTQzMjExNDQ4NzAzNTExODU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9a1a7e30afb0219e75b26396d378266127967b09a858d5f40b54c8dad954955e |
| hovercard-subject-tag | pull_request:4187088192 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6190/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Tables and knowledge bases have folders now, but the chat attachment menu (+ / @) and the embedded resource menu still listed them flat — both now show the same hierarchy as the Tables and... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width