Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim · GitHub
Open Graph Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim
X Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim
Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsync and inflated named parts (word/theme/theme1.xml, word/styles.xml, ppt/presentation.xml, ppt/slideMasters/slideMaster1.xml) with no size bound Reachable from GET /api/workspaces/[id]/files/[fileId]/style and from the workspace VFS (workspace-vfs.ts:1233) Reading only a few entries is not protection: the bomb just has to live at one of those paths It now calls assertOoxmlArchiveWithinLimits — the same guard the document parsers use — and the hand-rolled ZIP_MAGIC byte check is replaced by isZipShaped from that module. zip-guard is already shared this way by lib/uploads/archive.ts and lib/copilot/tools/handlers/upload-file-reader.ts, so this is the established pattern rather than new coupling. Net effect is a deleted bespoke check plus the protection. Why not a cheaper targeted check Bounding only the entries this path actually reads would be less work, but JSZip reports the size the archive declares — the same attacker-controlled field a bomb lies about, which is exactly the bypass #6166 had to fix. A targeted check would have to re-derive that verification to be sound, so reusing the shared guard is both cleaner and the only correct option short of duplicating it. Error behavior The guard sits inside the existing try, so a rejection is logged (the guard warns with details before throwing) and the function returns null. The route already answers 422 with a descriptive message and the VFS already returns null when no summary can be produced — neither caller changes. Type of Change Bug fix (security — resource exhaustion / DoS) Testing The return value alone cannot demonstrate this fix: JSZip also rejects these archives, but only after inflating the entry — which is the memory cost the guard exists to avoid. The tests therefore assert JSZip is never handed the buffer, mirroring the approach in #6166's doc-parser tests. Verified both bomb tests go red when the guard call is removed (confirmed against the now-merged hardened guard, not just the old declared-size one) All 17 real Word-produced .docx fixtures from mammoth's test data are accepted by the guard; 13 still yield a style summary and the 4 that return null are pre-existing (empty.docx, endnotes.docx, external-picture.docx, utf8-bom.docx have no theme1.xml) — confirmed each with guard=accepts Archives are constructed byte by byte in the test rather than generated-then-patched, so a declared size that never matched the payload can be expressed directly Gates: tsc clean, check:api-validation passed, biome clean, 124 tests across lib/copilot/vfs and lib/file-parsers. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy...
X Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy...
Opengraph URL: https://github.com/simstudioai/sim/pull/6176
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:23128440-deb4-9fd6-84ac-84a1d10a144b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A100:186510:74DE9D:A1523B:6AFB43F5 |
| html-safe-nonce | 60dcdc4f1f7562ee5a77a189a7ade2ffa5ee675f90481f88f711d62bc5961b46 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTAwOjE4NjUxMDo3NERFOUQ6QTE1MjNCOjZBRkI0M0Y1IiwidmlzaXRvcl9pZCI6IjExNTAxMTMzMzIyMjk1MjI0MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d8492187c2bbb08a6ae9e62bffec3537feb0563572f76ec9dd595b9e43203f41 |
| hovercard-subject-tag | pull_request:4186096891 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6176/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width