René's URL Explorer Experiment


Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim

X Title: fix(copilot): guard document-style extraction against zip bombs by waleedlatif1 · Pull Request #6176 · simstudioai/sim

Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsync and inflated named parts (word/theme/theme1.xml, word/styles.xml, ppt/presentation.xml, ppt/slideMasters/slideMaster1.xml) with no size bound Reachable from GET /api/workspaces/[id]/files/[fileId]/style and from the workspace VFS (workspace-vfs.ts:1233) Reading only a few entries is not protection: the bomb just has to live at one of those paths It now calls assertOoxmlArchiveWithinLimits — the same guard the document parsers use — and the hand-rolled ZIP_MAGIC byte check is replaced by isZipShaped from that module. zip-guard is already shared this way by lib/uploads/archive.ts and lib/copilot/tools/handlers/upload-file-reader.ts, so this is the established pattern rather than new coupling. Net effect is a deleted bespoke check plus the protection. Why not a cheaper targeted check Bounding only the entries this path actually reads would be less work, but JSZip reports the size the archive declares — the same attacker-controlled field a bomb lies about, which is exactly the bypass #6166 had to fix. A targeted check would have to re-derive that verification to be sound, so reusing the shared guard is both cleaner and the only correct option short of duplicating it. Error behavior The guard sits inside the existing try, so a rejection is logged (the guard warns with details before throwing) and the function returns null. The route already answers 422 with a descriptive message and the VFS already returns null when no summary can be produced — neither caller changes. Type of Change Bug fix (security — resource exhaustion / DoS) Testing The return value alone cannot demonstrate this fix: JSZip also rejects these archives, but only after inflating the entry — which is the memory cost the guard exists to avoid. The tests therefore assert JSZip is never handed the buffer, mirroring the approach in #6166's doc-parser tests. Verified both bomb tests go red when the guard call is removed (confirmed against the now-merged hardened guard, not just the old declared-size one) All 17 real Word-produced .docx fixtures from mammoth's test data are accepted by the guard; 13 still yield a style summary and the 4 that return null are pre-existing (empty.docx, endnotes.docx, external-picture.docx, utf8-bom.docx have no theme1.xml) — confirmed each with guard=accepts Archives are constructed byte by byte in the test rather than generated-then-patched, so a declared size that never matched the payload can be expressed directly Gates: tsc clean, check:api-validation passed, biome clean, 124 tests across lib/copilot/vfs and lib/file-parsers. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy...

X Description: Summary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy...

Opengraph URL: https://github.com/simstudioai/sim/pull/6176

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23128440-deb4-9fd6-84ac-84a1d10a144b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA100:186510:74DE9D:A1523B:6AFB43F5
html-safe-nonce60dcdc4f1f7562ee5a77a189a7ade2ffa5ee675f90481f88f711d62bc5961b46
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTAwOjE4NjUxMDo3NERFOUQ6QTE1MjNCOjZBRkI0M0Y1IiwidmlzaXRvcl9pZCI6IjExNTAxMTMzMzIyMjk1MjI0MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd8492187c2bbb08a6ae9e62bffec3537feb0563572f76ec9dd595b9e43203f41
hovercard-subject-tagpull_request:4186096891
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6176/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6166, which fixed the document-parser paths. extractDocumentStyle was the remaining unguarded ZIP consumer. It handed an attacker-controlled archive straight to JSZip.loadAsy...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6176/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6176%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6176%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6176/files
Reloadhttps://github.com/simstudioai/sim/pull/6176/files
Reloadhttps://github.com/simstudioai/sim/pull/6176/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-fix+document-style-zip-guardhttps://github.com/simstudioai/sim/tree/worktree-fix%2Bdocument-style-zip-guard
Conversation 7 https://github.com/simstudioai/sim/pull/6176
Commits 2 https://github.com/simstudioai/sim/pull/6176/commits
Checks 27 https://github.com/simstudioai/sim/pull/6176/checks
Files changed https://github.com/simstudioai/sim/pull/6176/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6176/files
fix(copilot): guard document-style extraction against zip bombs https://github.com/simstudioai/sim/pull/6176/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6176/files
a917b14 fix(copilot): guard document-style extraction against zip bombs waleedlatif1 Aug 2, 2026 https://github.com/simstudioai/sim/pull/6176/commits/a917b147e797b24b3d79c1a8f414fbeab7d95c1a
52c52be test(copilot): declare the ratio-test expansion instead of carrying it waleedlatif1 Aug 2, 2026 https://github.com/simstudioai/sim/pull/6176/commits/52c52be2340cb9ef674b8962971b42864ef05430
Clear filters https://github.com/simstudioai/sim/pull/6176/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6176/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6176/files
document-style.test.ts https://github.com/simstudioai/sim/pull/6176/files#diff-88c471d4148ec501ee91d844d98b92814b2f7e7c6a0154120267fc1434cf6bc4
document-style.ts https://github.com/simstudioai/sim/pull/6176/files#diff-b28c1694febda74c30953986607f7b7eec56e192728f57eab7d890fd8ec612be
apps/sim/lib/copilot/vfs/document-style.test.tshttps://github.com/simstudioai/sim/pull/6176/files#diff-88c471d4148ec501ee91d844d98b92814b2f7e7c6a0154120267fc1434cf6bc4
View file https://github.com/simstudioai/sim/blob/52c52be2340cb9ef674b8962971b42864ef05430/apps/sim/lib/copilot/vfs/document-style.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6176/{{ revealButtonHref }}
apps/sim/lib/copilot/vfs/document-style.tshttps://github.com/simstudioai/sim/pull/6176/files#diff-b28c1694febda74c30953986607f7b7eec56e192728f57eab7d890fd8ec612be
View file https://github.com/simstudioai/sim/blob/52c52be2340cb9ef674b8962971b42864ef05430/apps/sim/lib/copilot/vfs/document-style.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6176/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6176/files#diff-b28c1694febda74c30953986607f7b7eec56e192728f57eab7d890fd8ec612be
https://github.com/simstudioai/sim/pull/6176/files#diff-b28c1694febda74c30953986607f7b7eec56e192728f57eab7d890fd8ec612be
https://github.com/simstudioai/sim/pull/6176/files#diff-b28c1694febda74c30953986607f7b7eec56e192728f57eab7d890fd8ec612be
Please reload this pagehttps://github.com/simstudioai/sim/pull/6176/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.