René's URL Explorer Experiment


Title: fix(files): authorize presigned upload contexts per type by waleedlatif1 · Pull Request #6175 · simstudioai/sim · GitHub

Open Graph Title: fix(files): authorize presigned upload contexts per type by waleedlatif1 · Pull Request #6175 · simstudioai/sim

X Title: fix(files): authorize presigned upload contexts per type by waleedlatif1 · Pull Request #6175 · simstudioai/sim

Description: Summary POST /api/files/presigned/batch validated its type param against the shared 7-value upload enum but only authorized knowledge-base, so any authenticated user could mint an S3 presigned PUT into workspace-logos/, profile-pictures/, execution/, mothership/, chat/ and copilot/ — objects then served unauthenticated from the app origin with a one-year public cache Batch presign now accepts knowledge-base only (its sole client and its sole authorizable context) and always requires a workspaceId the caller has write/admin on before any URL is minted POST /api/files/presigned had the same class of gap for chat: no authorization predicate, no content-type restriction, no client. Dropped it — every remaining context there has a per-context predicate (copilot self-scoped + type-restricted, profile-pictures self-scoped + image-only, mothership/execution workspace write, workspace-logos workspace admin, knowledge-base workspace write) Both allowlists moved into lib/api/contracts/storage-transfer.ts so the enum that is enforced and the one that is documented can't drift apart again — that drift was the root cause Type of Change Bug fix (security) Testing New app/api/files/presigned/batch/route.test.ts: 401 unauthenticated, 400 for each of the six refused contexts with no URL minted, 400 missing workspaceId, 403 for read/no access, authz enforced ahead of the local-storage fallback, file-type rejection before minting, and the authorized happy path Added a regression test on the single route asserting type=chat is rejected without minting Verified both suites go red when the fix is reverted (6 batch failures, 1 single-route failure) app/api/files + lib/uploads: 449 tests passing; tsc -p apps/sim clean; bun run check:api-validation passed Not included Per-user upload quota / billing attribution for presign issuance. With authorization restored, only workspace members with write access can mint these URLs, so metering is a separate billing feature rather than part of this fix. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary POST /api/files/presigned/batch validated its type param against the shared 7-value upload enum but only authorized knowledge-base, so any authenticated user could mint an S3 presigned PUT...

X Description: Summary POST /api/files/presigned/batch validated its type param against the shared 7-value upload enum but only authorized knowledge-base, so any authenticated user could mint an S3 presigned PUT...

Opengraph URL: https://github.com/simstudioai/sim/pull/6175

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2e192fa7-0ba3-7b67-2555-94e7b9152278
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCF2:29C55F:717C09:9C115C:6AFB4328
html-safe-nonce5d6e97a2f5abe3874e9cc8aabb0b9d772aac58f373956a032098965a49e3720d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0YyOjI5QzU1Rjo3MTdDMDk6OUMxMTVDOjZBRkI0MzI4IiwidmlzaXRvcl9pZCI6IjUyNTY4MTg5OTYwMzE0NzI0MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced1aaa41f6b8c1d4f2b6e83da79c756603f3ef076bba1d7d2282de87c1eba08c
hovercard-subject-tagpull_request:4186082796
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6175/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary POST /api/files/presigned/batch validated its type param against the shared 7-value upload enum but only authorized knowledge-base, so any authenticated user could mint an S3 presigned PUT...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6175/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6175%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6175%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6175/files
Reloadhttps://github.com/simstudioai/sim/pull/6175/files
Reloadhttps://github.com/simstudioai/sim/pull/6175/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/presigned-upload-context-authzhttps://github.com/simstudioai/sim/tree/fix/presigned-upload-context-authz
Conversation 3 https://github.com/simstudioai/sim/pull/6175
Commits 1 https://github.com/simstudioai/sim/pull/6175/commits
Checks 27 https://github.com/simstudioai/sim/pull/6175/checks
Files changed https://github.com/simstudioai/sim/pull/6175/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6175/files
fix(files): authorize presigned upload contexts per type https://github.com/simstudioai/sim/pull/6175/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6175/files
999b80d fix(files): authorize presigned upload contexts per type waleedlatif1 Aug 2, 2026 https://github.com/simstudioai/sim/pull/6175/commits/999b80deaed56018e546aaee311a4873bd39d213
Clear filters https://github.com/simstudioai/sim/pull/6175/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6175/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6175/files
route.test.ts https://github.com/simstudioai/sim/pull/6175/files#diff-db207b850e7bafd531ed15f5470a9edd8d1fe91b90eb5bcd9193085724ed2be2
route.ts https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
route.test.ts https://github.com/simstudioai/sim/pull/6175/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
route.ts https://github.com/simstudioai/sim/pull/6175/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
storage-transfer.ts https://github.com/simstudioai/sim/pull/6175/files#diff-863f7d0ace58810918b90840a39c43967e8aad8f46cb539d2dacd9c41085c36b
apps/sim/app/api/files/presigned/batch/route.test.tshttps://github.com/simstudioai/sim/pull/6175/files#diff-db207b850e7bafd531ed15f5470a9edd8d1fe91b90eb5bcd9193085724ed2be2
View file https://github.com/simstudioai/sim/blob/999b80deaed56018e546aaee311a4873bd39d213/apps/sim/app/api/files/presigned/batch/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6175/{{ revealButtonHref }}
apps/sim/app/api/files/presigned/batch/route.tshttps://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
View file https://github.com/simstudioai/sim/blob/999b80deaed56018e546aaee311a4873bd39d213/apps/sim/app/api/files/presigned/batch/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6175/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
https://github.com/simstudioai/sim/pull/6175/files#diff-d297e4f6a0aeab1c990637cc6c528ddf020d161fe62222fa727b53df0bb0bb5c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6175/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6175/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.